diff mbox series

[1/2] dt-bindings: phy: fsl,mxs-usbphy: add fsl,hold-line-without-vbus property

Message ID 20230614111548.1815146-1-xu.yang_2@nxp.com (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: phy: fsl,mxs-usbphy: add fsl,hold-line-without-vbus property | expand

Commit Message

Xu Yang June 14, 2023, 11:15 a.m. UTC
The data line can be kept or disconnected when vbus is not present. This
will add a flag "fsl,hold-line-without-vbus" to describe this behavior.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski June 14, 2023, 5:18 p.m. UTC | #1
On 14/06/2023 13:15, Xu Yang wrote:
> The data line can be kept or disconnected when vbus is not present. This
> will add a flag "fsl,hold-line-without-vbus" to describe this behavior.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
>  Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> index f4b1ca2fb562..c5f9d8a8298e 100644
> --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> @@ -87,6 +87,13 @@ properties:
>      maximum: 119
>      default: 100
>  
> +  fsl,hold-line-without-vbus:
> +    description:
> +      Normaly, the data line should be disconnected if vbus is not
> +      present. This flag is used to hold data line even though vbus
> +      is not present.

Why is this a property of a board? Why some boards need it? Neither
commit msg nor property explain why do you need it.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
index f4b1ca2fb562..c5f9d8a8298e 100644
--- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
@@ -87,6 +87,13 @@  properties:
     maximum: 119
     default: 100
 
+  fsl,hold-line-without-vbus:
+    description:
+      Normaly, the data line should be disconnected if vbus is not
+      present. This flag is used to hold data line even though vbus
+      is not present.
+    type: boolean
+
 required:
   - compatible
   - reg