From patchwork Fri Jun 16 09:27:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Ming X-Patchwork-Id: 13282417 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CEFEEB64DA for ; Fri, 16 Jun 2023 09:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VLZ4oUFGlkHL8I9YJPVhwEmtkMh4KiRQMSqWbMO5Cmw=; b=2uJNZZkyp42E/a 9N7d3oC44+pdMfeg1x48tzY8gJYn3K/lUlCLS0LZY/cuOgVeUEboeUdDdwVqNBggZGGhWrVHAQKSD hJNVXN4koE9D2gMSdSm2/yF3t6/HpkZ2xPkc8oDk/H9jSNlpxHXmpooaL1AgKjG7FAQFjognZO+EF hFgYGvYIjVknr1nuFW4miSAsSYhs7cqyLLaF4n6Rsxxz5RhNoCzTB0eSfFTVK3FhLlIhEuPzv/9oI r+3udbCYG/FVw7b27SMCK8EWf0b3+634R0CRuWgY6lG6dEgD/Y8TkGS3XUm+OCNukMnG5JPBgHZJz u9t1tLXvwCFNazFFS3NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA5oA-00HT77-2q; Fri, 16 Jun 2023 09:31:54 +0000 Received: from mail-psaapc01on2072d.outbound.protection.outlook.com ([2a01:111:f400:feae::72d] helo=APC01-PSA-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA5o3-00HT2r-32 for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 09:31:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZvsfP/cmSd0ikLMUDvWgOYgiLrfDEQvLNt4h1KSFK6vFXifbfr6sQnBR24n4vxDewu8HR1UwzDDBCbu1txo2m3AIFu3wsp3E48WmZRY5h7GgBhB68YOT1JLMJz0bnFFzF1juSU50O5KpH+9kIRphRVWnSgn51dhBw5TQ/gp9sL37HhnJnFuqPJ5WRNSqxP/+Z+BInquq4roi+BxjBBvNfb8QZvZDc0ZWwv7aQ6OLw1D/MVvmzjW5Fu7IiqNz/rknuhFzBueXT7RGysJdDUeY4ZmV497PzWeua4dEyYeXO4je2KiafCgmfR4LrwfZswJ9ya66nNLvMYZHpN4+Pdd6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C1fTmVQ/Nno+8zd0igo4h5Qltk6mA902miwye7qBYgo=; b=oFx5+L/aYA1zrmAn1gxNvYN6t5j9U7jkJi5MdBml3izMya3Hd5mhzG9pIz4mOp7QvSvhg0srpaqUh3nY6GQ3Urkyuupp4JHQcRCQRs3xyfBgDVBhHQz7swRrNQTGa+qULrf+tT7XwyMTfo5yD/wc6KI3HfhVkN3auFdLDRxJWvFL/SlVTmfDRbWA2lbEhmaaqdE5YIsGarCJiEf/5vwsxOVJ94tA3tLTjgIXAzu3IYjDnMfS1OFU35RwCOWvex3XEGggabzgIkrfXldX8RG3vNFdKps0LPrLAV7K46qOUaGIpFdpIa8KT76ENJX8Nc9L4jokGqmP7wLVFenmwQPwOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C1fTmVQ/Nno+8zd0igo4h5Qltk6mA902miwye7qBYgo=; b=lOHdDWpeTWvAGICDirGm5qypSPQLF8fFTYVGMALiA5HaVN1ctAUZ2YKu76Kd6I/BIQTIY8248DfeE55LUH9yN9ZPPjG+Rr+BQEynYrxkqHJMWd5X+LMhE41QGMJ4mJbDlKQlq33JbN6b9E4u9xEi5O8spmTXVgCE/mGSg+wkwy5ISKH1ul9okOp0VXXAApLfWhVunAbSE09mqr8mInZxQTShPUTL0p/q6VCqc2/aF28Z2unKucO0OfsYkivNaB50exII/Nd+v3l0OtSr6X0J2MxZlNmSIerIzE4VajDd5hhsJSrJ/SaXSsxppDCvuDbhKDuU7FXOJ9ekvD9Um8LpGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from PS1PR0601MB3737.apcprd06.prod.outlook.com (2603:1096:300:78::18) by TY0PR06MB5330.apcprd06.prod.outlook.com (2603:1096:400:213::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Fri, 16 Jun 2023 09:31:37 +0000 Received: from PS1PR0601MB3737.apcprd06.prod.outlook.com ([fe80::9531:2f07:fc59:94e]) by PS1PR0601MB3737.apcprd06.prod.outlook.com ([fe80::9531:2f07:fc59:94e%4]) with mapi id 15.20.6500.029; Fri, 16 Jun 2023 09:31:37 +0000 From: Wang Ming To: linyunsheng@huawei.com Cc: opensource.kernel@vivo.com, gregkh@linuxfoundation.org, Wang Ming , Sunil Goutham , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Stephen Rothwell , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drivers:net:ethernet:Add missing fwnode_handle_put() Date: Fri, 16 Jun 2023 17:27:39 +0800 Message-Id: <20230616092820.1756-1-machel@vivo.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: TY2PR0101CA0030.apcprd01.prod.exchangelabs.com (2603:1096:404:8000::16) To PS1PR0601MB3737.apcprd06.prod.outlook.com (2603:1096:300:78::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PS1PR0601MB3737:EE_|TY0PR06MB5330:EE_ X-MS-Office365-Filtering-Correlation-Id: afc7deaa-627a-46f2-71dd-08db6e4c7b91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MCUG8D5tVxp+5v0vSQE1lWOtdw4+5gSk2Yaato9pD1gC3iPakVwpEEDVRdYv2iyTYIjhzeeMJ11rPIYepT0gBTu+HTlJ0supGl1LLYZG4qdHegHX7CG+mdDnFgM7WGpl8yM5AfzMg+Lh6Sp/TzzrbBnm18bT8YEmrUmK9HITX0OSxtCrqXrFl1WT5AjFhf6ZuwA0ocqGejm5ZSHCD7Ghm2POGOeG6LOWKb2AJYc3fA4kki9/8OcQ7am4/DAaxHOLX8m5cgg31qQ+kVovX2WQYYBSItkmrYfcWVcOs98hynZRxqc1kRP1aRegqby24eh2sGZ/j9B8sseQBG4TRi8vM07CWK5OFCRjwyii8E2CXNjBc1RqrMnFK6n0IFusEI1W+d6BDm3mu3gBOwJ8loVnTJmAUETHGASpAv30zw7VhIa930E+wS+DYXyuUBZdDTcdIRTZHuYevndfbt1PxL/PFVMI5Kiz99X3vuad8dQY/SFUc7lhRytiJ5OaFZJpgb3N/GyUgAtxFLuSZi4aJGTi7YFRaMUmP94h7+CCoRSJiYFQw4zuCjzPq0T7Bql41YqzJP3aEL+nN6DyFCSlYgaFi55RMcCq3KFIPGzhzfwjunaZyyUvBInWh3xcMD7PMEvd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PS1PR0601MB3737.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(346002)(396003)(366004)(136003)(451199021)(83380400001)(52116002)(6486002)(2616005)(478600001)(6506007)(86362001)(26005)(1076003)(6512007)(186003)(4326008)(6916009)(316002)(66946007)(66476007)(66556008)(4743002)(54906003)(38100700002)(38350700002)(5660300002)(7416002)(2906002)(41300700001)(36756003)(8676002)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CmW28APg6QxjCl9W76/ozZMHiOxFS/KKHG0VmT1eG7q+nSfvznSAh1goohTCkhFSDHf5WlEu1wsKSJR0wz7+TngGkdYgamBD+7wYC1QbJfnLKRQlbMoR7ik5QSS5CAXBjKOYsE+39TvWX4T0IW2oP6+8E2xemexUpFvDYlT1G8dDJ2lVUiRLk2kXIHPyFs0xrW86SF/fYLMNquLUgQS1f1+jp1E97GvEHnYNnoB9qKh4HkGpIFfIjlNV7Iyg7flJ+8hkqAD/dFC49A0skBzmuwKTlCNoEG2LFmdECkdJeYVqfGGLT0tlBIYWuQaDT2JZxhgdOK8/j66bhYh5Kk7I9UIMnMmMlkiPWUkS2G+HnNKfcSG6BqA1Mb/Y+Imzkp4YQuNdS2qpnsv5zYmzu1RsfAJSBPoGQhOCSIZK1N/AfW2WS18ISRpMTuucvidlGJxOD0aJdV+RzHWVmW6x4clPIFccvOGExzc3XOrHiSCdYVKcT3K8HtI4cI20/qXqgfh+t3R4hSEDtmTkMLQcUR4CoyBwqF+H44L1gkPeTAS69pDgtbG/BxTbmXbgC+zIRK5Vd8HIyrOD4WclL2NQksMofqJF1TVRytSvfyE4PqWGQjo/3Dy2ANkOZzSAWjelg0Eq4jjX5uuQISc8WKJVBQx6FtT6pWIwcNhfSvdNQkRTMRrH0h0+97RNSG6hQATlg5foEZch7PUl5y4KwQUsU0PXvmSz8c1pGrGZ4xMmp0DHj58d+I7MwRm4YH3kYwZoL99GhclS1mrp9U3+pX46s28ucxTZ0JA9vjRWa4GgRlZpZn0JkcPEsiNxmILZeDI9+r1u+FXVV6gnJdNKqZm17x0DtJ/Fh36blrGqboDdQ5f87FUiz0PNHXXIgQai2XiqqefmhEcKZPsxnWwho5uu9gTz6ITAYZdCjuGV50o2UCF5hg84sDaFLB20P7697Eu4r4j6DNtn0pqc0kAkU3Y+Dv5wWDva653B3zHXySs/EcVaztH3cMYZi2cQsczZQBm8KAFd9B/yJuUzAOU/AZj+f8i86InYvslEPuXMfDzjkMEerSIoHSFIqHLQkzwyc5tlF8U/35rsfMKW5u/8npCUk6zXpP8JN1k2DCFTtRZT7Itz4+FLAihh6d7Qs8RkO2yv3Qh5KtAmd0qaSTX3a/P7md0MwqkKrt1eFka6kM2gFN/xLVMS5bk4x7frHKZZ77SYqog/owKlWyNjtDDBPsiOSEgv3kvZid0EsJbx3fBpz8aC4GbFZgWfN/6MXfc3zhaCwE+5qhhKbn8XjwjId5JdsmX7BDReBlxI+4/nPyUYE0AiY53qeX+LoUOeKFce52A+N6cm8z2HQQnhOCFWT1+orDsrIzPer7SZ+cC/VXo7YFw1wWCsYZ93f3/WPopuHb8cxMtRbUteeWFnu58+JV1aQtWsdU9xgu4O1CnskOT5RTwuvCrQR0X6I2NScz7Woq100it//3cu70ghlewcjbiQyaHNpH3hqCpEK9qwoGjJ7UgK9m0l9qdk9FxqfWFhuGvurgq9TgN4n0k3NM9blhFPvIKWBT5EP0JH9obms/7F08SS5Jj3+/o67LZB9vCvemFWsLau X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: afc7deaa-627a-46f2-71dd-08db6e4c7b91 X-MS-Exchange-CrossTenant-AuthSource: PS1PR0601MB3737.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 09:31:37.5900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1PjWz+rctC3OhJ/WWCdSvz7pI3dJqXdJPH9mjoetq9853t+3h2T6NiN8tYtaF9zb/F3TKn9ou0BNO7pbvXfFnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5330 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_023147_985470_26E6735A X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In device_for_each_child_node(), we should have fwnode_handle_put() when break out of the iteration device_for_each_child_node() as it will automatically increase and decrease the refcounter. Signed-off-by: Wang Ming Fixes: 53ab6975c12d ("Add linux-next specific files for 20230609") --- This version adds 'Fixes:tag' compared to previous versions. .../net/ethernet/cavium/thunder/thunder_bgx.c | 37 ++++++++++--------- 1 file changed, 4 insertions(+), 1 deletions(-) -- 2.25.1 diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index a317feb8d..d37ee2872 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1478,8 +1478,10 @@ static int bgx_init_of_phy(struct bgx *bgx) * cannot handle it, so exit the loop. */ node = to_of_node(fwn); - if (!node) + if (!node) { + fwnode_handle_put(fwn); break; + } of_get_mac_address(node, bgx->lmac[lmac].mac); @@ -1503,6 +1505,7 @@ static int bgx_init_of_phy(struct bgx *bgx) lmac++; if (lmac == bgx->max_lmac) { of_node_put(node); + fwnode_handle_put(fwn); break; } }