diff mbox series

[v5,1/4] dt-bindings: arm: amlogic: add Amlogic A311D2 bindings

Message ID 20230623081242.109131-2-tanure@linux.com (mailing list archive)
State New, archived
Headers show
Series Add Amlogic A311D2 and Khadas Vim4 Board Support | expand

Commit Message

Lucas Tanure June 23, 2023, 8:12 a.m. UTC
Add bindings for the Khadas Vim4 board, using A311D2 soc, a Meson T7
family chip.

Signed-off-by: Lucas Tanure <tanure@linux.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Kelvin Zhang June 25, 2023, 10:43 a.m. UTC | #1
> Add bindings for the Khadas Vim4 board, using A311D2 soc, a Meson T7
> family chip.
> 
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>   Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 274ee0890312..8dbd65170c50 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -211,6 +211,13 @@ properties:
>                 - amlogic,aq222
>             - const: amlogic,s4
> 
> +      - description: Boards with the Amlogic Meson t7 A311D2 SoC

Lucas,
Based on the previous discussion, I strongly suggest dropping "Meson".
T7 is designed for smart display, which does not belong to old Meson series.
You can refer to S4.
Also, t7 -> T7.
Thanks!

> +        items:
> +          - enum:
> +              - khadas,vim4
> +          - const: amlogic,a311d2
> +          - const: amlogic,t7
> +
>   additionalProperties: true
> 
>   ...
> --
> 2.41.0
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 274ee0890312..8dbd65170c50 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -211,6 +211,13 @@  properties:
               - amlogic,aq222
           - const: amlogic,s4
 
+      - description: Boards with the Amlogic Meson t7 A311D2 SoC
+        items:
+          - enum:
+              - khadas,vim4
+          - const: amlogic,a311d2
+          - const: amlogic,t7
+
 additionalProperties: true
 
 ...