From patchwork Thu Jun 29 19:14:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13297227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A367BEB64DD for ; Thu, 29 Jun 2023 19:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xJDthd2Tz3Q9bPvfqw5wkxgqxDrvi5f0RmApCDovdgM=; b=TqdMODQrmwR7gI wZSor33h4ECpni731YsAcv7L1ZFe8M8VAzn/Ynk39OXT/T/f4DY7OpuLNb7/KOW2TWzQQjlxiHkGC /IAtyTT/9w+xbkQ6xro/J5hkuprqh0Pco0Oa0dVAXxEpiriVMsQFzMF2bn3oLfu4vHBMMfMJzamci I3Rvsx128UJdmO6R9wEKcAtejwrcuod8zOIkIHXfMfGaD018h1k8nnb/X8L78CvDFmsi31pPckN8M L1XyI0Yp+ZF6qHnE4OKEbFklHPg0awEieEK1MJUOulQ//O5gKg/zaaSK6FRGFnMKwjrMjQdUVu6Ui TonfaIu1kNmlbdo2DU2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEx9n-001ubQ-36; Thu, 29 Jun 2023 19:18:19 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEx9k-001uZz-1P for linux-arm-kernel@lists.infradead.org; Thu, 29 Jun 2023 19:18:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688066295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdunTKBXq26vcyYb/EdIVE7YvQRq/YPpQ2jK2C3l7sY=; b=OxgZ0IToitIiREuAP84nFUYWDhhJQSQE7LFraQph9XobWd7Od28v7Lrr6VDjlsezSNP1pX InI4mjImAj98vC7RoiA0Pm83FMN7XfG+RowmBax1Fx+zSMhRV4Crj9aOh0e3Hy+zoMakGT xPf9uWnslAbi2YZvkyk2WRj83iXAhEY= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-qIiBXwwkOYuhX2MN77U7sw-1; Thu, 29 Jun 2023 15:18:14 -0400 X-MC-Unique: qIiBXwwkOYuhX2MN77U7sw-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5704991ea05so8769527b3.1 for ; Thu, 29 Jun 2023 12:18:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688066278; x=1690658278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IdunTKBXq26vcyYb/EdIVE7YvQRq/YPpQ2jK2C3l7sY=; b=FAnlMroRfJmYcbyqheIJwg0rQqBOwxTuOiHfO16CAP2B26ZHwjOBmuqh/avKpyS/Ym CI6olYLC7QOx6TbrCZnpoViXH/NHv5JVb5O9N4I+bsL02lssLuUVEZkuw/Y9NBKb1rbm nJyNsyhaTUVhhVQRpxZG0jVOes9BNIdTSHcXwiD810uvBb0HTLpIU6X8nbUJU4lRL//l TNlUH28+qUBj0q2kaiZwJja9ZgEZ008lGlo8/VRPlE7VzljRG/tFBwE9qT9eIrgBQCbw 889e8am6UCGPaRK5Lpa0uYrxAij0cmXbL0bBMsbuhiqc13HBbjJamwUvbD8uq+zF4K52 m2vA== X-Gm-Message-State: ABy/qLYGcSG5AnWsvM/hdNiC56IKUDyG7lZxvOmgO0g35aIXINopZPcO 2NDIbL9hJ5/KZPkeTgr9o/Gl5DxW76ZLxgLTvgXuslvSeOtrQx+IchEkw+H15Q7+jBP0iDnpgw8 suQaQVZWZFRoHA54YSvXu36tgyymuK+tmQuE= X-Received: by 2002:a0d:f2c4:0:b0:570:6fbd:2daf with SMTP id b187-20020a0df2c4000000b005706fbd2dafmr303063ywf.37.1688066278443; Thu, 29 Jun 2023 12:17:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlGWPYjej9cDTBj9PaobIHZOXCIJHkmLixBjf5KfzXTvWmIZX19PFv5oYzbDnjlXG204DfghIQ== X-Received: by 2002:a0d:f2c4:0:b0:570:6fbd:2daf with SMTP id b187-20020a0df2c4000000b005706fbd2dafmr303048ywf.37.1688066278207; Thu, 29 Jun 2023 12:17:58 -0700 (PDT) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id w127-20020a0ded85000000b0057085b18cddsm3052478ywe.54.2023.06.29.12.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 12:17:57 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, mcoquelin.stm32@gmail.com, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, joabreu@synopsys.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, bhupesh.sharma@linaro.org, vkoul@kernel.org, bartosz.golaszewski@linaro.org, Andrew Halaney Subject: [PATCH 2/3] net: stmmac: dwmac-qcom-ethqos: Use dev_err_probe() Date: Thu, 29 Jun 2023 14:14:17 -0500 Message-ID: <20230629191725.1434142-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230629191725.1434142-1-ahalaney@redhat.com> References: <20230629191725.1434142-1-ahalaney@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230629_121816_550636_21B0B580 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using dev_err_probe() logs to devices_deferred which is helpful when debugging. Signed-off-by: Andrew Halaney Reviewed-by: Andrew Lunn --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 3bf025e8e2bd..a40869b2dd64 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -710,8 +710,8 @@ static int qcom_ethqos_probe(struct platform_device *pdev) plat_dat = devm_stmmac_probe_config_dt(pdev, stmmac_res.mac); if (IS_ERR(plat_dat)) { - dev_err(dev, "dt configuration failed\n"); - return PTR_ERR(plat_dat); + return dev_err_probe(dev, PTR_ERR(plat_dat), + "dt configuration failed\n"); } plat_dat->clks_config = ethqos_clks_config;