From patchwork Tue Jul 4 14:14:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Ming X-Patchwork-Id: 13301319 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 553B9EB64D9 for ; Tue, 4 Jul 2023 14:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=bKimL7aPr8GQRt3OcARJ4SaBwZXLLDF4BaCN+aXdn5w=; b=ebYl3qBZ0R91Mj ZpNpux8IC6fKM0CyqD/RlXqPxfBnjlqnz8h73oHvrGxwJgLTSGlBwfX5p+lbu4gdlfa6QoTL2ZDSG PD6xER6k4Tqi9EDvrkbXoSqfOaWqnYqgDQdWhNE7zcJe1eQHFogXsPjHQFmZ1VqjSwFB5lvBGcu9Q sIFx3p9uzvfCiPxpQUikmJt1V9BMxzadZfRdKxCeJZvNKv5oru3xO+RUYIkn/yvI4SSXO0WadEHc3 pMzDB0/7hIVxOrOLr7SAiUHLMYPEIKFUCdUIZ3BXV8r3ODjmlSsmZkvKYcuI6ZV0/bqe/JD/K4RRg v3qJ0BCsuIDMbTbatp9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGgol-00DUxI-1g; Tue, 04 Jul 2023 14:15:47 +0000 Received: from mail-tyzapc01on20721.outbound.protection.outlook.com ([2a01:111:f403:704b::721] helo=APC01-TYZ-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGgoi-00DUtI-1j for linux-arm-kernel@lists.infradead.org; Tue, 04 Jul 2023 14:15:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JMqUNyvnf48g3wEizlhr8x02x87sVrQnHGei59fFigPA9V9ptFcbNy5vGoyg6TXlq7vMXAZJr69N9ZRJYldyrc0MYKS0FowEvhGoLIS1Qwhr6fbDzOS1L6pKXZ7bHeNmpzhAvGkb6RP7Zhdent5hF4Wc8+BSBkTa/nRmKPNUD2tyAg7r9ckWtsjf8nK8gh9inbGhT4uf5YIazh8CXctSpOAVGkE1UpvJ9rOyNu81Bga2Jy+eN1b+NzMDdrUc63fVo2P7u9PNj37GtzF9y7LQb6yR4orFXEQzBWgRpqKZGQkANzaTOag2JPNQDH0jwupVmhuEFDF7tm7U69/fI2mjSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7h1tp1AY3NqGS04yt6SldZtzLsJxnEukrlGFBGYdCww=; b=BTZtc22Lc35eOALW/7GwyXXUJU1lCA0hJyrvhx804GCzMThjDmg/DCIBXSXNSHvie5OXwm+pmXNuyvo8AzsmV2+qXIpz2NeQEHCQKBcpdUSUnXTNXLEDddRNcppKXD1LAEYl54GbuMi/iDXQ7JgMKoPVxaenFAf3vsQwpgpP6JkQ6EA8F0E8VLRt1ZN7/dS0XfBg8caFVJ8ir/+jAt1mUKXNEcHorksca4LI6WtnbciDhQV0PI5sQaUYDHaXqWaH2eeCvQqb6pf9OIaCO+EycRiFJ5rOmmnbn5TPoq2dNR8I2Pou9BcBVac0c6uzKAdjXHV7Y3djc3VQ8jIA6riBbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7h1tp1AY3NqGS04yt6SldZtzLsJxnEukrlGFBGYdCww=; b=IdfffuhWq8Nu/PKhb0R9eqwuoRwtrcOaxSnPpxMeUlIeplbzeiim8d7nDehBgpjqiUego6A9OMQxpson4SwWjIUPIeP0OeYPqiw8X/VGQWHPELOZGxPkULKqTtF1TCAn7KwXjqtMil0wiT4/IFdMdUwrbR2K4MSHKARXHGxOUwk/T7xRumRNtN4edr+04M25AcPYrLAp9j9/pjDtkpg993uZFm00SJeTaK/fBwwpKMaDxJE9FFnBhiegbWXFszgahaFVjUZWop04ogxz16e7S4/QguRy2A9o+wtqdw4my8u3FI4EeWN4Bd98WSaxEYkp+Y+QdIwkAhV+kKOt/8yRyg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) by TYSPR06MB6527.apcprd06.prod.outlook.com (2603:1096:400:474::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:15:11 +0000 Received: from SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::7dfd:a3ed:33ca:9cc8]) by SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::7dfd:a3ed:33ca:9cc8%6]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:15:11 +0000 From: Wang Ming To: Sunil Goutham , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com, Wang Ming Subject: [PATCH v1] net:thunder_bgx:Fix resource leaks in device_for_each_child_node() loops Date: Tue, 4 Jul 2023 22:14:47 +0800 Message-Id: <20230704141457.4844-1-machel@vivo.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SG2PR06CA0205.apcprd06.prod.outlook.com (2603:1096:4:68::13) To SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PR06MB3743:EE_|TYSPR06MB6527:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c2d2e9b-5d2b-4d1c-0555-08db7c9913cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G4lIL+GGZykyvdoRJQCQJDwXpIpVd4vK0Q/INmKDSRcR9ZJ4UbhS4x8llyiXv4EOVvE+iTHFRR2FZU+SIwzoWz9IOH1Se8Iik+2w/SwnasTEx0ntoj6lPY36MptT3dNaOCB4Xts7fGOFNJyQDA01TLZDtaG3zF/xBCNvXi0riXT4JfuAsEMRAKAEan0lXdnog8oOqWiX9gRHe05Q/FCJbTxdrE8IdRL6/T6dIX8Dse1Xgln0YvfjOOsEZg0UH6xv7bkvg4fqBv/a9ND9Hc03LuKDQWj+IPGoMB7MJAUch2F008QGNq+9btNM9GyxDJ+vQyFr/7WxXilV7MxhURL0sdy2SBHoi77Elgc7xO+LPxDi/LjEc1q+gqXtCoUqgCrnw/DUCxoO/HHx0ZXO11Pe0SON7N096X3O+IAKJ19mxPryu0CSeeh11WKeQ5sP3wyCyK27jvy8bHAI9B5yyA4ReN2Q2deijBBGLGSylrBoasYXZrun2SA/VedEHwmvNMq1qC7Oz2FI9ZI+Ivdpeqxpi7uUV+IvnwhvmwGDgH003yvlAkY64v9QfAHFdVKYhrNOcsHNG/QDBWlWFMIgoCbpOerKOamJGgkl54sq4M98S8/zB49z/TYW2N5GMBq5we8v X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3743.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199021)(107886003)(26005)(478600001)(1076003)(6666004)(6512007)(6506007)(86362001)(2616005)(186003)(38350700002)(38100700002)(66476007)(66556008)(4326008)(66946007)(110136005)(83380400001)(52116002)(6486002)(316002)(8676002)(8936002)(41300700001)(2906002)(5660300002)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YCjC9m7BE31g3tIBUFwBMAlJ0RZ3YrSMkHjwQd1DHo401e3cEekYjhzJOdZOvAS8QRoib+MM82ZSNYakGgSkzc4WUJBxrumcvQ1aB0mqTC2Q5UxepT69nz7/Do+u9IUFbEChj98xFqsBfWDp9YXW/DSMjjjFuyGp2q269ausI8Z/95VKc1KoumAdbwaH8vPthSya6BmCKU0BUYuQOkK3isCXfNGv1nKjzF2SmEPv1B6dCM8ON+LPLt3HDPDPuj25s50xbVpYWw0v8T1DtZvky5+pkJHwh1/yM09apetvCw4lmF25VYQQGOV2dpDrdpNi414zH6Wt0fPHw/SwYL/fXs+FXkxq2TxKGuwESfSVPQuox3ow+7FZyqKMmSRp1+84jk6kGR16PJPts/RA8EBmhVOm9FXN+sNbi932xA8wSPh0EbItdSqlbxg9QqBFUkvXHnqwPO3z9K+5hOJt+vlUuRXcBjOjpxKzKecnop3ijVqjlkoo7rMI9HUGB5P3n0HX0g6+mpLbOFoUtvb0kRBUGujXMn2Y5shWTWFwGW06qAONATQJBG7kYiS/3j4nxmEXZkcvyEgn7QHuGYZgJJo75uTiPmjrgJgKygi+XMVtU7QFReX9BSR4AOMy/PGDR/ATzjUSvMkO4ka2pAYi0RM4zjY2W/Km+57myMZ4YDt7v1H0OHh6NO0N9qAYbUTAOHpjP6QaO0+J/5ke6R+3ctuZCHu4xZkZp7vrPiZNNf2oGcvHv2QcxfFA80rwuEPEewOh39FV096eIoq0mH30l0Pk9K1PJypn7fo0zhN2J6o3KFCbdvjXdRQ7kKPWHT+xWNw/XMFVYWccU10kHgbBPi7GaJ/7K7N67BlMD8y3/2FmC28bUney7OTMxXdsdtKNQg6/B8nRs+tpaIm7uvEcEqrlX3YLmWoL8X3bs/uJWrCfecE6sbeXjcrkSmrPDuPW+M5ADCqSO9/fbnNRgDJXfLYITT51u8zjCpKsojgDP9pGFtyTzK7mwvADbFohMm9Gkalnc5aO23wV5q+rgMi5FHTuV5ztRXKhf+LWVgDHWjsWf0P8zelwoxPtvlMiLtRmNTutvTZCKJ7DyiIGY78+p8CtTYvj1gCebaGV0BigK4kLj6eJ2CyquiwRsZjfiR8w/aaRAPMmDEbBHrfSjda3KdqKyN7Z3hu7326if8dujPefdEG0mAKplEaADNv8onY/NauxAAyk7J/vvv8lSUPPKbV4Emb54W9vfttVwRer/KqnYo+dbF9/WyI/n/Bqjh7Czs3A/AawxnhEoCcomWi6SUqti7jveTCGRFdU9aNxSOHrl93dbjyKHFyihBnoaGyVrNkMwmM9nrOk4h2Li9IhAwLXVKosDTziv19wrPAxn4wVOR4WufQWKlXn1H3HUHzqg7f6u0S6P7JHYYV6vWhKszbplEarC1UahlwWAXCCpUyk3DPU1VRmFFsGZmohgA+QDT3CWrDvTwpv8woVYq0Efw0JQzINWuhhtAT/G0v1Q/XiFn2yZrGMwzXHh2IxT4u9RPzL3VuFWQTvkC485vYBo4+NSPbK0RO82RR6MM9Xtgz47wIfnehEt0Dtxr1FhxnccakZ X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c2d2e9b-5d2b-4d1c-0555-08db7c9913cf X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:15:10.8801 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YnqzQmSPnlNU0+dDJWrpdiRmP/z7mtfB8yg5w2jAu9z5YhK/LXHHtqNfVQ3cT3bbzdLLjCDK9ddhGYPDHc90Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6527 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_071544_599359_E6C1DD71 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The device_for_each_child_node() loop in bgx_init_of_phy() function should have fwnode_handle_put() before break which could avoid resource leaks. This patch could fix this bug. Signed-off-by: Wang Ming --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index a317feb8d..dad32d36a 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1478,8 +1478,10 @@ static int bgx_init_of_phy(struct bgx *bgx) * cannot handle it, so exit the loop. */ node = to_of_node(fwn); - if (!node) + if (!node) { + fwnode_handle_put(fwn); break; + } of_get_mac_address(node, bgx->lmac[lmac].mac); @@ -1503,6 +1505,7 @@ static int bgx_init_of_phy(struct bgx *bgx) lmac++; if (lmac == bgx->max_lmac) { of_node_put(node); + fwnode_handle_put(fwn); break; } }