From patchwork Fri Jul 7 11:40:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 13304811 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC4C2C0015E for ; Fri, 7 Jul 2023 11:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3jFXEkXXrd4ZLdXCW4otlVf1naVCZ0aAf8jsE+1F2A0=; b=olPfZFFbIS/A5f 17mEfBhiI9t+1zTnS0On6BKjAgXelZb7vmOb54DUs7nkJnybl4AjFh0nnqudcdPrVKdBOv+CtUVc5 Q1qNx9hSnVUXjCK0Docu+UWLSKIop+kqX9s0cH5m7k0dEpVLLKU7HhbzlG8Y2/EWZeP57slROpJdN rCmpqdkGamtrJr9N0lk9sxfhFEAPALqAGu/fgRb9TgrdO4PHTaRYp6qGVmx8C4MuT88lJDtmgjxYv gmp3YsNXJdLPF1f6oP3Qi6scBmx9FWUO9BRkvOeSnvUI7LHl5Iz4NBiW3SfMvV1vfj7nGUWgear5F GlNd1SCH8He22KAo7ItA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHjpS-004XGQ-05; Fri, 07 Jul 2023 11:40:50 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHjpL-004XAI-0O for linux-arm-kernel@lists.infradead.org; Fri, 07 Jul 2023 11:40:44 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b63e5f94f1so22296421fa.1 for ; Fri, 07 Jul 2023 04:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688730022; x=1691322022; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZcYUDOqJwcnI0rZxF8MC2CVlK/gvIRzHIEEYdCrU150=; b=AttyoGxS9Yybu+KrPhODbgPo1ibZlHVw1NGjDlgQZ0sflOxKd/DY+m6mhoBjQGqf+S Wj52TTp/q5aT3p31xx+CLr5ol50iGZ/4YRIFtq/PvkjScZKFtn+M+jveaLmQ9I9fkuCq nrRHG+y+58chctNYqCv8PslHYNN0ACIj45LaxTo1Rg6SE2JJs9UNqTt4abVxN4yyxuvy bJRD5qEy4Q9CqjvE5EsmbaXsQaUqnNVEqq7oCvH8wT56tjeba1lUrMdnM1X+addZwzwr 4hgA4bRD7CXdlaIl7pLdvAzZUmwZnZEmFqZ13yZhDT6dHYE+jq6QoDebnEUF+PsoHvKJ DtTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688730022; x=1691322022; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZcYUDOqJwcnI0rZxF8MC2CVlK/gvIRzHIEEYdCrU150=; b=IcVabn1TQa5pfzOdFV69m4N/OeSBWV8PXdQPlHHx3iiyFzY+l1sMDZ05icOB2e/e+L 9AejWBZenpsFMcz77GmmlYQVjhgmUijT7EgFB4/ixmbG2l4JkM/7+Vl9bhxUdP0JVIau 7v1JDwq9uIBPFF+S+NmV21jsvkwnKrhs4wqRwoHhfPY9XXnUm/qu8TFGi+s5TYulDxzl 1SrOd7SYcvDv62fP72nzcM6FcV66+NWYRZepv6kD4uXHmo336vxP/9N4jWCgP+CDIJHU 5gpnn5OKmPiVlqe4bmYS6l+0HMHhkoIEF0hAqSiN2G9VwwyhUy1qxb0lJi0DdP3WRMNq cPvg== X-Gm-Message-State: ABy/qLY18DdLV34JG77jLmG+lI+Eh6wokA0qVvUhChixlq7GQJHeNyvZ T3DXbFUBKodT1W6cG8N52B0= X-Google-Smtp-Source: APBJJlFcyOGmUxZKQAeZ1TNI2PrZMrKitNqQ1n9Xv5Q6YkvWNzom6LGLG3LSX5KQYEKvTaBDbUS/1Q== X-Received: by 2002:a2e:3311:0:b0:2b5:8b02:1000 with SMTP id d17-20020a2e3311000000b002b58b021000mr2018845ljc.8.1688730022213; Fri, 07 Jul 2023 04:40:22 -0700 (PDT) Received: from localhost.lan (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.gmail.com with ESMTPSA id k19-20020a2e9213000000b002b708450951sm607722ljg.88.2023.07.07.04.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 04:40:21 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Florian Fainelli Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andre Przywara , Viresh Kumar , Sudeep Holla , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 1/4] ARM: dts: BCM53573: Drop nonexistent "default-off" LED trigger Date: Fri, 7 Jul 2023 13:40:01 +0200 Message-Id: <20230707114004.2740-1-zajec5@gmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230707_044043_161010_869028DB X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rafał Miłecki There is no such trigger documented or implemented in Linux. It was a copy & paste mistake. This fixes: arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dtb: leds: led-wlan:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: 'default-off' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 'usb-host', 'usbport'] 'default-off' does not match '^cpu[0-9]*$' 'default-off' does not match '^hci[0-9]+-power$' 'default-off' does not match '^mmc[0-9]+$' 'default-off' does not match '^phy[0-9]+tx$' From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml Signed-off-by: Rafał Miłecki --- arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts | 1 - arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts | 2 -- 2 files changed, 3 deletions(-) diff --git a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts index 0734aa249b8e..b9dd50844419 100644 --- a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts +++ b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts @@ -26,7 +26,6 @@ leds { led-wlan { label = "bcm53xx:blue:wlan"; gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>; - linux,default-trigger = "default-off"; }; led-system { diff --git a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts index e6fb6cbe6963..cb22ae2a02e5 100644 --- a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts +++ b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts @@ -26,7 +26,6 @@ leds-0 { led-5ghz { label = "bcm53xx:blue:5ghz"; gpios = <&chipcommon 11 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-off"; }; led-system { @@ -42,7 +41,6 @@ leds-1 { led-2ghz { label = "bcm53xx:blue:2ghz"; gpios = <&pcie0_chipcommon 3 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-off"; }; };