From patchwork Mon Jul 10 13:19:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 13307134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 941BAEB64D9 for ; Mon, 10 Jul 2023 13:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=m2fg6Qeh7B71tKwoAh7jYFinBZm5KKvkFaPertaYbVA=; b=SzaTZN1gcVfvG+ rDeLDcwrVlhDuuw/QqULsKgP7/nzaFwYUVYrPlgHpXB30+OynRfiCRz3NUzDc/d000qK3Dsi54Do5 5Gmi80uBucFMbioBJ1rWWfl83fmT4PCLNInd/y3URdSqVfOauvR1/NgzoAif31pJ8++uJgF5ntvMt GIDdrBuzF7LsKItpPiK/QlJhZC3jj2zWV6IDosfYw3WEd3SK62JlMIIjbnyDu6m8Wj08u8949rdxV OTYLKIPciBr20x/jH2eo8EVqirf0UKIVrhIftD2MdcIHagmnIPK7FnNnVHZoY2bGCtPSzl7VpK5/K sAdf5NDLOfiZdTI+1TTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIqoj-00BjmN-0A; Mon, 10 Jul 2023 13:20:41 +0000 Received: from mail-sgaapc01on20720.outbound.protection.outlook.com ([2a01:111:f400:feab::720] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIqob-00Bjfo-27 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 13:20:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=htOVpUO2j8elDid3u3guFhgnz17pMmqPGz0E4aB5G8WgPzdgwgoY7jGCVXTQGpV+UKILVK356RCbdzOpZonetQaFT2IYIehIzNWpBW40B60z5bV/OgOViapPYzy/AxedSwGaee/DOz2SB4OWgDvI/UjidVNYuYQFNhgxCQqpu8ZrtXwI4Wn95ivvm5uIEpoRQQYstqiJoO5meMzYzIag02MmOuFbNI3kyHPlemvWwk1H+rjxqEwAv074wtjqVv2mXxZXWbOXSPj7wwd41kt7YJQqIRmFByb6HG0ZM51JOKHwt/lGidQv/sXpVDNlsyNjK/davTZwBQDDlc/v3wvD3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fs+EtTk758No/dWDSdfwTWpFXRynKbiaOREM2MESQn4=; b=PihuN6cO2+1tqQ0BxY9BkcZK5riTFqD4f5yrjqgIkFww7anlwdidLzB/7cXzPeUiO3JMHhu1pg0c5/XkdzSo0arJemMM6xRou3KQpX8IzVBFcRhpHIC7sRXDOiMgkTkDDEu0nkEroWlCHtXlqNuwZO8SCYhWQkRRRb+ajZ/zz3l0mYddSiZTkPZTmjgKUhWSKbTAqBjn3HWCNESJn5EOSDTmPJZ/T0kDIDrMrx8uzBptL2vPz4G1kKI+38gtXwUw3HTMte3xLVwfOpeGl+VjdAi4TSsFsVpjg36e/vDc5pZNvtu14ruVEheKRgUuIAadjh+2IzjnlvfoV44KFKlpHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fs+EtTk758No/dWDSdfwTWpFXRynKbiaOREM2MESQn4=; b=e6+SJ2Ff74lGYIRyLlWS/gH4e9qeUPe4UahvESCw6W7a5NGWTASypO/4BObv3ztcCKRa6o/qBpcVEXdDkx+VtWkyncEKU9LQk42dvSKgjmM8z0hCcThKEWbehgeY/M+otKYPju3lk3aJIY2OK8N+WdxstPpquwphCAUiANLsDWZ8z1NxXVR6y0mrvLd6v7G9TL/Zt74SxMPDbRCl16FrXarPh3QWsxm/lY5YwIfd4W38UhOcbvqShmWGRkmD71TwBkGKbb5O4MTmswcw6PGGQUXfoIR8I+EbsdTrKYDIgBIoK7ohJ8ezrxPLeSRkc+djzsYMU6yn+GPo0jmv6GFTlg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SG2PR06MB5131.apcprd06.prod.outlook.com (2603:1096:4:1ce::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 13:20:12 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Mon, 10 Jul 2023 13:20:12 +0000 From: Yangtao Li To: Sascha Hauer , Pengutronix Kernel Team , Helge Deller , Shawn Guo , Fabio Estevam , NXP Linux Team , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: Yangtao Li , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] fbdev: imxfb: Removed unneeded release_mem_region Date: Mon, 10 Jul 2023 21:19:58 +0800 Message-Id: <20230710132001.50764-1-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: SGBP274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::17) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SG2PR06MB5131:EE_ X-MS-Office365-Filtering-Correlation-Id: c236b37b-e1fd-46d8-a131-08db8148639b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mS3vPm/H1rv4xygV6WaSNmQdASxQUrCoCXxA3t8M4RHe16SkoK8KwJNs3qdZ93Q/BC/zkKLIIwRMdYN9TkJyuQdUEMcYHmXRmOyf8C8BdNYlqcEHPUeyRTiYVvOw0koC90Ag/m8YsJKbTn39Esvv0UklLmI/4DTnzEBvjo6VqADLRM9Hw+iopl+ipuRwqCixSWZzqRRVrcVAZg7/xkaUkBjWP32iWQBjkV/44xfVCcVONQXPvFqICTnMAY8P3k7nvTHVG8wAi+KcIWkxkYR4h16321THvSmQP2uCn+Vbtj0Tl/Yuywmwonvb3O5A+q2eun2vKNE7ZAojU57h+x+x/aoaqTZ1nBaQ1fMSGRTE9s2dKeueQa5EgmJv+Ydg5hcaGtRNGt7sYdXqnGsvBzRU5gCBaFafrK/8IMfJLl+20IfhtsvA7rnCvqmRZ76zEH560dOoZGPDF/2dEonpHdfCeYhiEbNbVbDWoAc1w0YhGUdouGMUws8OYADAv0xLjY8s0ARsE+YSzADaAyOFikYUm2rWpz1PEWIEqziFP+G7hpRU3kLoKTuSaIjc6hGWvuFye7lLio5TnXzr03pDF8d1d33Ejy934XCBwMwUhI3cDZcmtr0ZSqNE/0RgKvhtfFnH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199021)(38350700002)(86362001)(38100700002)(36756003)(6666004)(6486002)(52116002)(110136005)(26005)(6506007)(186003)(6512007)(1076003)(2616005)(7416002)(5660300002)(2906002)(66556008)(316002)(478600001)(66946007)(8936002)(66476007)(8676002)(83380400001)(4326008)(4744005)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: islLeWcQBhH4+AToX3FcMqMKCqus2bQKwqb3NNOwZNfiw49ggPzoGugAodV2hFoDXReUlCfOYq7Ff6xEpwU0MidH4CgIDEkehPi10RyPkhBNaN6nvzX6An2tJ1Mh6m68WagWwD4wfAzuNoifrHr1DAwwoiY7tccTCDVLkzk9rH+5VFX50rHReI+/Qk+nbqn2WC2s1i9AqNpnJgbFmKLviIdeV7Any5B0QPjP2MDeFlpcx8L/KbfzKqLcZMuMhAyFb1YYfIzPeXlOIqbzazT7Ero47mXa7cYLh2R16u1vxQ3JoJ8XyJulrzY13Zpxbqwrtcv7O9NOgh0/NHZqrDmaro/k0S7yImI9mqa71LxsAthxsiEHFpPUIA+65C+9hIADWBUibnXkG4lX4cx67CVsMyBkJ67k+7Q2us2rXxLfu2TW8Kakyusd0zLElCyZjBR3bRzkGqjG9lcSbucdlYVi8r/4DMTxq+gW8bgoZQM9XBaI5XkIYWQX9Kh2RIub0u8ZYmCRnN9x7zP5kBXl8SHUnlNORjzFMfZfNO4P0vHk98/vqTOZzOhfxyhlSgO/w+jxnqmG579inQia/5xC0ZsuUhj8hHTHCqUM2JEv5Qk4tgEQ+T8Rqb2wWda2bADR2zEk4+L5G2kGaCJThaOL6XYVEEz17xqEAlbxZfLtVnYn/QETOhCiOQOCnqb09MwImlx8gMhpSX5HPbcfuHXGCxXBp97Tfa+uFf6q8bNFsByPXJJkXvpa6ruH7qhizQIrMMo3jqIXG3vAKV4ZzSQpNYg4RpFbjntXccgjqliZXmwCd+q6oFQd1lypFOGPTLiUzRpC+h+hBiAIvQE1ApU0WWbB/qAzsjYN+5rkeCWYt+41YcmIs3ZLMSmf8HnzmGZfiBd0EmpTklt9b/dzNRVlGJ/k28cD2V8r/UACNdY39jwXv3eEsM/pK1fuVdxYV2BKwcAgeShWmqaU0vyghhlMAT+wqcQ6AOiZMkZ4azt36dHuykEtuZOG9bsy9g8RjYIjI34Xwir4n2IG+HKDkgs7Y82CyPeiKnY8Qd4gME7Lx7mUzbLHvLMa/cgvTGZkZG1LXzrwtNzKbjmTmVvdbz4qlLCYtBu2EVN9wtzq7+D0jpglsxvgQKrM3MkIL+bk/x5Uhq3CtF2lx02b542CFqu6ZEuUYWEOQwWmfDfCS23o1sC6paVqTAnEX9+Db6O08X/wnBbxPkxcmsHQNcwxL0zcHUq/saSyYvw8IKnUZKL31tm4o5unEL+tpBTT4MeagrcV79LcM/WJm+yt8KTtfFfOJGS5Kkg5l4HYAPkUCHpqLNgCaaeJYU9tgxBUpSl2zlhlV/fY0MPSja2yzVfT5zwTdoFndrxigvdL/5DQIYWDOfW0XOWannwmtpYMCC0gYvNWhpiulCbcxXHK8c+0Y5wfHnryzqCcEH/8I9boVSZITavRw+o5Y4PfAANT3uEoWWsrOQk1JduToZDtHPxi2EbYA5Nu7WT3JVVsGAHYQHf/chnB1DtUtj14cFmV9/R/YPcLUiMdDHVilNbXDsS5aSeg4r03WUvGTFmr/IOPUhrqi86GucpcwshxFPAkWJWgsMUf0GTy X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c236b37b-e1fd-46d8-a131-08db8148639b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 13:20:11.4121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: laGEcHXNLlipK8dw2WLzhy0Mjii6dOQGBunFhp2pgwCp8MhQbxqMXqpjxHb1nCAMM15aXWOiXaGsIiHGS0BvBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5131 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_062033_692767_E9916010 X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary release_mem_region from the error path to prevent mem region from being released twice, which could avoid resource leak or other unexpected issues. Fixes: b083c22d5114 ("video: fbdev: imxfb: Convert request_mem_region + ioremap to devm_ioremap_resource") Signed-off-by: Yangtao Li --- drivers/video/fbdev/imxfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index 04f3bf30a529..385c4715c7b7 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -1043,7 +1043,6 @@ static int imxfb_probe(struct platform_device *pdev) failed_map: failed_ioremap: failed_getclock: - release_mem_region(res->start, resource_size(res)); failed_of_parse: kfree(info->pseudo_palette); failed_init: