From patchwork Mon Jul 10 20:06:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13307577 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA4B0C0015E for ; Mon, 10 Jul 2023 20:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w7xuhFAfNfoAh4Bc/E389RV/sarXORjUhyIMGLMMGNY=; b=F+2+YTXPxmZDkL Ob1RDGIhvBE8RvkMj2puocZ7fwEwuohxZavKg6q9GIjeuenl5nZJib96R7hulqEl6aBfeZy0Pz3tm 2Ntl3biXzBkk046cq79tBO46qsj75c3ieBz/JfE7/GkZr9FPCgfpxKN+F6+MZ+9zEND+VynqahAPs N4IK6FHtWQgWqxrxoEn1RKocup0rBga0SaQg4vq3GO8aGXFfulJWHGFigiH+4Ve4ncBtn8/bY/56c JF+OpFn6qx/tH9BmiGBm5qqp5uExuzQCnZrfGxz4K7eRcF5mQmC3oS/sGcd7vb5tdQaY41RUECiPi B+wH6VocYFJeDztniUOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIxKJ-00Cdyo-1a; Mon, 10 Jul 2023 20:17:43 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIxKG-00Cdy4-33 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 20:17:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689020259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZfBCs08BCyvb4rUBf/lFUidTAq5uH0UA99R+iDtQ+Ug=; b=Pnya4dSf4foCvV4aRMLFzaJuoB8VBuNFZ9GeishVdwZBhinU4P8rvcFgfeJtugbP0vUBcJ /E+N6OTfatjTs3kKboUX2OmR+AwB5QMHWJIi/7xmRi2zWOKecQyXHn5ioTbUs7V7HvQL6j RAYVjNpNiRycYE/F2SaJKHLygEeSsBY= Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573-v1n1OvxsP4Gssxpx1VTWLQ-1; Mon, 10 Jul 2023 16:17:38 -0400 X-MC-Unique: v1n1OvxsP4Gssxpx1VTWLQ-1 Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-1b443821eefso3301459fac.3 for ; Mon, 10 Jul 2023 13:17:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689020258; x=1691612258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZfBCs08BCyvb4rUBf/lFUidTAq5uH0UA99R+iDtQ+Ug=; b=jRlGSbHXlETukd4wOf2hfZYDA19cB7cQI/w+fhoHJVcJjwxKRlF0cfd4T3SOX7CKcO akvsNbCMIXtiz+4wdt38iDVxO21GrEePSPnyTWoG1n8dPg27GUb8fHvnjjH+z0XBlOZU qnnTVjjTWGW3squkfemWAboEzwj7CCopKe56MK5Qwv6myijgayMuiaYwBGjgoKGoqNpV XBB6qN7jbzysifK5mcGGNbRHKAk48dtO2Y3D0M62XpZ/SjSv8865/MpeVW0ObvJTv2I5 hNwSH07kCfZi+kEUpUiMIoeY3+VTqBlwZA24sIQi7gnkEPlEuBDmMLH1aynC7HHGg2y2 hkCA== X-Gm-Message-State: ABy/qLZVgsMTCQ2imA4JN1NS/NKHN1qudAwgmhVfIfVjqaeWGIruIazA sMbzk5AAmP/npmS3qW4f2PWKgTW+FikWcxoJFEbqYRYWStWQALkIKzLjBsKy5iPvD5glGgR3gLQ DuAY+hECfF7pVUUa02i1EdEVWJtFP24sZygI= X-Received: by 2002:a05:6870:440b:b0:19f:9353:d9b0 with SMTP id u11-20020a056870440b00b0019f9353d9b0mr13312414oah.24.1689020258007; Mon, 10 Jul 2023 13:17:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlG/yzsbrle2mK4hDSP+ymIcBBFgugjNQj9A986L5d0AncrnW2gjIY3q9PjS07ExUBl/iRYYsw== X-Received: by 2002:a05:6870:440b:b0:19f:9353:d9b0 with SMTP id u11-20020a056870440b00b0019f9353d9b0mr13312403oah.24.1689020257748; Mon, 10 Jul 2023 13:17:37 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id j12-20020a81920c000000b0056d2a19ad91sm155097ywg.103.2023.07.10.13.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 13:17:37 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, mcoquelin.stm32@gmail.com, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, joabreu@synopsys.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, bhupesh.sharma@linaro.org, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, andrew@lunn.ch, simon.horman@corigine.com, Andrew Halaney Subject: [PATCH net-next v2 2/3] net: stmmac: dwmac-qcom-ethqos: Use dev_err_probe() Date: Mon, 10 Jul 2023 15:06:38 -0500 Message-ID: <20230710201636.200412-3-ahalaney@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710201636.200412-1-ahalaney@redhat.com> References: <20230710201636.200412-1-ahalaney@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_131741_059427_D6A76A2D X-CRM114-Status: GOOD ( 12.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using dev_err_probe() logs to devices_deferred which is helpful when debugging. Reviewed-by: Andrew Lunn Signed-off-by: Andrew Halaney --- Changes since v1: * Collect tags (Andrew Lunn) drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index ebafdadb28d5..1e103fd356b7 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -710,8 +710,8 @@ static int qcom_ethqos_probe(struct platform_device *pdev) plat_dat = devm_stmmac_probe_config_dt(pdev, stmmac_res.mac); if (IS_ERR(plat_dat)) { - dev_err(dev, "dt configuration failed\n"); - return PTR_ERR(plat_dat); + return dev_err_probe(dev, PTR_ERR(plat_dat), + "dt configuration failed\n"); } plat_dat->clks_config = ethqos_clks_config;