From patchwork Thu Jul 13 08:07:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 13311465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13054C001B0 for ; Thu, 13 Jul 2023 08:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=q2jJRk+WFez09+r9mVn2+ofisKiDivm039Cf4bj85kg=; b=tPVQFzvhlpLIGx FgRbeGFDcxXfXUYkR0WDq50ANZcvl+FuOEXYNhFRGUxcQERTQTpsocKMIRYGZFswFvtOsV5YNeAJa naBEBCKPzpUZmLGIavocG3WDi9ueQxbuJpL6d2y/FgNUfG7Q+X8SLzU0HKoc/KX8V36GzIY55o08O iHHNrCXU0IBiyluCii3Xjcf5kdVoXItPsvcZBTdbrzVfYiPYr55HozBeIqCntsZKE2AzCm4S0GQ1r 4DfTa9KqnMTJggLswa6uEk7+pg8YPqJXiFhRNg9B4HPxdu3AFxut1/k4Lx/+u8rA1gG4UatHsBJhJ i3tag0ckYW3uHpwpRIOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJrNW-002NB8-1N; Thu, 13 Jul 2023 08:08:46 +0000 Received: from mail-sgaapc01on20702.outbound.protection.outlook.com ([2a01:111:f400:feab::702] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJrNP-002N7v-3A for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 08:08:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZv7+kMjtN201aXRChf2u5May7uxLbzY+v/dJa03El7lGMpe+juujvGSxsr7D4mFBoWbyuGPVQhOqByMLFpjXUKyOWJHqMQkisxd/aaR0F7LY7qleTDQgipy2S2XZF5QiiCZ+V0TwZZy+B7Cw8Z22huIx97MIub6Ne+UYiuMOQ1tQHZs+T2qFFMd0fru+6RsQZ0wX5i/UUmSpde8xirJtOsIRvZ7bLWH2GWWPqTlYyjrv4fnwgpqnARNeZyFV7O675h5eEMWoEURYLm+IuSou8FZz+tGjFe1YqA7P+jOJZC6E6VhGdSr09gWu6cJ5ApwvF3na7zuKveD1mCZXXlUsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0x0hkJ7rBcNQc6MBaHii9c4fVow/2SAqZ/ObTvOr/Ks=; b=JuOUJzM98B63erEgVTmqpkt+alJYrgRJ4lr3I7+nkgR+hGuleB7ZW2HEoE+1wDMiOTdltCfBGeARpBIaGJXeFYRoDjvuq8B9oBEx9/gE9f1YIKQjZG+gcCqh4ZnSkKsfZqn+rKbaOL26adeI6JwTD0YOh2Qb0brwUpOTFMuTvS+e28zzJivzJe0Qj6QnDAy03ppT30OGC63/HxkpgzYNKObwP6JLcyd+1IcJ7aZazqoDvLyIzbulvg30nWlhIGCVrS3N7vqPwjICaiGjwrFyCRWmztuaKBngvmjA3+S/ca+yUAPvDttaChtgJS9/oy+cFLoss8jElWVySrTK5WDvnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0x0hkJ7rBcNQc6MBaHii9c4fVow/2SAqZ/ObTvOr/Ks=; b=W19GC5vf6MitdKMn0/oQ2UAeyHy8NHvlE4HHcP3b5KYUHUKIrt9sPx0j20gPTqM9knzX2ddonO6Z3ZW9oA90BdFQbzls40jQswWjPgb/2gdc8+OiS4Ap/oywHkG6xfSKV/ZVg+OJQ0hPJJTmTGlumanowQ1hLBbhQAZHTj9xuj3GVSI3r+k2esXEs498AP7Stnf4ej41y7NpK0V52Zi38Q6arjgLglrhvXygx0EBL1Q6uVwtR2tpFZBx9Hb84f0uxYXGYU4rMBZ4PCun7lBosdFQUsK6K8JNXsXSUeGauzjdyx6AaEUV27tbB4dEh3kPQETCL8htykoKL7xdzl+BHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4371.apcprd06.prod.outlook.com (2603:1096:820:74::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 08:08:22 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:08:21 +0000 From: Yangtao Li To: Ulf Hansson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 01/58] mmc: sunxi: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:10 +0800 Message-Id: <20230713080807.69999-1-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4371:EE_ X-MS-Office365-Filtering-Correlation-Id: db512120-bfe8-4c39-1183-08db83785293 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4UKwO+dP6G2m8w5g3hTGmJPt/aV3i33bHH0XyWvUwk4zTTNA7eOcf3V8XJYlRhFWWXyVgcxyYsiSmE9lwmCA2l3zgCUx2eTOdIk0sNpsiwDsMGOtNYDyCifcTieZuKxVcqrGxo6gv0lp8lwifw5yp/c71md8lw682CJg/7Xolvh6q19VySjmEv3Xt6nIFo0oaTYqB0fk+npsmdo40XKViB5E7l461rRUJXt91EFBUgEywCtIDiT8X4Nt7srUue0SxdrIkLUQirui+AeHEMol5xg8a1aJC22kYNbSpLBsKM9GfY9Af01mNdLDhB5EAcIYhpw8Mzmz4Vcv+499IIn/flipxNMPbkzGqorCNDq7hzENDCvj4tYVnUJZVZlpkfKyxeEXIugx20bh/9arc5Gkvc9hlyq6bQ2ueT+BVOPjnGw0GpXjP18jv5z7lDvr3f6IcFrfF7EOxvxmH+gLlWWHBYhabDsrxL0l8jUl3fyraszRm0mTvKOyjkbAw/HYl1u82KyqIju70iyg11/NQ1lXimdru1JwwiEAe+knPJSH6hiKy0AWbUQcfLcxfmhHmnPVnWUlg+xZ/DTuIQPJhUxkkshmggZ7H0Rc3emOonUrBsmoZOyFN6pYX6tAx532uyccGVz5rOsz6QXI+lrcxAfmLHrbqIIyYJy6hoPL2sVkwis= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199021)(38350700002)(38100700002)(478600001)(4326008)(6666004)(86362001)(52116002)(110136005)(6486002)(54906003)(66476007)(66556008)(66946007)(316002)(6512007)(41300700001)(83380400001)(186003)(2616005)(2906002)(36756003)(8936002)(8676002)(26005)(5660300002)(6506007)(1076003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Y9+2t2AnQPn6xyOvEK+a3FlqKKLL?= =?utf-8?q?OB/6QBqSnW/HJQdLy0aSQvkPmyO6qWLjB3CWYjJmXEjJYq5LrjFXpOUxqPLvJOrPE?= =?utf-8?q?5QpyDxjt1fRXm8VPEAc1X9RGj9AfdCPae5DijCu01J6Rz/IllkVWHOh7LM+IuX6as?= =?utf-8?q?lFxt+Lfegzu6vL5CX8rPtM6tGcQ1ndi3541hX79BdBrcUPGUJUVUllbC0YbJfw1KK?= =?utf-8?q?OyWOx1oHMwS6278DX7FELO5pCjNyIhdQAjS++8DRag7VTKuStsVf9wuFgxrktLOtX?= =?utf-8?q?6toqW+u1kF/w8fhE0ebHMlzoWkZNnrhiGH+kFnGfADd/0sBqXb087yAdFpb+GysS6?= =?utf-8?q?2EoLFfDJpmWWxM9h/eK2sGqc2gupU+98UphTQP67rsMbAV1a6CHhj4LO4H3jQzr2R?= =?utf-8?q?Wuz0Md8RwMUG4FIoyi3PlskD3zLm7aKblxTbwomQvsioEmIBP0P4KwU8CNKfI1PpY?= =?utf-8?q?RwMeoi2k/5t/PoUQflVjGzoPqp4frkp0Nmwi79v/ih4kMRiapxmd/YHqMq+5tjBj8?= =?utf-8?q?HPp+f/vv+Z9x/B31V8wLidND1qHnp9JsiUD+fCk4iGB+LpdIAGoo1drE9mWMP/t8t?= =?utf-8?q?Wt1sXxEiCRHgVfIxoEuBPecNjRvaZD/dOImRr5DFnUvKWDfo1tlC5Lb7g544EEhZs?= =?utf-8?q?wqwcnmRhlsjuo5KSKGn1Tm6WyxkHmcEz+tQP1BfeuEFnuYwEaTzLWe9aUIbeDRks3?= =?utf-8?q?DBnj4D7ciwts2zBrFAtJtbwXA7MsI+ct6xwPJ9ykX7UpilBq9pmkMeHPEZLI0H4ZF?= =?utf-8?q?Rg9GHAlvo8VB80gHjuaG2vHoKi2UBPPkZkAyfuVQvZREKZ9aHiCl4T9wVO1aDNgBb?= =?utf-8?q?onf6Awse43448KTKm3IwAoczW+nKLwQSKuJAkrPpQeaQduiMmewlBjn1oONKbdhBW?= =?utf-8?q?IJjKhleMNknERoJ0jDBuyrG7FtIWweRIyghE8KLjlOosNMsB6LPHlb63crv4/k3t6?= =?utf-8?q?H7phFfD2+9y81/au3KqWFxYYDEb0y9A5exrZu10WmUUjK9YXrKYUaT5WOqfkP+n/F?= =?utf-8?q?eoMthWms1NqvU8WldjnIJZlkegw3B7n6d5RccChjyL6+k+drkw/q+hKAbMYSWJrGf?= =?utf-8?q?fRcPd+mwryWE1cACFKJ8AaDaDGUO8bbfhPMZjCFgnIjeenyRQyLcd1SC5ve0hgw+M?= =?utf-8?q?ySzo1LdDKWgIvH2OMSRW4wysOetLcvoHBhVBx3itMX7ZR2m2fM6hsk/6pEjF7eAeC?= =?utf-8?q?nXGmKDxlhpXwKGQ1z4OK0oV71HN7aM0HTKQQ+cDy+r7KLeGKI2O9xcoDVCOMaj5MT?= =?utf-8?q?D2z7nhRc/kSP9TxUZgSjGJ2QGXtDsOERMUDlz4FRaqL2LnRHCm2EwQOXJT4GJcf7t?= =?utf-8?q?fpCjM9fQ0d2WJtCu3MHGeVWdMpI03JM7QzAuomvvOaeGyR1oelXHyNQ0DuCipu7wm?= =?utf-8?q?WWjFDUpYtCFe4yca666GpuaXCB08GwLseGa8VYoTooBnUOdr72O8FeqkZAPhtRdty?= =?utf-8?q?xE42dLtGT4qhVFs6QZRgSVMa5hzNLICTPgP52hFa5pd+FPfQv1OmgYQgnUcf3X492?= =?utf-8?q?aY9/53Jn5FZZ?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: db512120-bfe8-4c39-1183-08db83785293 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:08:20.9951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6mBtp1KRGiq1i2IlJzhT2uRt3+oEoXmS4z1okyAKNWGwtXeQIqOqX7n4j8aZeQmfJy5t3OOFE3Vf+eAtZMNIpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4371 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_010840_023742_A3161452 X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Jernej Skrabec --- drivers/mmc/host/sunxi-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c index 69dcb8805e05..d3bd0ac99ec4 100644 --- a/drivers/mmc/host/sunxi-mmc.c +++ b/drivers/mmc/host/sunxi-mmc.c @@ -1486,7 +1486,7 @@ static int sunxi_mmc_probe(struct platform_device *pdev) return ret; } -static int sunxi_mmc_remove(struct platform_device *pdev) +static void sunxi_mmc_remove(struct platform_device *pdev) { struct mmc_host *mmc = platform_get_drvdata(pdev); struct sunxi_mmc_host *host = mmc_priv(mmc); @@ -1499,8 +1499,6 @@ static int sunxi_mmc_remove(struct platform_device *pdev) } dma_free_coherent(&pdev->dev, PAGE_SIZE, host->sg_cpu, host->sg_dma); mmc_free_host(mmc); - - return 0; } #ifdef CONFIG_PM @@ -1556,7 +1554,7 @@ static struct platform_driver sunxi_mmc_driver = { .pm = &sunxi_mmc_pm_ops, }, .probe = sunxi_mmc_probe, - .remove = sunxi_mmc_remove, + .remove_new = sunxi_mmc_remove, }; module_platform_driver(sunxi_mmc_driver);