Message ID | 20230713080807.69999-48-frank.li@vivo.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8E41C001B0 for <linux-arm-kernel@archiver.kernel.org>; Thu, 13 Jul 2023 08:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k+ocDdyHfsa5jOx5NJM+ATDaPZueqOja/fIWK+FSuvc=; b=kkS/UyiPus/q0n HfiaqI7xYjyU7a7Or6D/48ef4VGENUxl6sY9yRpkH9ggdIN+GPs4Y8jlKrYGrAqpT83UT00qK99+m VCHdo5z/eWytAE3Z8lJmehXKAoPJacrIM30ijfo8gEulMGcDKXsixxnXcE6Nc0/PWEvyzeHflzNuN bKxxF15mWUEWlBsc27HrqVR0Ih+NTBLCGZKSmKSfvztaR81JqPKW5If2ktMsYSXdd19UKb8Qw8QpQ eJWPBo2XO6PJ3aS1VQsB6KLaGU8t04+YD1S/Uw2EKwszmV7UArau9jT1cdVtXNNSGAmRJ28KxIg4m lUQ7W5IVcBTpjRGFQiqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJrOy-002OAg-2j; Thu, 13 Jul 2023 08:10:16 +0000 Received: from mail-psaapc01on20703.outbound.protection.outlook.com ([2a01:111:f400:feae::703] helo=APC01-PSA-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJrOt-002O1V-1Y for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 08:10:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WiJzUt/r1HqE+HIGcnxkbGtA0ftUcGcWrRsYMgsnGl8Pfc9Pa/+IqXAK3/xJzJtFu6HIs+ILUibxHyuc50ESeZyY8XsK8xUvY9jiKx7OYslJyoaWWjR0vzoKsM2cj9xoq05WnfKSWFavZrzzlKIwKr26us57T3VKjI229RiKl2MgApO3Rl6bv3aBU9vhARmZOciFSpe20IyHLgqO689DCAZJe8YGQH00w36LjK+kJwOIHlvZ8dU8PCh+6+5bUbz+vm7FruFIySIknwSjsJ+OcVpFHjON2xU7YFo2wPlruwLuriAKE2w89NCLW92CP2x0TPbnoeiAQfu8SFGqyltpwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K1UBCsQ7z6bjOfCJhKMKvjOrHl91zL75OXa3zGFD5pw=; b=cgNRixQ3hqrr142mWck/6YcqfFjCxOJDHJZOczV3uOdnFd43jQXnfLlD1JVeOW49oLj3DUgIYIQT2YAk4ohSelnkDMF8bDVVDh9ILIfzHAUpMiXAdaUpVzwL6g2MXHAjbwBeDmKyhCVgi4BXg9yIxMUQLXH0wXVcL+EOg+hZCV06WDot5oo+DVoo48j5yjg6oqknn9WFx11THxdXuNxVcC0Z/DDlLqe4FeXgOUZkXUHeVS7yHHljcRS2n8Np+YI6qKU74E52ydua0/6KHjiJUcqCcvjqaV8kho4b0Cy0kRsi2xtNtmB2stbMKhVXVSD1+WTuuc5Kc6pQwwZw/UQbPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K1UBCsQ7z6bjOfCJhKMKvjOrHl91zL75OXa3zGFD5pw=; b=WKdIcpNfGhjdxj3Tnqw5dwYVLqlMq/SQJ0YJ21F0TmejP1OOPD2g+tJC+KmRLVqM6V/j5HdDOjdFy/1d0g+IvWr3/k1BhKL0g/5YUyvaWRO80+qY0rz/TD37QqN+XPftJeEI/rEwc/R7lQXuHI8kETD8Zgupr5Cea/H0LNGnfUhsYeUG59hY0GNxwTrsO9WmSYyFmsLFTaZCyS84z8TOLQ9/k1q2Ye3XZMRuuNbcRbVoZXgnTI2tZGfX/8AV47rdch86H0iIy7Ov3i03+KV9GWZJj4XCk74ro7hhpPtRPmouFh8qHOjvRkgYOE7S64X3RBkKOCSFEUFLeCYCT9bCGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PUZPR06MB5984.apcprd06.prod.outlook.com (2603:1096:301:118::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 08:10:01 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:10:01 +0000 From: Yangtao Li <frank.li@vivo.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Yangtao Li <frank.li@vivo.com>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 48/58] mmc: wmt-sdmmc: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:57 +0800 Message-Id: <20230713080807.69999-48-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PUZPR06MB5984:EE_ X-MS-Office365-Filtering-Correlation-Id: a6190350-d205-4c88-c375-08db83788541 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k9Nu7LrpaNN1Wxq5GYKW2hAYSIjgTxmSeJQCXMVu1KYrjE8/1BldY2Mrw2vwKV7ne6xQx8OyqaYg/EgSDf6JWk86okYhHnPsddO/RxYVTYaVrh1E3orJy4i7c4YgABPgPVL7An+AvRJaiXbKbSkcnpMB4g5umK43VDoPF/EdPXlvwW9x68uNPcWwvgV+Uejy/7N+jSXbeIVx2feSQ4PuxNBWr2+uVdiyVB0jiATxvZBWYu2rL5MdkGGbKQvW5oCR5XhEdTTO9WyE8d+Kb133NiNHL4Zyj74JZ3ziEX7vYVqfsMNnMpSb15rIHHFNnEQ6HJfbgkuhjld/KQs0EAJpf+RWng1YTxjSMER42qsO5EAaemYQM1IGlDHOk2EfpfnzFgk7tj2A59FZB/S5tT8Z7pRYrrTBeng+pIOo5slQA7EOrhib92YUP+dhOX+ExPeQtOnF+RUxqrh/92+V2nHkFQzteFdqvTfsz94zKW6MuwqCILx4UzoT3t74bFL/vEp6h4pHemetu+6eFy+tSz/8nmMk0Twj2SUfkx+psnvjok22tyfGb6h6oJgsevGKDGXWk0oa07cdpnGMFs5RC+q9tx2XQuRebZQRKQoPb/87jaMVtIqMNOiCTFyRSdBFMLGr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(451199021)(478600001)(6666004)(54906003)(52116002)(66476007)(66946007)(66556008)(6486002)(6916009)(4326008)(316002)(41300700001)(2616005)(186003)(2906002)(8936002)(8676002)(38100700002)(6506007)(1076003)(36756003)(26005)(5660300002)(6512007)(86362001)(38350700002)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6Kf8Hx67PKHDRZw1zoQ/HYaQDqHu?= =?utf-8?q?zbZMJ1t0ociY5AdkTVs4kHDOFxvkDDynyZk15rUnFABinSelKDk+FNOaQKurlEwhS?= =?utf-8?q?M7BaV5Y+XiJOYUT1yPRkG2tgfZaTuTd0qUMW/vb6RnUHukB96SdlzTOyxRvK0s7s4?= =?utf-8?q?FD8VsWLagBYsWlkgVdmEp91FfRlsMpjUw65KSzAfP6BO5js/O/eyMLSSdhZbpVV3c?= =?utf-8?q?IYXeIiek9SkmnOCZC5chFsUYjQK9caFcSYsPP74ODAW4Stp83mN+C1XVCyP8bCbL2?= =?utf-8?q?p312ABSLBYGPg3ZslOKQm24GxBlDges++1zL50DuilUm7ytkSCIkNoifiumZtdJwJ?= =?utf-8?q?sui6PE9QxpbwDcerH3snTdSQeS71LNjcI79qPw7Ho8AisrI0zCC/GKdDY3y29eTad?= =?utf-8?q?QrwaLCHtKUWW39DEbEtyvwZBpNEBHVqSXjeP5jxSZ+QPrPgzmE1a9AudUF5fvzbhr?= =?utf-8?q?h+zShbf5OZhZ1JBkOhku64Mxc+mmAntWUVgnE2inWEs1vI0S0RuDxAWwRFzoNpW8G?= =?utf-8?q?CswkDEXtfTbQqy86KQjeDa3HAWbj6lsdm5J2V6aftyjd6pnWZqttsXwRSB3BwTf1Q?= =?utf-8?q?QD2wujQeVkIe21rB18vZzkHDLzJbzwARtBdFbKJdxH5/6Y0p3/QLHAYBJPUEopXPJ?= =?utf-8?q?AhuRzWwfyQyr6vyVysKjxMCWR7pDVtAZo0bMlZPg1pA1X3tQTYRGFM7vpTk0zriZb?= =?utf-8?q?Fa59DKoJfIktGZU+dxGkkKnQIp02iB4Mg9/KOSYMmR2hzVn1TZ2e+644ojoV+Z0/X?= =?utf-8?q?Ts1mQxTBmR9dlyLr9JkuemuNEQLd/PBN0Hz487Y/GJXlMIe60eMsWVxp3alUMmrpA?= =?utf-8?q?v/zYDxNJ5p0PjgqlQHNlXbVI7K592557u86PCb8gq/aeXqvRUGw9OXUZdgeouMkCP?= =?utf-8?q?u37a2cbz9SmFTn2Chs9mtVa9aOQXbGLOGe6f8yWfiiV8gE07UcAKVGBi3NyCYYN8T?= =?utf-8?q?TCfdV5ksuhEs38kuMdDC1i7P/ijUZVoWJBOn4SY91cx4QPEnCYdst2avoQP75nQhB?= =?utf-8?q?iwd0qWr7pvN+6FR4wEoEDcdN0BZmIAbpWLMvf4PNQmoZ+Sg/kpvik8c2svSx8IHx1?= =?utf-8?q?6QNgr/N1eRVBr5B4DBDk6dmBRu9eo58Iz0cX8naZmoOp7O/vHpEe18OBmwc2Cw3Gf?= =?utf-8?q?MM4izCyW80CA5PT9w4oCo2vQPdsoQqPO1UNuSnM5roYTNpyZ+hgYk6LTxD75k+wc/?= =?utf-8?q?RBQv2MTbWik9yqV9BKRDsXyJ2QGzTtJEo0oofGwEOnNgCWC3wFcAR79QtO8ZEu3Kx?= =?utf-8?q?vWZBao6JyGqeNYUnIb+/nMQstdLfoxvRIf2RCxUT4kzf8+drU0u8GTHBel80Tr/ON?= =?utf-8?q?1QKtB3x5y2OTrrLsCiYr0Z2SSTad2I9EIrOuG6dbv/Jmj5MH00gF7kBxIOcnnxkSc?= =?utf-8?q?g4I/aPZppqmErATtpbxSUWmrGmxE5axZ6AcUQBiUVMAsPCNt6leNQtmD5iZz8E11J?= =?utf-8?q?Thbi1OMesLreAmEku92oECBQZcwQpgjswaHiyJBeLJBYmwWteNKQ7ZLlOzioa34e4?= =?utf-8?q?X2khu8p15Lf2?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6190350-d205-4c88-c375-08db83788541 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:09:45.9649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t8c2JydYd8+5owYGLYvLtWJG7yYyjfN3UVenSEXpgzLDHKENNHJL8kBxFydd8w3x/WDRI4igOU+srwaqGFMW7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5984 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_011011_529973_B3649E62 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
[01/58] mmc: sunxi: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 68525d900046..74c475d071b7 100644 --- a/drivers/mmc/host/wmt-sdmmc.c +++ b/drivers/mmc/host/wmt-sdmmc.c @@ -880,7 +880,7 @@ static int wmt_mci_probe(struct platform_device *pdev) return ret; } -static int wmt_mci_remove(struct platform_device *pdev) +static void wmt_mci_remove(struct platform_device *pdev) { struct mmc_host *mmc; struct wmt_mci_priv *priv; @@ -918,8 +918,6 @@ static int wmt_mci_remove(struct platform_device *pdev) mmc_free_host(mmc); dev_info(&pdev->dev, "WMT MCI device removed\n"); - - return 0; } #ifdef CONFIG_PM @@ -989,7 +987,7 @@ static const struct dev_pm_ops wmt_mci_pm = { static struct platform_driver wmt_mci_driver = { .probe = wmt_mci_probe, - .remove = wmt_mci_remove, + .remove_new = wmt_mci_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/mmc/host/wmt-sdmmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)