Message ID | 20230713103224.2623717-1-xu.yang_2@nxp.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E55C5EB64DD for <linux-arm-kernel@archiver.kernel.org>; Thu, 13 Jul 2023 10:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lMt11yNedm0PjZipKTCea8W/bb6pUBekFrvvqcvORbI=; b=xi/AbyygeDZsjM S0/g9hXNBg85a2bm3lXH+yCbL3bWycY5wSWEHtVHa2VB5ZpZ0RftqVoJucPP63mPV2F7nDn+AlYWI I7S8Pb8GRexJt16hIm9675UgNGGwc4v+/pG9SzgFAARqda4XPvmhfMrB3fP+S94z+f3MCqgCPHqJP S1xLmbGf8cTbCAo89LhHBGXBOvfZlD23DLEqrpk3lROBYm7lpHr3v9C2e0Iw3UylqGjRr5M4qcSHx +n3j56QypE7AkqrpQDzb6e+2hV4C3pnV/QD1laDpfnIu3MffcXhqqAbe2DEt4/gUIhv0EWy2LmJOc tMOE1g9b6QdzOEmKZE0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJtZ6-002ocz-32; Thu, 13 Jul 2023 10:28:52 +0000 Received: from mail-vi1eur02on2061b.outbound.protection.outlook.com ([2a01:111:f400:fe16::61b] helo=EUR02-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJtZ4-002oZh-2r for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 10:28:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dqQiOX9TU2BwOm2vCLL6juFX8igVsdGdCJtIFhCrxI982/+3QisK5cHGYCOvyr1oLJp7mMxL9tLovqs+9YC9Ms44tV2rTuDkLTMJBWBChBhnRHdsAV+sMpB71r/t9uReHeMyMCTjHeVysUZ3xBMWjev2hWA27uaofsWUhfzM0pzs+bLAvA33w7E5cTtcOocrr6PMKPTmvseAVR5gUzlleHZGXcFu38Syik9wxiEIgSsJ14Gj4cZS7eHcJEHKslm/D4Ac1ANKvBlFWc59He/xJvFtffYvb+nTfvUZC6XROSXsCwWNwVA3raPlLM4Ghpl435Kf3lLNnabIgo1msjSNaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4938jlDxil8WRWnpxNgepeIYa7Q2q/rq7i047J6JdGA=; b=R7IV0AOflinHQSpEqvREnPaoQEmYgtKCRtPt+tWN+zMaQFeYp2vXhel+miaZBMN/S1d+10PpRh0dNTcdx25KmT8xQYs3ZYuswhKSEXVRlD+z2lVvVbDgBk+UD58JfplTF4ZNQTF2ugEPV4dVIb5YpHcVvNt1hf2cZ1XjcEE5DMuCeX5aU/1kcOmI4G/trAH5w4k2Wdd+/6+olLjDNQi50TlgFnA327NoTN3LQvXfvNi7wiqRq7GxjhkuJHAXY0Vm0mUVgvRp3cmgak7sDl9gWAwjOgs/2MvkIKLJPt10gEnAIt9yHjx+w0anXmHTYJ6lutOTkZ/d96LQhT1GP7QWhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4938jlDxil8WRWnpxNgepeIYa7Q2q/rq7i047J6JdGA=; b=bidYuIXBG9vrjzXVeiH12csX1izyrL3VhYOooWqSgajnPhTbg+rZhHBQM3sMkUOnxRq0Vzqsae74QLDHGGborUGl4cJAACjSYuf/0USkUStT7FVSJsSbQmnngtUHP1NvLNzJxHkTE4ssffj/jTGT4fC/W/+M9DimkrsGeDryzH4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB7PR04MB4505.eurprd04.prod.outlook.com (2603:10a6:5:39::26) by AM7PR04MB6775.eurprd04.prod.outlook.com (2603:10a6:20b:102::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Thu, 13 Jul 2023 10:28:43 +0000 Received: from DB7PR04MB4505.eurprd04.prod.outlook.com ([fe80::f9b0:8c34:e57:92a4]) by DB7PR04MB4505.eurprd04.prod.outlook.com ([fe80::f9b0:8c34:e57:92a4%7]) with mapi id 15.20.6588.017; Thu, 13 Jul 2023 10:28:42 +0000 From: Xu Yang <xu.yang_2@nxp.com> To: frank.li@nxp.com Cc: will@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] perf/imx_ddr: speed up overflow frequency of cycle counter Date: Thu, 13 Jul 2023 18:32:22 +0800 Message-Id: <20230713103224.2623717-1-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI2P153CA0031.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::7) To DB7PR04MB4505.eurprd04.prod.outlook.com (2603:10a6:5:39::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR04MB4505:EE_|AM7PR04MB6775:EE_ X-MS-Office365-Filtering-Correlation-Id: c65dfc06-f359-44a1-b16a-08db838bedf5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YtY2kTiiz1cJ8bNmtkdd3SxrcKLbFuk2JrnY0FxJOSWjs+Od+4tPuIv1ziMi8yp7tY9yEIVtttVqTy6UVlyR8IJxHR15X3U6TRT7Q2BgBQO6zXYcr7n+pbqislFg0vn4oLFZ+d63XVt1Isxv6TJt7dtfK8ponqKEV4zupz5vJwG4f/foSjzyIL/c+w3HhxSkULKhQwcQBj4c04weLAKQRQh2PjfPz9mTGhLBXKguyoROO9SH+1ZC0rkfzLaTxhGgFSfRnt7wW8GCCd+ZuqPnzT8bk3fkojz/R7KVXS1nI/SNUU8S7/hGqpl5M8MBx6yG/L+g/nHuIx/pQRjgdZHjfM22m84H1YH8VNA6MRrz8WtlUaM2SB5srTX5C9AcAssL/7L4oxGeIRQVOe+x6yWwN7E62xZzDGlG9kOCBBGcvWDUIIAuE3rY8tBMoFezwOAmecOlwZorEDBM9zJuCMFiUhvqRjYVekcBuLwx12uvpjsZ79i2crRO/indaRRFlBLRDwk3lQead9AWy2Sp9MiKQ94DRuVRTbMzlIWY2BN+uJ3qvgbBBoekR9Bk0PB8W5guLdNpuGRZpyBkr0ZMzKJXsqmo9OqnBNWp4zOiv1ZPw6tYzqf8rn3Ylu5fdUmTMH80 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR04MB4505.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(396003)(366004)(376002)(39860400002)(451199021)(6486002)(4326008)(66476007)(6636002)(66946007)(66556008)(37006003)(478600001)(1076003)(26005)(6506007)(52116002)(6666004)(38100700002)(38350700002)(316002)(41300700001)(6512007)(8676002)(8936002)(34206002)(86362001)(83380400001)(5660300002)(186003)(2616005)(2906002)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bhypWfXsGweXJqHEVGhc5SK7wyJeMLd1Z2QazjBwqKIrmUrDPFDDHzXL7bIIAoQXCjfODf5iSfggMDNLshWvd1MEte2CT0M0XBGkMeeMwkiLwbR1J3IH5iP/Ss1nVyltmJQrF9lrRNEoRtfWuEEwnwLRcPPHKL306hVm8Imd4UJBavKCzec/xsbmMlpwwC8zOj1+hqG/zv4Wk2LVOkvT7eO6k2w5Q7dJs5YO3QmI6Kg6QpU8Dmlq2WEuMXsgtlsxUJPIw2Mtfg3j6HlTR1WNMDRrk283L7kRLDpFaDIA1xZDqGfKzeOogZVCCsEwdO5KSylV7hXbuaJlPp2kyi/B+Q0Cg8nInZ5J23nlYTGcqB9ezxIrW1Ai6GAtmCCE+mcREM2Zr9bftTwuB4Mg6uIDLUX0a3tVxze7Wl4+2Y8emow5vPXtBR52GQWvhHmkB6qzQz3gREd7KqNBM5ncBA90CV3gdwBhXckI8NTMDz6ojaSGJmVo1ItrnJpR+92IIBSZkWyNZLaHilAAFlnTqJFhOpWwE2/+RZNkTURgasgEVWNjwMRy6I2X+Fp9O6Iek5zpofLAmnhhusXyPXjKfAD2eFhVcDmzTu0eZMRDX/JasahQqso1VhIOp08QY/mOmD0jwMRZH+YAWI/Edhvqg4lZpGM+K3bhV8f0IvJb+5rutjy4zxWITs3UoAqCby6blGuaC+paWcBsUSeL4FiSUMXl+wSEA8sBR4Rb2CbNSaLbJ6PQ5V/xZTEtLUOtg8h1PD0cD0z/dmCTcnPNvO8pRVmNBUg23o/FYHSYE+rP13q3/iTxWXsdE2n75U2b6CEYTw7GtjhhyNccBye5JIqaOvcA8lW6/Q/+ufYcJDdwHWM+5w/pJlF7l9HwB3J+3/yL9x3YeNsupDS1a5+M5Ga5iGa+9TxyQzlxsGHL2C1xRuQRnZb3MNVEHIrJCBtInpd1jpaEoOLZl99oWyyDtpezYxaUoywz2gXO8B+XZx8oYZjxRJ2/qM2dRrYqkxXpOH4slg63Q0CWz6Bw5H3ZPXLE+J0u2DMHXp3vV/Ek9reauQNpc03tbTxesHA0YgLqbyea1Grz7OqoHnaLzion3qDLa9bOLI/FBEb3zDSJCAOKNjeoA7/2tP65wKENwMd4iBezrc5siVhKp2GjHt4XZzbYiQdGdWI9Yz8SRQAdRXYflE6kPGIe/Ac2lKq9mwDJULvtRVsyuE2jDnMV9Spf6EWciW7Qy4YlhLbfVdWNDXPAkAXs9PHRm3YpUXzzUFemkC1mce9g9h49vPskOM6gcg9O4kY/2AS30k6+YkKe3/FIh1GlOt3PVxfc6UqesUwo+GiPaPWTMfbWhUwc5jkfcUChl4rBqU91c6Xxc6NOeIhzMc5/yFvIeHRsK5nwEYog+eqjhDcXnCXtQC2IYMi+zgwCymOpOD7E/WuF9p47aQORNES+N7h5jN1/tLP3HmIJyA+PkmGyTK6cKK73V0PO9wOOD4FTjXqd52HMMwhDLBVFA4dYuXAS94kM1OAlY3XsFP4mC9SvKKD+gBi4ZIqBnRfM5MxCWB3YyAv9/qEhW5sGfcXYyQ8bMuJP8gXRuIM38BuO01Dp X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c65dfc06-f359-44a1-b16a-08db838bedf5 X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB4505.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 10:28:42.0930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MNyJlFbhNHY29Rv0AFm/V3w5NbqxVPV645nDsdtHW+sv9TT6sNZzXDluxYhCdANyPXabEGGTLrlwezH3p7cHDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6775 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_032851_012590_B0EA1E48 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
[1/3] perf/imx_ddr: speed up overflow frequency of cycle counter
|
expand
|
diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c index 5222ba1e79d0..039069756bbc 100644 --- a/drivers/perf/fsl_imx8_ddr_perf.c +++ b/drivers/perf/fsl_imx8_ddr_perf.c @@ -28,6 +28,8 @@ #define CNTL_CLEAR_MASK 0xFFFFFFFD #define CNTL_OVER_MASK 0xFFFFFFFE +#define CNTL_CP_SHIFT 16 +#define CNTL_CP_MASK (0xFF << CNTL_CP_SHIFT) #define CNTL_CSV_SHIFT 24 #define CNTL_CSV_MASK (0xFFU << CNTL_CSV_SHIFT) @@ -427,6 +429,19 @@ static void ddr_perf_counter_enable(struct ddr_pmu *pmu, int config, writel(0, pmu->base + reg); val = CNTL_EN | CNTL_CLEAR; val |= FIELD_PREP(CNTL_CSV_MASK, config); + + /* + * Workaround for i.MX8MP: + * Common counters and byte counters share the same COUNTER_CNTL, + * and byte counters could overflow before cycle counter. Need set + * counter parameter(CP) of cycle counter to give it initial value + * which can speed up cycle counter overflow frequency. + */ + if (pmu->devtype_data->quirks & DDR_CAP_AXI_ID_FILTER_ENHANCED) { + if (counter == EVENT_CYCLES_COUNTER) + val |= FIELD_PREP(CNTL_CP_MASK, 0xf0); + } + writel(val, pmu->base + reg); } else { /* Disable counter */
For i.MX8MP, we cannot ensure that cycle counter overflow occurs at least 4 times as often as other events. Due to byte counters will count for any event configured, it will overflow more often. And if byte counters overflow that related counters would stop since they share the COUNTER_CNTL We can speed up cycle counter overflow frequency by setting counter parameter (CP) field of cycle counter. In this way, we can avoid stop counting byte counters when interrupt didn't come and the byte counters can be fetched or updated from each cycle counter overflow interrupt. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Changes in v2: - improve if condition --- drivers/perf/fsl_imx8_ddr_perf.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)