From patchwork Thu Jul 13 10:37:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 13311780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5354FC001DC for ; Thu, 13 Jul 2023 10:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lMt11yNedm0PjZipKTCea8W/bb6pUBekFrvvqcvORbI=; b=SMGD7mylAqzqE9 bBs8lVevZvlKt3cSnhuVrD3gAQrm+hhKeWlfucrVYVD7TBMyDyDuOS/P7uge3SsZzn6T4nfZJVJTy 8SbpMpFU0LzLYS2OQjiPCQnIBltWgR+h5cGePEQvLDKL0gQRMDKw3rjgskeTJpo6aGDzKqGybTX87 qhLyjyx7eOMty5fJqul1KUO7mF7eevylqJJhHC3dR+1EeBYCeY7Qaal6EZmGDQRWKwQSRjYPXMGvB i5LNV6yXHsiDqCnWr42ETygXoEtZVso9eP1i7nSEfFHk6tLU3HSfiyuATZBJr83aZnTDxUMbYDeqr jQjhP+T4akcgzVqSLKvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJteY-002rzT-0l; Thu, 13 Jul 2023 10:34:30 +0000 Received: from mail-db3eur04on0612.outbound.protection.outlook.com ([2a01:111:f400:fe0c::612] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJteV-002rvb-13 for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 10:34:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S2WG9RS4JGwZXXv4XnWp+szbTuj5VqeyAcKqY/1cjR3Q6qNvicUdsdosdUKBTetjNMfpIEKIHc8Uvs2jTxRAh8uSnQwDqqre+3rWJEDR5lnZYrwSILpZkRHmcPdmb6j4/dps9rYDqHDLYsbEFSKwCF/VqXxNbaakmF/BKfa30W39eB2dX9yU4ayC0Plrj0r7Tb05Kh8aG05H6n5GLm3nHITv7r9Fb1Vubhu0aB6RVqLXv2Yg43v3J6vUQbKCUDIr4BfGeViYPpZjEZrNy7hqlke/NHgrS0Nf9xQKOpnr1v9pDyKEiX/GK397+GP+LPzZVi0awh8v19FXID+KCHICNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4938jlDxil8WRWnpxNgepeIYa7Q2q/rq7i047J6JdGA=; b=mBUWuhwQkizI7aSubhFydCSnEt9Ow03iPe17VsBXrwbW0RoQqjjFkPaIXDFhrxcBahfK8o1C/NXcvcyJaXQsijC4KKAOMVo5AOXRrF+chBlXyupIyfv7PEiOs+HKylFN5nwl/xfke0A+Mek7FpaOIt78jXmou/MvrFS7dfo3zU10r8yzsa8wnY4Fb6zZXMo6qnnP2aHbE+Nkmmt/YvZMBK7YR7xbtbe02IUcRqtiEqNXhyQKu0DTqAG1kLj3EadzENSPNnvgx7NryrwKCUlZlwkxaZvEvD7H9FXjs3ZYb6UBeUQuREwGESMPrtluH2XIA7fLlO6076W2+wpJtU+mtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4938jlDxil8WRWnpxNgepeIYa7Q2q/rq7i047J6JdGA=; b=mZ9t6A8pbO0/K3pUkHTAE2iksxIyld59M/x0kAitauvdK4X1YNdKrYrgBwCnYYCp4xBTJ2uBJSJdcEOzCSHFAvdR4XyiXW9aqflunkaLed0dOH7254vzGdlL8omYYmnedLVE/g/RdpDyH6WfgXwtSoFcncZZJYbJvXc6jjzlKt8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB7PR04MB4505.eurprd04.prod.outlook.com (2603:10a6:5:39::26) by PA4PR04MB7968.eurprd04.prod.outlook.com (2603:10a6:102:c0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 10:34:19 +0000 Received: from DB7PR04MB4505.eurprd04.prod.outlook.com ([fe80::f9b0:8c34:e57:92a4]) by DB7PR04MB4505.eurprd04.prod.outlook.com ([fe80::f9b0:8c34:e57:92a4%7]) with mapi id 15.20.6588.017; Thu, 13 Jul 2023 10:34:19 +0000 From: Xu Yang To: frank.li@nxp.com Cc: will@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/3] perf/imx_ddr: speed up overflow frequency of cycle counter Date: Thu, 13 Jul 2023 18:37:56 +0800 Message-Id: <20230713103758.2627269-1-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI2PR02CA0015.apcprd02.prod.outlook.com (2603:1096:4:194::16) To DB7PR04MB4505.eurprd04.prod.outlook.com (2603:10a6:5:39::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR04MB4505:EE_|PA4PR04MB7968:EE_ X-MS-Office365-Filtering-Correlation-Id: c99a5291-19ad-4780-08fa-08db838cb70e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IgoCZommsmYF9e+mGcUZw/8ZGp4Re5N1FK9TEN0s7UBqJVOfjRjm3SZhoMXYydOVVbp5QG+kuT5JU5aKiiyC5/rz3iNVns+2cWuWYZx0Y4qskayok6qtMsNW3waco5VfrkG0BehsJJ3mm1VYCSDN3afbUKDjUcWsX61bHeaB2Q/c9WEKp/diqfarTw1otcMJcsZDnxfbyqya2lnkATmXQ3naokrA+yh4oDTxhLfAm65/9/IOP1461kCZFJFEXLgHyNlpWpmH3J/2Zj2WUqGg8AJjAgeTBvyGO3GbJtxyO0olgidLts0yJmf9bnCFBgMzh2kz3ptzu5rD2CVpMkJetE+PGKk6RpOrQqHxMd5T7b1zH4jXnqsYONOedBD5ci8UD6Nz/g2t+EYFL+5YA1a0SSfNBVp8oS7HYNpr5E1p8oSzAmn5jRpHuocrKUrfI2zx45MBNwh0AJsnodg2dM81m1rcZiRPt/vraFM1+7vsglPAlVAYA0NVdWbA27fWkUF/GAYur/lfpYIrV+TV9jaOC4eCWd+e8qYToq4KHKgrcKvX8RY+q+0MDSqvXJDzWOcBIY0AnWVPw1JKpfbIYRVG9Aaz6q/Msujlr7nVuUHEAelvJ+9bXtfc1bRB1gSCs9uf X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR04MB4505.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(136003)(39860400002)(376002)(451199021)(6512007)(4326008)(1076003)(26005)(6506007)(36756003)(37006003)(38350700002)(38100700002)(8676002)(5660300002)(8936002)(86362001)(41300700001)(316002)(66476007)(2906002)(34206002)(66556008)(6636002)(66946007)(6486002)(52116002)(6666004)(478600001)(83380400001)(2616005)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HgIldveYSvpWPktEXl+SLe9uCT7cjNyOjknA4umzt+gvWyZ94wf4/Rso/GVpVv/17u4ifqX9JjgAjop9/UO+BHjPAFK3YppjM83UFLtSrQ9Tsu2eiHoEH8fiCVeMTw/YtymgH1l7gG6U8BBUpWbqBenaNdRxWxs4qiZgdLtlvkIr2kRGcomrJIjVxFGRfotDpNfZVUua3M2pvXUYPjkLDEXQCrpUt/S9yEiAjNapOL4hkuuLvIa0LArDD2UC6yLvwAyLq8NOjBoMuXEE2OeK0KjT5empffWWyAhciSy7CnO/DXjcEXvBD6sBYe+8tFDwp17+AIqphpXKWmlvHJ4CjPm+j/nG43Nn/JhmZT4CBlg8ysG8ETDy6QdZLZ7PNV+r5exLtIyIABjR1A8ZO42KdJL4qAd+BB+9JBjt2KyaJ/4qulpbPeOf693frflnU1miPBSm9Ue/Idif3cR2QeyBEZuGqSmxdYfI1QhA6ShseQxIOuWBmFRH6nOgR3e0cUPalMiNagG+99f0chJK1r+3RQP24irnTdtkPtoUouA4WbFb54pHwkOQtNS2jo7QZsm/miVHC1SQJ6OKZJaL0Y5+tDDIneleLaZELVcG+nEEpfgszJ/U6IM6UxkizPONJxfE5vYPNZcJyRI7ia0DUAkHy/d6wrg2YqjXObj+XZu742+GdH8RI+G9ZdG0ZIJGcXHBYm5CF+GxSR+EOY4P34O/S9DT7ExYR95z6xvdJRD8IZUCN6Z6/1NfX9WWS7rUsR7fkHUqJcN6qUblbAZWmaKtMSc2nhy3t8YxSuvUxAn0pxjoc2fYlTbud9TYMnQBbU+eZJb37KvxhjkGzk0HKmYURy//tCHtBKPnOnhrgh2Kkath/kH/wRgR6fWivnnngnMHnoomhakJI2METBcA6FF15jZKQcbyXYL5h66PpFH0iMKczX6qNRzvkQwDoXU8g4oAwyx0cGbHgqUAnodEavKkjZXT5ZBsvuzVigL3BnCzTAIi+zfwbcUiuoT8uEkFSmEU428XghkMZMapfUvzlUCPp1lDsnbdrLHVd7GhJylrnYhgiUW/xtorjvTvOn3EImKOuah6DZ3cAkLIq3mkpbYlwO14eQWz4E5YzDDa6xoYB28sBuIP1cvs8pK0Lo8AkJfHm/ZRT9kIyfcqvKJTum14+5LcRlOuc/ZY0yBzVX6nuve164UNPhoipjxwaYS6GHRpLrtgGdgzWs9jJ6zyggP4dWta5xVawTcQ/2w9EdWZozTfHmhyJ3IVEEdUTr0DW3BeKhwvt0GLWVaxH/Sk84rgvzEdN9gLX7P0y5XRTmWfhta3SxMY7mcLEjnLeHPqZSpV3YJml1gaGkzhXV0j0hKvDDCneH9ddZ7rCVLlU6NHpT0tDPe+IFR/r7IdaTnIu96zO4lrzX7FJQDmOWQwKPIfQkbw4NWPch8saxFFK9GP2w0YSM2Y+3myyMOcnXPPPsX2Ud06iJ5Yzi4X9Xx0FIasVH3lMMBxRzfP2B3i3j2SUVuukNICGDLJe3Dchlyt29h2jqUDhggg+AJNgNcG5I1GpfA8VFUMlAiJCJvkknZOaUztTylw3Oaco9C/L9JNG0UQ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c99a5291-19ad-4780-08fa-08db838cb70e X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB4505.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 10:34:19.4435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aIgP+pGenprThIErvHkw+rahZsLjQ+CJ65aUcRBQgVaOqZYC6OX3le4lBRsUoAUyo5rykzhV4B5O1/5sr5o6IQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7968 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_033427_390651_3BC27B93 X-CRM114-Status: GOOD ( 11.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org For i.MX8MP, we cannot ensure that cycle counter overflow occurs at least 4 times as often as other events. Due to byte counters will count for any event configured, it will overflow more often. And if byte counters overflow that related counters would stop since they share the COUNTER_CNTL We can speed up cycle counter overflow frequency by setting counter parameter (CP) field of cycle counter. In this way, we can avoid stop counting byte counters when interrupt didn't come and the byte counters can be fetched or updated from each cycle counter overflow interrupt. Signed-off-by: Xu Yang --- Changes in v2: - improve if condition --- drivers/perf/fsl_imx8_ddr_perf.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c index 5222ba1e79d0..039069756bbc 100644 --- a/drivers/perf/fsl_imx8_ddr_perf.c +++ b/drivers/perf/fsl_imx8_ddr_perf.c @@ -28,6 +28,8 @@ #define CNTL_CLEAR_MASK 0xFFFFFFFD #define CNTL_OVER_MASK 0xFFFFFFFE +#define CNTL_CP_SHIFT 16 +#define CNTL_CP_MASK (0xFF << CNTL_CP_SHIFT) #define CNTL_CSV_SHIFT 24 #define CNTL_CSV_MASK (0xFFU << CNTL_CSV_SHIFT) @@ -427,6 +429,19 @@ static void ddr_perf_counter_enable(struct ddr_pmu *pmu, int config, writel(0, pmu->base + reg); val = CNTL_EN | CNTL_CLEAR; val |= FIELD_PREP(CNTL_CSV_MASK, config); + + /* + * Workaround for i.MX8MP: + * Common counters and byte counters share the same COUNTER_CNTL, + * and byte counters could overflow before cycle counter. Need set + * counter parameter(CP) of cycle counter to give it initial value + * which can speed up cycle counter overflow frequency. + */ + if (pmu->devtype_data->quirks & DDR_CAP_AXI_ID_FILTER_ENHANCED) { + if (counter == EVENT_CYCLES_COUNTER) + val |= FIELD_PREP(CNTL_CP_MASK, 0xf0); + } + writel(val, pmu->base + reg); } else { /* Disable counter */