Message ID | 20230719041339.3437-1-machel@vivo.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C2E0C001DC for <linux-arm-kernel@archiver.kernel.org>; Wed, 19 Jul 2023 06:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7MFlRydo1qP3nclZusH9W3gM5EJEIwNPV6y/mMXUw6o=; b=azjusYRVO69WFk ZYQEbYSj0bDb3ax8bz2Hq5fEUFEbH6bFZrgzSoNf2GkDtEH/G5yyhMJcM2AiDTJvpxfCvBLOaSXWD 8GYxtA8ypnwRLSdKi6p031uBDG1mysO9vZyJAxJzXwQzfmlUeX4GI3jrRmRKZE5yKuEryrkCJwMNM 6bIPw/9ebCtdWd4haeiz2NCVvWGbrRIF++HLQRAaaGoLqdPWlMHNrnVa5B/9BlwMq4/y61T2+rpc0 Gh9Ra98OmTlYvRI5nW5/K/KR7E1dVBiPEz2JjvVo5Y2OmEOs0ZL1qewMlQWD/9slRXPWeySF8TXvB r9N5yyJwnixQWpZ6BjSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM0bS-005hlu-2j; Wed, 19 Jul 2023 06:24:02 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM0bQ-005hjj-3A for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 06:24:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Transfer-Encoding :Content-Type:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=gIR1BUM1PXWnsB5K3Xfj8plLAT2U2C56xzDzjnsHweg=; b=iYD1WqSN2T6bzMVSvP+okmzx69 u2JLqAxvVwDEg1jWxzcVPXOh8zkgZ/6OKWh8tEnE4uSxjeAy1X9eQ5aassXbzIwIZBcBr2Se53eJa uOHIlziacQhwIsA7fJV7zzvj3UvA1srYlCjPRg5CX1PBVnmkfLOrjSA4eIqczUo/5VcxVrogwPekI VpJuHtBweS0w98A/SwQBTSX3Z+IXQE3trPsh+RHMtT7ZwLQ+qyVRbPMZpmBp0GlTY1BU9sua/RVdI WtavXheRp2142G5zByLgoQnkSO9JmLzmRBZNATuYXUaTrefShzwE5+ov6HeLAgvz+xFd4pmkPfENa DJthOF4g==; Received: from mail-tyzapc01on2071a.outbound.protection.outlook.com ([2a01:111:f403:704b::71a] helo=APC01-TYZ-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLyaF-00DKl4-2W for linux-arm-kernel@lists.infradead.org; Wed, 19 Jul 2023 04:14:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ry5iRKhCcpnHZoKESdw4xQMc+nNaOwTFys63GVXxJ4NfaHoJzBFRi1j/UebdV+BY89sqwexaDF70B/2GpmHUozPhYmxmrLFUs3CK5K9jrwgekrH8fgLI08a0KZ1vSS1vdufkIqNKLumEDghdldgXfiF9OdVQVG0LRB01hPzjMpYh9rEa9beb5s8RaIyibHZakPBEoRiwhLBMlHQ0cyEdZhI62Ns1OWKw72bTtkUnLyHa12dpV3yGtfXb2OAtTLU2E0VUDhBZVhF/WQCGBgLIDKJNWPqxN5tovOZoe4nDExDRfoMzMPQnSTZ6JT50kCna7uAyvM+m52qjA07qV3DnyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gIR1BUM1PXWnsB5K3Xfj8plLAT2U2C56xzDzjnsHweg=; b=hINl6im3RPHY7jCuvNQdl2Wruk2BSMamMtOjRBnQK8rNj8CBCXo1loThpbcRgffGYS+/qp/3y8eISd+yB8ALO6mi/tsFOlB9fMryiNMaXgcvExYU+XQbyzMl7G83Srho/z9R88X1pRL3/8YYlyCf7vT4xmyFHKFtwFJlLHuNKnIQl0k3EwYcLY1e9Um0Xt62nQ6qTWXAMjCeqX6bxrYwOboojeEuWvnmmGGIpHgv6Ms5C1k2SUVaVmGUTFdW/y8FWpeLXS7A7Xmdj1G+xo+kofFOg9m8ewXZbd9t+j6Rhkg2R9NjBemdH/LcgJ/RK1YMh2DGAx+BwUeA+H3omTpRQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIR1BUM1PXWnsB5K3Xfj8plLAT2U2C56xzDzjnsHweg=; b=X60Js4UASwuNZlU3SFNN6vM5GEV4w5T8Ua7+Ysh9WFjHXs/WR3C17S53P4l5UrY5adaYZguva7+zcQzh/I//ekrdcs7k9kRVvUvsPqn0TQZybc3pAVzuX7UgJ2BDh9sbwIO41jr7jw7+TojGPegy/z0uNJEPNrnWcFeF/8xDnzrvsOTri7cENsnwYP9iimqyy/QpvNZPlU4sVUNiL5CoFTUaElf/VbycvaZBcBAHo41LEyn/Gyqjx8+7OYm/lq39sU4YShYq/XDTdCylXk8jgdzMAKNQxS434q5BaRHmxUTn1XkJ5sQWMMYZC8kUi4eOQ4GoBjm/MWilK3EpvU4Fhw== Received: from SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) by TYZPR06MB4551.apcprd06.prod.outlook.com (2603:1096:400:122::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Wed, 19 Jul 2023 04:13:48 +0000 Received: from SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::535e:25af:a3bc:d600]) by SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::535e:25af:a3bc:d600%4]) with mapi id 15.20.6609.022; Wed, 19 Jul 2023 04:13:48 +0000 From: =?eucgb2312_cn?b?zfXD9y3I7bz+tdey47y8yvWyvw==?= <machel@vivo.com> To: Hyun Kwon <hyun.kwon@xilinx.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Michal Simek <michal.simek@amd.com>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> CC: opensource.kernel <opensource.kernel@vivo.com>, =?eucgb2312_cn?b?zfXD9y3I7bz+?= =?eucgb2312_cn?b?tdey47y8yvWyvw==?= <machel@vivo.com> Subject: [PATCH v1] media: platform: Use dev_err_probe instead of dev_err Thread-Topic: [PATCH v1] media: platform: Use dev_err_probe instead of dev_err Thread-Index: Adm592oxaAkH1bchZkK4enMKOu1cyg== Date: Wed, 19 Jul 2023 04:13:47 +0000 Message-ID: <20230719041339.3437-1-machel@vivo.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SG2PR06MB3743:EE_|TYZPR06MB4551:EE_ x-ms-office365-filtering-correlation-id: 054d84dc-b147-4804-f1e6-08db880e8cb2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iw+P9F04RHOMVbkLW2G4N1CDo48/n4D2xGAl0L/aKsFVIboFeixLQDGQkX4ZZVjIQS+VE+chDa5KP14DWPpUtSXkxk6VhU0myGCFV9ZKwqcxISXUnBo1SuIcI5e+iDn3XNBQplW3y0MZPnCrBlJYmZp4Bi8q8urjuPJRFnghSGqChxe3YLjvQynKL1pcJTLXhEQwstBSNhArE5uRp16HwZZmFNayvMvfqe+cTz5wmx5ru4Rvh2Fytj5ne4FtyjcsDLFMCtOj7x4RrucsLXsPCZa/Du3dWp2DByY6nmJ9yuQ/7ujBoPoetoRY3llXBnYndy8UaUWekvpw/7ARHLmBgOiJIbiDiC4X1A/L0OW6hCJqcg8ZHETGRH+L9i+vENNzCfvTeTbgy4/CU7HzYgjfrTQ3dRHT1SBo4+3y4kDb0Eb8PemuE3V2SD11ehzytxRVnuq27wrhpqIoMTGhAdLvHdCR0ACMGm0Ou0Eh6Eyy8eZAuP90/HwH1lfW1/wCb80uw0hyDmXFT/SZOOyvjZrtAgU/Vdy7BfLb66sGN6QFWAkLCCt1zpJJYhQzgrPIIIWwCdDdsYXqYbOQLzvB1rJKa6rd1ze8OXra0Oa5XZSbfu/a7cmf8mYF73IwMUDuMfvG x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3743.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199021)(71200400001)(38350700002)(66946007)(122000001)(54906003)(6486002)(110136005)(52116002)(41300700001)(478600001)(8676002)(8936002)(5660300002)(66476007)(64756008)(66556008)(4326008)(6512007)(66446008)(2616005)(316002)(83380400001)(186003)(1076003)(26005)(107886003)(6506007)(38100700002)(86362001)(36756003)(85182001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?Slp2UmVGajBLTzRzeTJmM21h?= =?eucgb2312_cn?b?RTZRQVpQa3hoNktOd2FvYzBVNm5ubVc3UmRnTlYrZ1N5dmU4Q2lKQmF5c0t5SFJE?= =?eucgb2312_cn?b?cHFFVWdsU0I3VDRhVzZVWUdjaGpINndweUZ6TUZPa3ZGbEhaUFlubzkvWDBuV2hO?= =?eucgb2312_cn?b?Q1dOT2xsRVR6TisyOVhkaW5NSEltMlJwOVV2ZGRtcktzaFdSU3FVbTZSNEpmYldQ?= =?eucgb2312_cn?b?QVhJRVhGU2NyQTZQT3BSeWx4d0lETE42VmpQTWJsUVhmL0hsZERCYllhTkduaDh5?= =?eucgb2312_cn?b?U203M0ZCOUNnR0dlRDZ0cUl2SnUvVm8yZVI0OUlyYmRBTHNtRHlFZE91dUJUY2R3?= =?eucgb2312_cn?b?VVdlZmlNeXIwRWNsUGJySlp6OFFCQmZKZE5pQ3lUengrRXRXcGtsQXBRYVREQkFn?= =?eucgb2312_cn?b?Zmt5UG5nZHhQSEp5QWlEbVBRdnVwSEVwcmwvYm9NV3NqUjJnakVleVppRDgzanNN?= =?eucgb2312_cn?b?SS9oZ3pneVBwRmZTV3dQUEl1VFQyR2lyWVRyN0l1YnJHNnpsNzhGNllkOEZ0WGg2?= =?eucgb2312_cn?b?RXhJcDNuWWhYUG85RHh3UHM5Uyswc29hUkZhWUNXQlZQQnNSNjhVbXBDSlFDTFJ6?= =?eucgb2312_cn?b?cTdpUENQaVc1cTRVOUFpdERsLzFEVW92cUZmZUlOVGoyOHNwVUVIYUM5bmVjbWhB?= =?eucgb2312_cn?b?YWdiZnNEMjJCSmlrRVY5YzM0bCtvRUNMRnZXenhrR3hQRG5vV2hPTm1JUkhJcVZO?= =?eucgb2312_cn?b?NEUxN0t1UzVTbzNVTmhvL3N1QnJMS0VKUzFkQ3ZvdDFWZ3FvaTJoNHFxc3QrZ1cw?= =?eucgb2312_cn?b?ejZvOStpQnV5djB4bXBhTHl6bTdxalhkWWRSL0ZvL0d1QVBCY0Z3ekhzL29OMmo5?= =?eucgb2312_cn?b?ejhCSXlHYVM1a0EyeHhqYUFQcWVpVit3R2lNZzVMRituc0xqeVE3b0lQZmdURDhv?= =?eucgb2312_cn?b?enlsc1MzdWFQdFBvYnozVEZQUUxvVnFqZmVCNEpsYk9uZDRBYURWME54ZHYrYWxV?= =?eucgb2312_cn?b?RzJDYnpQYnVUZEhSSytGbXJjSktmNUVmclZTNDJJOFpIM2pUeWFOM1V5VUc2NWJa?= =?eucgb2312_cn?b?UkFaUXFZKy9GQ0h5RHd1ekdQSk1rSTRMRU9WSFJIbUdVdWxFR1pPWTNUS1d6QXRY?= =?eucgb2312_cn?b?dHpOODVua0VZNW5waFcweTZHUnQ3bmhhZWdORlY2ZGJxc0VjQkJEd0QxVWxFRzRD?= =?eucgb2312_cn?b?Rm5EbVhEMTZJblB1OEwra0IxbmJLcXZ5bXRSRVNqNlh6VkxVSDJpeVVvY2VEeU1x?= =?eucgb2312_cn?b?K3pZUlJEakZvLzEzclFCTldCaTdmRm52YnIrZ21RMEwwbHdwUndmR2padmdGbGc3?= =?eucgb2312_cn?b?SGxoZ1cweG13bUd0TGIreDVSY293MW5aR1Z3a0hRa25GSHBseFlSaUNPNVo3WTJh?= =?eucgb2312_cn?b?cGFWNU10UEtJeGpwZHhiWUdYcG5XQzRKaEZvcTYrOXhYZVd6U1BmbjFpY29pRWR3?= =?eucgb2312_cn?b?OUZVYlRUU0U3a092cnpNNXVIcStaOWJ5WFlCbWMyR3pSdnJrMWdUWkdwcjdZaFE1?= =?eucgb2312_cn?b?WU5DYks0K1RWVWVoSkdDcmZVUmY1MkVCV1hxSVdPYXV4TGZmRnBJSGF4ZDJ5V2Nl?= =?eucgb2312_cn?b?QWIrWU1wVjZLM3pBdlQrM3VFOVFkT09ueVY1a29GYXFjVlIyZE4wcG5KL0t2eVBx?= =?eucgb2312_cn?b?OFBqYmd6S1o5dkltYU1QREg2NzZiR2N6cWcxbk9LcVB0cXhoM1VLaVdRWUowR1Rv?= =?eucgb2312_cn?b?QStGWG9IMk5EMlhwM3orOURHM29UNDVYOGJMM29KSytKM2Z2R3lSenJrQXMvYkEx?= =?eucgb2312_cn?b?QUVWQjJnR2pqcGNIcE1WU3FGNGVNaEVCL2xoUExCZ3VoN3Y1V2FVUlJkVHhFT1JI?= =?eucgb2312_cn?b?M1gvcVdGcFltTHNXdTNTd2NmdGlxME9iNUdMc3lUOTBlclNqNjEwT0xMcEJZMzRX?= =?eucgb2312_cn?b?bzZkZzVGT3cxRjEwVEh5Z2R6emo0WWcrUmlORW9CVkNkaWIzRmtyTlBTTXY3dDlV?= =?eucgb2312_cn?b?M2ZQS1F3QlRUM2I1V1dLVk9ySkdSNkJrcXVlNVEvNG83SnJKVXNvdldxSkpmcm9U?= =?eucgb2312_cn?b?RWlsU1llcmNIWmhHc0dNaTRjc1hqb24vZXo3NUd5U3NNMitXbXdhNFNKVnFvK2Fr?= =?eucgb2312_cn?b?MGJjdFdUeDJRdkF4Ymx3RGsycks5bXRUcFBzQ1NpYy9BYXozUDJtZThqVVFkbA==?= MIME-Version: 1.0 X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 054d84dc-b147-4804-f1e6-08db880e8cb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2023 04:13:47.3919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lqm0Q2EwmmCdBNZtrlzhX1340+2NQuSZCteWvdgwwQ6gC6Vq9NxR9QLc2I84x5h49jJrQXhfJny1qcY3Y06lxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4551 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_051440_269303_42093DE6 X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
[v1] media: platform: Use dev_err_probe instead of dev_err
|
expand
|
diff --git a/drivers/media/platform/xilinx/xilinx-dma.c b/drivers/media/platform/xilinx/xilinx-dma.c index 80d6f5b072ea..16ad39bef6c6 100644 --- a/drivers/media/platform/xilinx/xilinx-dma.c +++ b/drivers/media/platform/xilinx/xilinx-dma.c @@ -708,9 +708,8 @@ int xvip_dma_init(struct xvip_composite_device *xdev, struct xvip_dma *dma, snprintf(name, sizeof(name), "port%u", port); dma->dma = dma_request_chan(dma->xdev->dev, name); if (IS_ERR(dma->dma)) { - ret = PTR_ERR(dma->dma); - if (ret != -EPROBE_DEFER) - dev_err(dma->xdev->dev, "no VDMA channel found\n"); + ret = dev_err_probe(dma->xdev->dev, PTR_ERR(dma->dma), + "no VDMA channel found\n"); goto error; }
It is possible that dma_request_chan will return EPROBE_DEFER, which means that dma->xdev->dev is not ready yet. In this case, dev_err(dma->xdev->dev), there will be no output. This patch fixes the bug. Signed-off-by: Wang Ming <machel@vivo.com> --- drivers/media/platform/xilinx/xilinx-dma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)