[Enable,Designware,XGMAC,VLAN,Stripping,Feature,1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload

Commit Message

[e-mail], [e-mail], "Ng <boon.khai.ng"@intel.com July 21, 2023, 6:26 a.m. UTC

From: Boon Khai Ng <[e-mail]>

This patch is to add the dts setting for the MAC controller on
synopsys 10G Ethernet MAC which allow the 10G MAC to turn on
hardware accelerated VLAN stripping. Once the hardware accelerated
VLAN stripping is turn on, the VLAN tag will be stripped by the
10G Ethernet MAC.

Signed-off-by: Boon Khai Ng <[e-mail]>
Reviewed-by: Shevchenko Andriy <[e-mail]>
---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski July 21, 2023, 10:10 a.m. UTC | #1

On 21/07/2023 08:26, [e-mail] wrote:
> From: Boon Khai Ng <[e-mail]>
> 
> This patch is to add the dts setting for the MAC controller on
> synopsys 10G Ethernet MAC which allow the 10G MAC to turn on
> hardware accelerated VLAN stripping. Once the hardware accelerated
> VLAN stripping is turn on, the VLAN tag will be stripped by the

Subject prefix is totally bogus.


> 10G Ethernet MAC.
> 
> Signed-off-by: Boon Khai Ng <[e-mail]>
> Reviewed-by: Shevchenko Andriy <[e-mail]>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested by
automated tooling. Performing review on untested code might be a waste
of time, thus I will skip this patch entirely till you follow the
process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof

Andy Shevchenko July 21, 2023, 10:17 a.m. UTC | #2

On Fri, Jul 21, 2023 at 02:26:16PM +0800, [e-mail] wrote:
> From: Boon Khai Ng <[e-mail]>
> 
> This patch is to add the dts setting for the MAC controller on
> synopsys 10G Ethernet MAC which allow the 10G MAC to turn on
> hardware accelerated VLAN stripping. Once the hardware accelerated
> VLAN stripping is turn on, the VLAN tag will be stripped by the
> 10G Ethernet MAC.

...

> Reviewed-by: Shevchenko Andriy <[e-mail]>

This is wrong:
- I never reviewed DT bindings in all your series.
- My name for the patches is also wrong.

P.S. What I mentioned in the internal mail is that you can add my tag to
    the code, and not to the DT. Sorry, I probably hadn't been clear.

Ng, Boon Khai July 21, 2023, 3:28 p.m. UTC | #3

> -----Original Message-----
> From: Krzysztof Kozlowski <[e-mail]>
> Sent: Friday, July 21, 2023 6:11 PM
> To: [e-mail]; [e-mail]; "Ng
> <boon.khai.ng"@intel.com; Giuseppe Cavallaro <[e-mail]>;
> Alexandre Torgue <[e-mail]>; Jose Abreu
> <[e-mail]>; David S . Miller <[e-mail]>; Eric
> Dumazet <[e-mail]>; Jakub Kicinski <[e-mail]>; Paolo
> Abeni <[e-mail]>; Maxime Coquelin
> <[e-mail]>; [e-mail]; linux-stm32@st-md-
> mailman.stormreply.com; [e-mail]; linux-
> [e-mail]
> Cc: Ng, Boon Khai <[e-mail]>; Shevchenko, Andriy
> <[e-mail]>; Tham, Mun Yew <[e-mail]>;
> Swee, Leong Ching <[e-mail]>; G Thomas, Rohan
> <[e-mail]>; Shevchenko Andriy
> <[e-mail]>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings:
> net: snps,dwmac: Add description for rx-vlan-offload
> 
> On 21/07/2023 08:26, [e-mail] wrote:
> > From: Boon Khai Ng <[e-mail]>
> >
> > This patch is to add the dts setting for the MAC controller on
> > synopsys 10G Ethernet MAC which allow the 10G MAC to turn on hardware
> > accelerated VLAN stripping. Once the hardware accelerated VLAN
> > stripping is turn on, the VLAN tag will be stripped by the
> 
> Subject prefix is totally bogus.
> 

Which part? It's a 10G Ethernet IP from Sysnopsys, in Roman character it is X (mean 10), so XGMAC.
Even the driver file I'm editing it is dw"xgmac".

> 
> > 10G Ethernet MAC.
> >
> > Signed-off-by: Boon Khai Ng <[e-mail]>
> > Reviewed-by: Shevchenko Andriy <[e-mail]>
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives you
> outdated entries. Therefore please be sure you base your patches on recent
> Linux kernel.
> 

This is based on net-next repository suggested by the get maintainer script.

I got the latest net-next just now at the Commit-id b44693495af8 
which just committed yesterday.

$ ./scripts/get_maintainer.pl  --scm  -f drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
Giuseppe Cavallaro <[e-mail]> (supporter:STMMAC ETHERNET DRIVER)
Alexandre Torgue <[e-mail]> (supporter:STMMAC ETHERNET DRIVER)
Jose Abreu <[e-mail]> (supporter:STMMAC ETHERNET DRIVER)
"David S. Miller" <[e-mail]> (maintainer:NETWORKING DRIVERS)
Eric Dumazet <[e-mail]> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <[e-mail]> (maintainer:NETWORKING DRIVERS)
Paolo Abeni <[e-mail]> (maintainer:NETWORKING DRIVERS)
Maxime Coquelin <[e-mail]> (maintainer:ARM/STM32 ARCHITECTURE)
Richard Cochran <[e-mail]> (maintainer:PTP HARDWARE CLOCK SUPPORT)
[e-mail] (open list:STMMAC ETHERNET DRIVER)
[e-mail] (moderated list:ARM/STM32 ARCHITECTURE)
[e-mail] (moderated list:ARM/STM32 ARCHITECTURE)
[e-mail] (open list)
git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
git git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

> You missed at least DT list (maybe more), so this won't be tested by automated
> tooling. Performing review on untested code might be a waste of time, thus I
> will skip this patch entirely till you follow the process allowing the patch to be
> tested.
> 

This is a new device bringup, thus the DT is not available yet. The DTS will be upstreamed
by my another colleague, unless, if I can upstream only my part on the setting? 

> Please kindly resend and include all necessary To/Cc entries.
> 
> Best regards,
> Krzysztof

Ng, Boon Khai July 21, 2023, 3:35 p.m. UTC | #4

> -----Original Message-----
> From: Shevchenko, Andriy <[e-mail]>
> Sent: Friday, July 21, 2023 6:18 PM
> Cc: Giuseppe Cavallaro <[e-mail]>; Alexandre Torgue
> <[e-mail]>; Jose Abreu <[e-mail]>;
> David S . Miller <[e-mail]>; Eric Dumazet
> <[e-mail]>; Jakub Kicinski <[e-mail]>; Paolo Abeni
> <[e-mail]>; Maxime Coquelin <[e-mail]>;
> [e-mail]; [e-mail];
> [e-mail]; [e-mail]; Ng,
> Boon Khai <[e-mail]>; Tham, Mun Yew
> <[e-mail]>; Swee, Leong Ching
> <[e-mail]>; G Thomas, Rohan
> <[e-mail]>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings: net: snps,dwmac: Add description for rx-vlan-offload
> 
> On Fri, Jul 21, 2023 at 02:26:16PM +0800, [e-mail] wrote:
> > From: Boon Khai Ng <[e-mail]>
> >
> > This patch is to add the dts setting for the MAC controller on
> > synopsys 10G Ethernet MAC which allow the 10G MAC to turn on hardware
> > accelerated VLAN stripping. Once the hardware accelerated VLAN
> > stripping is turn on, the VLAN tag will be stripped by the 10G
> > Ethernet MAC.
> 
> ...
> 
> > Reviewed-by: Shevchenko Andriy <[e-mail]>
> 
> This is wrong:
> - I never reviewed DT bindings in all your series.
> - My name for the patches is also wrong.
> 
> P.S. What I mentioned in the internal mail is that you can add my tag to
>     the code, and not to the DT. Sorry, I probably hadn't been clear.
> 

My bad, sorry for interpreting the meaning wrongly, I will remove all the 
"Reviewed-by" stamp from all the DT patches on the next update.

However I copied the Reviewed-by: from the previous email, your name 
Shouldn't be wrong. 

> --
> With Best Regards,
> Andy Shevchenko
>

Andy Shevchenko July 21, 2023, 3:48 p.m. UTC | #5

On Fri, Jul 21, 2023 at 06:35:44PM +0300, Ng, Boon Khai wrote:
> > From: Shevchenko, Andriy <[e-mail]>
> > Sent: Friday, July 21, 2023 6:18 PM
> > On Fri, Jul 21, 2023 at 02:26:16PM +0800, [e-mail] wrote:
> > > From: Boon Khai Ng <[e-mail]>

...

> > > Reviewed-by: Shevchenko Andriy <[e-mail]>
> > 
> > This is wrong:
> > - I never reviewed DT bindings in all your series.
> > - My name for the patches is also wrong.
> > 
> > P.S. What I mentioned in the internal mail is that you can add my tag to
> >     the code, and not to the DT. Sorry, I probably hadn't been clear.
> 
> My bad, sorry for interpreting the meaning wrongly, I will remove all the 
> "Reviewed-by" stamp from all the DT patches on the next update.
> 
> However I copied the Reviewed-by: from the previous email, your name
> Shouldn't be wrong.

Oh, this is a bit messy. The address for the kernel work should be
Andy Shevchenko <[e-mail]>

Ng, Boon Khai July 21, 2023, 3:51 p.m. UTC | #6

> -----Original Message-----
> From: Shevchenko, Andriy <[e-mail]>
> Sent: Friday, July 21, 2023 11:49 PM
> To: Ng, Boon Khai <[e-mail]>
> Cc: Giuseppe Cavallaro <[e-mail]>; Alexandre Torgue
> <[e-mail]>; Jose Abreu <[e-mail]>;
> David S . Miller <[e-mail]>; Eric Dumazet
> <[e-mail]>; Jakub Kicinski <[e-mail]>; Paolo Abeni
> <[e-mail]>; Maxime Coquelin <[e-mail]>;
> [e-mail]; [e-mail];
> [e-mail]; [e-mail]; Tham,
> Mun Yew <[e-mail]>; Swee, Leong Ching
> <[e-mail]>; G Thomas, Rohan
> <[e-mail]>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings: net: snps,dwmac: Add description for rx-vlan-offload
> 
> On Fri, Jul 21, 2023 at 06:35:44PM +0300, Ng, Boon Khai wrote:
> > > From: Shevchenko, Andriy <[e-mail]>
> > > Sent: Friday, July 21, 2023 6:18 PM
> > > On Fri, Jul 21, 2023 at 02:26:16PM +0800, [e-mail]
> wrote:
> > > > From: Boon Khai Ng <[e-mail]>
> 
> ...
> 
> > > > Reviewed-by: Shevchenko Andriy <[e-mail]>
> > >
> > > This is wrong:
> > > - I never reviewed DT bindings in all your series.
> > > - My name for the patches is also wrong.
> > >
> > > P.S. What I mentioned in the internal mail is that you can add my tag to
> > >     the code, and not to the DT. Sorry, I probably hadn't been clear.
> >
> > My bad, sorry for interpreting the meaning wrongly, I will remove all
> > the "Reviewed-by" stamp from all the DT patches on the next update.
> >
> > However I copied the Reviewed-by: from the previous email, your name
> > Shouldn't be wrong.
> 
> Oh, this is a bit messy. The address for the kernel work should be Andy
> Shevchenko <[e-mail]>
> 

Ah okay, got it. Will update that in the next patch.

> --
> With Best Regards,
> Andy Shevchenko
>

Krzysztof Kozlowski July 21, 2023, 4:21 p.m. UTC | #7

On 21/07/2023 17:28, Ng, Boon Khai wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <[e-mail]>
>> Sent: Friday, July 21, 2023 6:11 PM
>> To: [e-mail]; [e-mail]; "Ng
>> <boon.khai.ng"@intel.com; Giuseppe Cavallaro <[e-mail]>;
>> Alexandre Torgue <[e-mail]>; Jose Abreu
>> <[e-mail]>; David S . Miller <[e-mail]>; Eric
>> Dumazet <[e-mail]>; Jakub Kicinski <[e-mail]>; Paolo
>> Abeni <[e-mail]>; Maxime Coquelin
>> <[e-mail]>; [e-mail]; linux-stm32@st-md-
>> mailman.stormreply.com; [e-mail]; linux-
>> [e-mail]
>> Cc: Ng, Boon Khai <[e-mail]>; Shevchenko, Andriy
>> <[e-mail]>; Tham, Mun Yew <[e-mail]>;
>> Swee, Leong Ching <[e-mail]>; G Thomas, Rohan
>> <[e-mail]>; Shevchenko Andriy
>> <[e-mail]>
>> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings:
>> net: snps,dwmac: Add description for rx-vlan-offload
>>
>> On 21/07/2023 08:26, [e-mail] wrote:
>>> From: Boon Khai Ng <[e-mail]>
>>>
>>> This patch is to add the dts setting for the MAC controller on
>>> synopsys 10G Ethernet MAC which allow the 10G MAC to turn on hardware
>>> accelerated VLAN stripping. Once the hardware accelerated VLAN
>>> stripping is turn on, the VLAN tag will be stripped by the
>>
>> Subject prefix is totally bogus.
>>
> 
> Which part? It's a 10G Ethernet IP from Sysnopsys, in Roman character it is X (mean 10), so XGMAC.
> Even the driver file I'm editing it is dw"xgmac".

Everything in [].

> 
>>
>>> 10G Ethernet MAC.
>>>
>>> Signed-off-by: Boon Khai Ng <[e-mail]>
>>> Reviewed-by: Shevchenko Andriy <[e-mail]>
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>> to CC. It might happen, that command when run on an older kernel, gives you
>> outdated entries. Therefore please be sure you base your patches on recent
>> Linux kernel.
>>
> 
> This is based on net-next repository suggested by the get maintainer script.
> 
> I got the latest net-next just now at the Commit-id b44693495af8 
> which just committed yesterday.
> 
> $ ./scripts/get_maintainer.pl  --scm  -f drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c

That's not how you run it. get_maintainers.pl should be run on patches
or on all files, not just some selection.

> Giuseppe Cavallaro <[e-mail]> (supporter:STMMAC ETHERNET DRIVER)
> Alexandre Torgue <[e-mail]> (supporter:STMMAC ETHERNET DRIVER)
> Jose Abreu <[e-mail]> (supporter:STMMAC ETHERNET DRIVER)
> "David S. Miller" <[e-mail]> (maintainer:NETWORKING DRIVERS)
> Eric Dumazet <[e-mail]> (maintainer:NETWORKING DRIVERS)
> Jakub Kicinski <[e-mail]> (maintainer:NETWORKING DRIVERS)
> Paolo Abeni <[e-mail]> (maintainer:NETWORKING DRIVERS)
> Maxime Coquelin <[e-mail]> (maintainer:ARM/STM32 ARCHITECTURE)
> Richard Cochran <[e-mail]> (maintainer:PTP HARDWARE CLOCK SUPPORT)
> [e-mail] (open list:STMMAC ETHERNET DRIVER)
> [e-mail] (moderated list:ARM/STM32 ARCHITECTURE)
> [e-mail] (moderated list:ARM/STM32 ARCHITECTURE)
> [e-mail] (open list)
> git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
> git git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
> git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 
>> You missed at least DT list (maybe more), so this won't be tested by automated
>> tooling. Performing review on untested code might be a waste of time, thus I
>> will skip this patch entirely till you follow the process allowing the patch to be
>> tested.
>>
> 
> This is a new device bringup, thus the DT is not available yet. The DTS will be upstreamed
> by my another colleague, unless, if I can upstream only my part on the setting? 

You are mixing now DTS and DT bindings. Sorry, we do not talk about DTS.

Follow our process of submitting patches. For sure there are folks in
Intel which can explain it to you.


Best regards,
Krzysztof

Krzysztof Kozlowski July 21, 2023, 4:26 p.m. UTC | #8

On 21/07/2023 17:28, Ng, Boon Khai wrote:
> This is a new device bringup, thus the DT is not available yet. The DTS will be upstreamed
> by my another colleague, unless, if I can upstream only my part on the setting? 
> 
>> Please kindly resend and include all necessary To/Cc entries.

To be clear, since you do not agree with my comment you skipped vital
lists, this was not tested by automation so it is NAK from me.

Sorry.

Best regards,
Krzysztof

Ng, Boon Khai July 21, 2023, 4:33 p.m. UTC | #9

> -----Original Message-----
> From: Krzysztof Kozlowski <[e-mail]>
> Sent: Saturday, July 22, 2023 12:22 AM
> To: Ng, Boon Khai <[e-mail]>; [e-mail];
> [e-mail]; Giuseppe Cavallaro <[e-mail]>;
> Alexandre Torgue <[e-mail]>; Jose Abreu
> <[e-mail]>; David S . Miller <[e-mail]>; Eric
> Dumazet <[e-mail]>; Jakub Kicinski <[e-mail]>;
> Paolo Abeni <[e-mail]>; Maxime Coquelin
> <[e-mail]>; [e-mail]; linux-stm32@st-
> md-mailman.stormreply.com; [e-mail]; linux-
> [e-mail]
> Cc: Shevchenko, Andriy <[e-mail]>; Tham, Mun Yew
> <[e-mail]>; Swee, Leong Ching
> <[e-mail]>; G Thomas, Rohan
> <[e-mail]>; Shevchenko Andriy
> <[e-mail]>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings: net: snps,dwmac: Add description for rx-vlan-offload
> 
> On 21/07/2023 17:28, Ng, Boon Khai wrote:
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <[e-mail]>
> >> Sent: Friday, July 21, 2023 6:11 PM
> >> To: [e-mail]; [e-mail]; "Ng
> >> <boon.khai.ng"@intel.com; Giuseppe Cavallaro
> >> <[e-mail]>; Alexandre Torgue
> >> <[e-mail]>; Jose Abreu <[e-mail]>;
> >> David S . Miller <[e-mail]>; Eric Dumazet
> >> <[e-mail]>; Jakub Kicinski <[e-mail]>; Paolo
> Abeni
> >> <[e-mail]>; Maxime Coquelin
> <[e-mail]>;
> >> [e-mail]; linux-stm32@st-md- mailman.stormreply.com;
> >> [e-mail]; linux- [e-mail]
> >> Cc: Ng, Boon Khai <[e-mail]>; Shevchenko, Andriy
> >> <[e-mail]>; Tham, Mun Yew
> >> <[e-mail]>; Swee, Leong Ching
> >> <[e-mail]>; G Thomas, Rohan
> >> <[e-mail]>; Shevchenko Andriy
> >> <[e-mail]>
> >> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings:
> >> net: snps,dwmac: Add description for rx-vlan-offload
> >>
> >> On 21/07/2023 08:26, [e-mail] wrote:
> >>> From: Boon Khai Ng <[e-mail]>
> >>>
> >>> This patch is to add the dts setting for the MAC controller on
> >>> synopsys 10G Ethernet MAC which allow the 10G MAC to turn on
> >>> hardware accelerated VLAN stripping. Once the hardware accelerated
> >>> VLAN stripping is turn on, the VLAN tag will be stripped by the
> >>
> >> Subject prefix is totally bogus.
> >>
> >
> > Which part? It's a 10G Ethernet IP from Sysnopsys, in Roman character it is
> X (mean 10), so XGMAC.
> > Even the driver file I'm editing it is dw"xgmac".
> 
> Everything in [].
> 
> >
> >>
> >>> 10G Ethernet MAC.
> >>>
> >>> Signed-off-by: Boon Khai Ng <[e-mail]>
> >>> Reviewed-by: Shevchenko Andriy <[e-mail]>
> >>
> >> Please use scripts/get_maintainers.pl to get a list of necessary
> >> people and lists to CC. It might happen, that command when run on an
> >> older kernel, gives you outdated entries. Therefore please be sure
> >> you base your patches on recent Linux kernel.
> >>
> >
> > This is based on net-next repository suggested by the get maintainer script.
> >
> > I got the latest net-next just now at the Commit-id b44693495af8 which
> > just committed yesterday.
> >
> > $ ./scripts/get_maintainer.pl  --scm  -f
> > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> 
> That's not how you run it. get_maintainers.pl should be run on patches or on
> all files, not just some selection.
> 
> > Giuseppe Cavallaro <[e-mail]> (supporter:STMMAC
> ETHERNET
> > DRIVER) Alexandre Torgue <[e-mail]>
> > (supporter:STMMAC ETHERNET DRIVER) Jose Abreu
> <[e-mail]>
> > (supporter:STMMAC ETHERNET DRIVER) "David S. Miller"
> > <[e-mail]> (maintainer:NETWORKING DRIVERS) Eric
> Dumazet
> > <[e-mail]> (maintainer:NETWORKING DRIVERS) Jakub
> Kicinski
> > <[e-mail]> (maintainer:NETWORKING DRIVERS) Paolo Abeni
> > <[e-mail]> (maintainer:NETWORKING DRIVERS) Maxime
> Coquelin
> > <[e-mail]> (maintainer:ARM/STM32 ARCHITECTURE)
> > Richard Cochran <[e-mail]> (maintainer:PTP HARDWARE
> > CLOCK SUPPORT) [e-mail] (open list:STMMAC ETHERNET
> > DRIVER) [e-mail] (moderated
> > list:ARM/STM32 ARCHITECTURE) [e-mail]
> > (moderated list:ARM/STM32 ARCHITECTURE) [e-mail]
> > (open list) git
> > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> > git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
> > git git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
> > stm32-next git
> > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >
> >> You missed at least DT list (maybe more), so this won't be tested by
> >> automated tooling. Performing review on untested code might be a
> >> waste of time, thus I will skip this patch entirely till you follow
> >> the process allowing the patch to be tested.
> >>
> >
> > This is a new device bringup, thus the DT is not available yet. The
> > DTS will be upstreamed by my another colleague, unless, if I can upstream
> only my part on the setting?
> 
> You are mixing now DTS and DT bindings. Sorry, we do not talk about DTS.
> 
> Follow our process of submitting patches. For sure there are folks in Intel
> which can explain it to you.
> 

Ah see, so you were saying I'm missing the cc list of the maintainer related to the
DT binding. 

> 
> Best regards,
> Krzysztof

Ng, Boon Khai July 21, 2023, 4:39 p.m. UTC | #10

> -----Original Message-----
> From: Krzysztof Kozlowski <[e-mail]>
> Sent: Saturday, July 22, 2023 12:26 AM
> To: Ng, Boon Khai <[e-mail]>; [e-mail];
> [e-mail]; Giuseppe Cavallaro <[e-mail]>;
> Alexandre Torgue <[e-mail]>; Jose Abreu
> <[e-mail]>; David S . Miller <[e-mail]>; Eric
> Dumazet <[e-mail]>; Jakub Kicinski <[e-mail]>;
> Paolo Abeni <[e-mail]>; Maxime Coquelin
> <[e-mail]>; [e-mail]; linux-stm32@st-
> md-mailman.stormreply.com; [e-mail]; linux-
> [e-mail]
> Cc: Shevchenko, Andriy <[e-mail]>; Tham, Mun Yew
> <[e-mail]>; Swee, Leong Ching
> <[e-mail]>; G Thomas, Rohan
> <[e-mail]>; Shevchenko Andriy
> <[e-mail]>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings: net: snps,dwmac: Add description for rx-vlan-offload
> 
> On 21/07/2023 17:28, Ng, Boon Khai wrote:
> > This is a new device bringup, thus the DT is not available yet. The
> > DTS will be upstreamed by my another colleague, unless, if I can upstream
> only my part on the setting?
> >
> >> Please kindly resend and include all necessary To/Cc entries.
> 
> To be clear, since you do not agree with my comment you skipped vital lists,
> this was not tested by automation so it is NAK from me.
> 
> Sorry.
> 

I understand that I already get a NAK at the beginning. But I don’t understand why,
Please don’t get me wrong, I'm not disagreeing your comments, was trying to understand
the reason behind and also which are the step that I made a mistake(s) on,  this is to help
me to learn at the same time to smoothen the upstreaming process.

> Best regards,
> Krzysztof

Jakub Kicinski July 22, 2023, 1:55 a.m. UTC | #11

On Fri, 21 Jul 2023 18:21:32 +0200 Krzysztof Kozlowski wrote:
> > $ ./scripts/get_maintainer.pl  --scm  -f drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c  
> 
> That's not how you run it. get_maintainers.pl should be run on patches
> or on all files, not just some selection.

Adding Joe for visibility (I proposed to print a warning when people 
do this and IIRC he wasn't on board).

Joe Perches July 22, 2023, 3:32 a.m. UTC | #12

On Fri, 2023-07-21 at 18:55 -0700, Jakub Kicinski wrote:
> On Fri, 21 Jul 2023 18:21:32 +0200 Krzysztof Kozlowski wrote:
> > > $ ./scripts/get_maintainer.pl  --scm  -f drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c  
> > 
> > That's not how you run it. get_maintainers.pl should be run on patches
> > or on all files, not just some selection.
> 
> Adding Joe for visibility (I proposed to print a warning when people 
> do this and IIRC he wasn't on board).

What's the issue here?  Other than _how_ the script was used,
I don't see an actual problem with the script itself.

https://lore.kernel.org/lkml/[e-mail]/

As far as I can tell, the patch series address list was identical
for the 0/2, 1/2, and 2/2 submissions:

--------------------------------

0/2:

   From: [e-mail], [e-mail], "Ng <boon.khai.ng"@intel.com
   To: Giuseppe Cavallaro <[e-mail]>,
   	Alexandre Torgue <[e-mail]>,
   	Jose Abreu <[e-mail]>,
   	"David S . Miller" <[e-mail]>,
   	Eric Dumazet <[e-mail]>,
   	Jakub Kicinski <[e-mail]>, Paolo Abeni <[e-mail]>,
   	Maxime Coquelin <[e-mail]>,
   	[e-mail], [e-mail],
   	[e-mail],
   	[e-mail]
   Cc: Boon Khai Ng <[e-mail]>,
   	Shevchenko Andriy <[e-mail]>,
   	Mun Yew Tham <[e-mail]>,
   	Leong Ching Swee <[e-mail]>,
   	G Thomas Rohan <[e-mail]>,
   	Shevchenko Andriy <[e-mail]>
   Subject: [Enable Designware XGMAC VLAN Stripping Feature 0/2]
   
1/2:

   From: [e-mail], [e-mail], "Ng <boon.khai.ng"@intel.com
   To: Giuseppe Cavallaro <[e-mail]>,
   	Alexandre Torgue <[e-mail]>,
   	Jose Abreu <[e-mail]>,
   	"David S . Miller" <[e-mail]>,
   	Eric Dumazet <[e-mail]>,
   	Jakub Kicinski <[e-mail]>, Paolo Abeni <[e-mail]>,
   	Maxime Coquelin <[e-mail]>,
   	[e-mail], [e-mail],
   	[e-mail],
   	[e-mail]
   Cc: Boon Khai Ng <[e-mail]>,
   	Shevchenko Andriy <[e-mail]>,
   	Mun Yew Tham <[e-mail]>,
   	Leong Ching Swee <[e-mail]>,
   	G Thomas Rohan <[e-mail]>,
   	Shevchenko Andriy <[e-mail]>
   Subject: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload
   
2/2:

   From: [e-mail], [e-mail], "Ng <boon.khai.ng"@intel.com
   To: Giuseppe Cavallaro <[e-mail]>,
   	Alexandre Torgue <[e-mail]>,
   	Jose Abreu <[e-mail]>,
   	"David S . Miller" <[e-mail]>,
   	Eric Dumazet <[e-mail]>,
   	Jakub Kicinski <[e-mail]>, Paolo Abeni <[e-mail]>,
   	Maxime Coquelin <[e-mail]>,
   	[e-mail], [e-mail],
   	[e-mail],
   	[e-mail]
   Cc: Boon Khai Ng <[e-mail]>,
   	Shevchenko Andriy <[e-mail]>,
   	Mun Yew Tham <[e-mail]>,
   	Leong Ching Swee <[e-mail]>,
   	G Thomas Rohan <[e-mail]>,
   	Shevchenko Andriy <[e-mail]>
   Subject: [Enable Designware XGMAC VLAN Stripping Feature 2/2] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
   
--------------------------------

vger has a limit on the number of recipients for a single email
so patch series that cc all possible recipients can be bounced
and not forwarded by vger.

So I think when submitting a patch series, it's necessary to send
just the cover letter to all mailing lists for all files/paths
modified by any file in the patch series and specific patches
are sent to maintainers, reviewers and the specific mailing lists
modified by the specific patch.

I use the scripts below to send patch series where a patch series
are the only files in individual directories.

(Well I used to use, I'm not actively reading or creating kernel patches right now)

$ cat ~/bin/to.sh
#!/bin/bash

opts="--nogit --nogit-fallback --norolestats --pattern-depth=1"

if [[ $(basename $1) =~ ^0000- ]] ; then
    ./scripts/get_maintainer.pl --nom $opts  $(dirname $1)/*
else
    maint=$(./scripts/get_maintainer.pl --nol $opts $1)
    if [ "$maint" == "" ] ; then
	echo "[e-mail]"
    else
	echo "$maint"
    fi
fi


$ cat ~/bin/cc.sh
#!/bin/bash

opts="--nogit --nogit-fallback --norolestats"
maint_file=$(mktemp -t XXXXXXXX.cc)

if [[ $(basename $1) =~ ^0000- ]] ; then
    ./scripts/get_maintainer.pl $opts $(dirname $1)/* |  \
	~/bin/remove_undesirable_emails.sh > $maint_file
    count=$(wc -c $maint_file | cut -f1 -d" ")
    if [[ $count -lt 512 ]] ; then
	cat $maint_file
    else
	./scripts/get_maintainer.pl -nom -nor $opts $(dirname $1)/* | \
	    ~/bin/remove_undesirable_emails.sh
    fi
else
    ./scripts/get_maintainer.pl $opts $1 | \
	~/bin/remove_undesirable_emails.sh > $maint_file
    count=$(wc -l $maint_file | cut -f1 -d" ")
    if [[ $count -gt 0 ]] ; then
	cat $maint_file
    else
	./scripts/get_maintainer.pl --git --git-fallback --norolestats $1 | \
	    ~/bin/remove_undesirable_emails.sh
    fi
fi
rm -f $maint_file


$ cat ~/bin/remove_undesirable_emails.sh
grep -vPi "(?:\bIngo\s+Molnar\b)"

$

(nb: Ingo asked not to receive any emails from me)

And these scripts are used with git send-email with a .gitconfig block

[sendemail]
	chainreplyto = false
	thread = false
	suppresscc = self
	cccmd = ~/bin/cc.sh
	tocmd = ~/bin/to.sh

These scripts would have added 2 mailing lists to patch 0/n:

[e-mail] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[e-mail] (open list:ARM/RISC-V/RENESAS ARCHITECTURE)

and it would also have had a different recipient list for 1/2 as well

$ ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/net/snps,dwmac.yaml
"David S. Miller" <[e-mail]> (maintainer:NETWORKING DRIVERS)
Eric Dumazet <[e-mail]> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <[e-mail]> (maintainer:NETWORKING DRIVERS)
Paolo Abeni <[e-mail]> (maintainer:NETWORKING DRIVERS)
Rob Herring <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Conor Dooley <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Richard Cochran <[e-mail]> (maintainer:PTP HARDWARE CLOCK SUPPORT)
Geert Uytterhoeven <[e-mail]> (supporter:ARM/RISC-V/RENESAS ARCHITECTURE)
Magnus Damm <[e-mail]> (supporter:ARM/RISC-V/RENESAS ARCHITECTURE)
Alexandre Torgue <[e-mail]> (in file)
Giuseppe Cavallaro <[e-mail]> (in file)
Jose Abreu <[e-mail]> (in file)
[e-mail] (open list:NETWORKING DRIVERS)
[e-mail] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[e-mail] (open list)
[e-mail] (open list:ARM/RISC-V/RENESAS ARCHITECTURE)

Patch

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index ddf9522a5dc2..905de37e861f 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -487,6 +487,11 @@  properties:
     description:
       Frequency division factor for MDC clock.
 
+  snps,rx-vlan-offload:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      Enable hardware-accelerated RX VLAN stripping.
+
   mdio:
     $ref: mdio.yaml#
     unevaluatedProperties: false