diff mbox series

[v5,1/4] dt-bindings: arm: fsl: Add VAR-SOM-MX6 SoM

Message ID 20230721095003.3681484-1-james.hilliard1@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v5,1/4] dt-bindings: arm: fsl: Add VAR-SOM-MX6 SoM | expand

Commit Message

James Hilliard July 21, 2023, 9:49 a.m. UTC 
Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski July 21, 2023, 9:58 a.m. UTC | #1 
On 21/07/2023 11:49, James Hilliard wrote:
> Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM.
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 2510eaa8906d..da486c4a4ecf 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -385,6 +385,11 @@ properties:
>            - const: toradex,apalis_imx6q
>            - const: fsl,imx6q
>  
> +      - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
> +        items:
> +          - const: variscite,var-som-imx6q

Again, this cannot be on its own. This commit does not make sense on its
own.

Best regards,
Krzysztof
James Hilliard July 21, 2023, 9:59 a.m. UTC | #2 
On Fri, Jul 21, 2023 at 3:58 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 21/07/2023 11:49, James Hilliard wrote:
> > Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM.
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 2510eaa8906d..da486c4a4ecf 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -385,6 +385,11 @@ properties:
> >            - const: toradex,apalis_imx6q
> >            - const: fsl,imx6q
> >
> > +      - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
> > +        items:
> > +          - const: variscite,var-som-imx6q
>
> Again, this cannot be on its own. This commit does not make sense on its
> own.

So I should just combine this with patch 3?

>
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 2510eaa8906d..da486c4a4ecf 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -385,6 +385,11 @@  properties:
           - const: toradex,apalis_imx6q
           - const: fsl,imx6q
 
+      - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
+        items:
+          - const: variscite,var-som-imx6q
+          - const: fsl,imx6q
+
       - description: TQ-Systems TQMa6Q SoM (variant A) on MBa6x
         items:
           - const: tq,imx6q-mba6x-a