| Message ID | 20230721210042.21535-10-duje.mihanovic@skole.hr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Initial Marvell PXA1908 support | expand |
On Fri, 21 Jul 2023 22:37:51 +0200, Duje Mihanović wrote: > Add dt bindings and documentation for Marvell PXA1908 SoC. > > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > --- > .../bindings/arm/marvell/marvell,pxa1908.yaml | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/arm/marvell/pxa1908.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230721210042.21535-10-duje.mihanovic@skole.hr The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 21/07/2023 22:37, Duje Mihanović wrote: > Add dt bindings and documentation for Marvell PXA1908 SoC. > > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > --- > .../bindings/arm/marvell/marvell,pxa1908.yaml | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml > > diff --git a/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml b/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml > new file mode 100644 > index 000000000000..085d238129ad > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml I suggest having one bindings file for all pxa platforms, not per one SoC. > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/marvell/pxa1908.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell PXA1908 Platforms > + > +maintainers: > + - Duje Mihanović <duje.mihanovic@skole.hr> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - items: > + - enum: > + - samsung,coreprimevelte > + - const: marvell,pxa1908 > + > + pxa,rev-id: Incorrect vendor prefix > + $ref: /schemas/types.yaml#/definitions/uint32-array > + oneOf: That's not oneOf, so just items: > + - items: > + - description: Board ID > + - description: Board revision > + description: | Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml b/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml new file mode 100644 index 000000000000..085d238129ad --- /dev/null +++ b/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml @@ -0,0 +1,33 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/marvell/pxa1908.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell PXA1908 Platforms + +maintainers: + - Duje Mihanović <duje.mihanovic@skole.hr> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + - items: + - enum: + - samsung,coreprimevelte + - const: marvell,pxa1908 + + pxa,rev-id: + $ref: /schemas/types.yaml#/definitions/uint32-array + oneOf: + - items: + - description: Board ID + - description: Board revision + description: | + Some bootloaders use this property to determine whether the provided dt + blob is compatible with a specific device. For example, Samsung's S-Boot + is known to require this property. + +additionalProperties: false
Add dt bindings and documentation for Marvell PXA1908 SoC. Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> --- .../bindings/arm/marvell/marvell,pxa1908.yaml | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml