| Message ID | 20230721232123.2690960-1-xiaolei.wang@windriver.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: imx: Set default tuning step for imx7d usdhc0 | expand |
Hi Xiaolei, On Fri, Jul 21, 2023 at 8:21 PM Xiaolei Wang <xiaolei.wang@windriver.com> wrote: > > If the tuning step is not set, the tuning step is set to 1. > For some sd cards, the following Tuning timeout will occur, > so set the default tuning step. > > Tuning failed, falling back to fixed sampling clock > mmc0: Tuning failed, falling back to fixed sampling clock > > Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting") > Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> > --- > arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts > index 75f1cd14bea1..d7396fbfcaf8 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts > +++ b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts > @@ -493,6 +493,7 @@ &usdhc1 { > vmmc-supply = <®_sd1_vmmc>; > wakeup-source; > keep-power-in-suspend; > + fsl,tuning-step = <2>; I wondering if this should be a imx7s.dtsi property instead. NXP vendor kernel passes: fsl,tuning-step = <2>; fsl,tuning-start-tap = <20>; https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.dtsi#L1216-L1217 Bough? Any suggestions? Thanks
On 7/22/23 8:16 AM, Fabio Estevam wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > Hi Xiaolei, > > On Fri, Jul 21, 2023 at 8:21 PM Xiaolei Wang <xiaolei.wang@windriver.com> wrote: >> If the tuning step is not set, the tuning step is set to 1. >> For some sd cards, the following Tuning timeout will occur, >> so set the default tuning step. >> >> Tuning failed, falling back to fixed sampling clock >> mmc0: Tuning failed, falling back to fixed sampling clock >> >> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting") >> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> >> --- >> arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts >> index 75f1cd14bea1..d7396fbfcaf8 100644 >> --- a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts >> +++ b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts >> @@ -493,6 +493,7 @@ &usdhc1 { >> vmmc-supply = <®_sd1_vmmc>; >> wakeup-source; >> keep-power-in-suspend; >> + fsl,tuning-step = <2>; > I wondering if this should be a imx7s.dtsi property instead. > > NXP vendor kernel passes: > > fsl,tuning-step = <2>; > fsl,tuning-start-tap = <20>; > > https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.dtsi#L1216-L1217 > > Bough? Any suggestions? Oh, I didn't notice this patch on linux-imx, I refer to the settings in https://github.com/nxp-imx/uboot-imx.git, but it should be the same, I think it is better to bring this patch in thanks xiaolei > > Thanks
On Sat, Jul 22, 2023 at 4:29 AM wangxiaolei <xiaolei.wang@windriver.com> wrote: > Oh, I didn't notice this patch on linux-imx, I refer to the settings in > https://github.com/nxp-imx/uboot-imx.git, > > but it should be the same, I think it is better to bring this patch in Please send a patch that passes: fsl,tuning-step = <2>; fsl,tuning-start-tap = <20>; to all usdhc instances in imx7s.dtsi. Other imx dtsi files do this, but imx7s.dtsi currently misses these properties. Thanks
diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts index 75f1cd14bea1..d7396fbfcaf8 100644 --- a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts +++ b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts @@ -493,6 +493,7 @@ &usdhc1 { vmmc-supply = <®_sd1_vmmc>; wakeup-source; keep-power-in-suspend; + fsl,tuning-step = <2>; status = "okay"; };
If the tuning step is not set, the tuning step is set to 1. For some sd cards, the following Tuning timeout will occur, so set the default tuning step. Tuning failed, falling back to fixed sampling clock mmc0: Tuning failed, falling back to fixed sampling clock Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting") Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> --- arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 1 + 1 file changed, 1 insertion(+)