From patchwork Thu Jul 27 07:00:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 13328979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC4BFEB64DD for ; Thu, 27 Jul 2023 07:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0dyXmJXmlrZJrAaGyak4uC9LFJaDvqrDdgyA/0U/aLc=; b=XVUVzWaU/4X3le jmFDKzKB9xQwasNHsEquMsNw7H1r2r+M4wVJpwCKfHsr0qtgy/T69YtfM+Gmql1AaYsqgOroZCZwe RwRgE19IWB3+T21qxZUC7gs6XEkJUIgfBoCaqgspLxLU1uTxh6NdJ6XP/h8xLRSFGobkrENU0vZx4 /OPGDQjDJ0c9PFCHY2W8razmZHiAL4Xx3bsGgKfgwc1GDCKKhxcqm2/Wn1VbL0dowwABvY/rBUDTn iQJOeZw8tJtqXbLGWaAnejAoHN5aNCtubQTmxuhNKaBCMnzA86Bgp2nl+YvZ2n+TKNlUd5BiqSW32 iXZaW6xNR0R2VbUCYJRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOv27-00CPR7-0B; Thu, 27 Jul 2023 07:03:35 +0000 Received: from mail-sgaapc01on20704.outbound.protection.outlook.com ([2a01:111:f400:feab::704] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOv1K-00CP6A-1O; Thu, 27 Jul 2023 07:02:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DNkbUR3uw/2zGpNwd51ncm6P9uPRLCwOHPDWGN26V/CiEYjp01VV5qg4bt2uh91Jz2F5GXQ1Idx2X2o/ID0jKqcQQAvmDkslkBuMGTcpKT6jn5/XoNKPW2zhAmn8eblZMy6d8OFe8UoY+u7jMtGYMLwNJFI3hi5JgcipfOJHmIPbD0QC3Rkz6440agXiVa5r6hp9TvexsvERyR9fcoVCvQ8utK8caIM22Lr5hhhhmOUEOXjEClj9xKtsiGvyCZ26rv6pt5/QVT8CKkiXNuAdVQOxgZXcX86lotGX9qJVpLZ9bG7CCFj1YObUMgewLT9SU68qpaFhn7r8FmjA7doFPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iHKArmtjsh7/y1Aplpgib/ppYsMir3MLAx1CuQ9EKjQ=; b=mwJC9EWYS9DoS3f7h6J8kRSoplv9gjBtU/yVdgF0D/KpEnRpM0sWum0ENdStELoPlnLc3qsXEduOvN16Balz1ucLw+Z7fLTPctPDJdthxmbc3ypB/P8HQ4JgIefFJ2rIbSZXY9VYYJ10o1+4uiMeymvkALY4GRAPlbV/lOKVRYDRr6ViCU7fbBB8r+GIHyHhIYHSY/u8dOx+QtKm/kjddle+i23YLQeVOU+OnPRDv5Y59vf363/z056bQ5tcTzBPLb2TbFqAxbsugAqN4Ux7NarhsbJIU76j8cfBlPLtjYhnvV97MDbwUZ8PU5wjBLwK+MK7k6ErxBDpZtZ/GuoOIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iHKArmtjsh7/y1Aplpgib/ppYsMir3MLAx1CuQ9EKjQ=; b=I7+NvsVgIIfF0xhp3teWQOmx2AqrwEgMHt6jK5sXHMLqRh2O4nAARXqGy/yOi/ScmaFkjVJlk6AZaO4dHTySz4VWIikbdDaCue0qSSguWbpIvV22ePqbcOLCjjmUYu7p+oNSlFmxpUHuelUkDu66blBTsMcFxwUEP66DQSC+7V8L3upvhqu1YbMlcdAwfSRcCwRVELmhmtoBs0xlclC8E8DJsVHXOQSmfOZdqjQ62DKPwXpvjQ3f0y8W2csZMY4lD17ncTu+4l2bge2BUvSe54NLF6FD5CTjdG4sCc2V0JwJpgtVBGU/phWaWStQ8XRKp9Pc3xXt2YiQipr+FtD2yg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:39 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:39 +0000 From: Yangtao Li To: Jaehoon Chung , Ulf Hansson , Heiko Stuebner Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 41/62] mmc: dw_mmc: rockchip: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:30 +0800 Message-Id: <20230727070051.17778-41-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: e8723842-9120-46da-fb2b-08db8e6f66b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wLinV5srOpqqZU33Ugr6J3sfa0fs1o06ehwMPHlAs5KMFkFQH4OenGd2Eno2hj44vcQq72vg8xYGHPdiAAGxeub2nXkeILYNr/ARg0k7LkBs9zEBN2mIIzCJlsdH5lm+l8uhosnkZwoRQRw9P51DW1CQMvSK5hi0W7jeFp2pQNRuUJQ5Jp9VOeXaORUn/jG6nernblykjHPZdK7YD4E3pYV25wK0rNl/7d8HtZVBNQycaL532Q56uWj2L0nEl2RaWTZ/Ob5/lshd8A4md9Jk7WMg38Dk69yqyb9IX3Hv5OPsYy0CZ06f5JrWbVq098c8YTIGC0+Vz0Kff6hEkwXCOysZjo3v6KDTv5II4q4a8D9vxHPt83ar7gBZs0/5B545p4mVe96ti7T1AEXSmsXKPea8j2nrAMYH4uUj4eSFp9dZSS0xFFQK8YX5ik9vjxHJmo6ErrIAqyH2hnVMFQlsGyfi+/zaTlHYaSLlE5o3D3Wf1z09PO6HLNDS82z/a/1xPoD91H7T/XTnD0HQ+/2VpMNixNeGpAAYWgUu+AI2eXeVwef+HdCVMon5bbQz6HC2PFaHNelDSRrgFYgsb5mjF1dFGD5fkmtFkHPbMjL8crR9fJVGOtzZUIwhMFPKMq7x X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Cy4PfJDsuAy5IPxWV34CMm161ffd?= =?utf-8?q?85Spr7Dg29h7W3Y8+z9yqEtg9I+Jbfg3UVAt/WYnRZGwjcIiA4HGHYgz4Y1GmqWJB?= =?utf-8?q?Wp0PjSIzCwIKorS1YIpZHa7B1BCjX5l+b/w76ZX1+pXY4UWQygUoPIcd1PesWLWlJ?= =?utf-8?q?Q1qEGjDSnALks8l0m1yKfzcnPkvaUSIiHj8PylYa2/ydlmhtiIYkFyAzQP3X5yB5K?= =?utf-8?q?Th1A44AC9pmTg59Ilqga1S4x0+eirC+nhTe8dVQvWE95Yx9YqfS1Umpw5FGj1mKf6?= =?utf-8?q?2mzCkppXFyqdExpr3zxIHpdZouHSrSUDWrnClDFqYmdCcp/sHsXNn9hNPhbApFjpv?= =?utf-8?q?KapXWmn3L8cUtkNNmyHnfMc/dpbRK9Ztq32i2ay19Uh87QGVW5nKAVZr3T+Fqy2Lh?= =?utf-8?q?0vqzptATyBvmD/wmZAEMVS9fAoDJ8Fz4437Okahy8MJDcWLjyNHlyrGo6RxaaNQe4?= =?utf-8?q?2pOWd4B/h1IggEQOFo9TqxjqjIxrlDyoLm5awSbTMjh87/31ILX2GsC2SKSeXR3RH?= =?utf-8?q?ph9JG6CpIxShaTv5XBMERT3BqTf5SvyK91VIALckqlaUkLrvLAOQLHcQoi7zYEO23?= =?utf-8?q?8THYgDdSUmTWrk9SzGMVUZfGNEIcpw8CTRQZn8X0vPew3Tw+K3N2C5sq8ejQzSNEU?= =?utf-8?q?59EMZbZUreMROB1rGJUC3bqB4mWsmzXHlWbgBe3EvdgG/ucKpoeT7VUWtEXmQMa4Y?= =?utf-8?q?vuYIi1g8jLR9D3TkrpxQ5HUiGzWel+uofcRviGQAurN9iPXvAqPr+KknUwCCXQ9XK?= =?utf-8?q?Ajdtl91tcnXOV2oLilMi9EOb85LEIwKfcVw8aphEebJ6vJO4L4GWhrVxEUYVm1u5U?= =?utf-8?q?DFkB13T+PecVp8YkylUFZ3mO9g0pgmwrr1tI9flMuXDonnXq0kl5AsqipCRxA6i/4?= =?utf-8?q?ZZsGSuWpYwNptKUkEne3xs0CHWov1MXxatc+R23R/oouK80EZBJZjq3Omzp6QFLlS?= =?utf-8?q?+hLce/vvahS5QrGOMdWbgY9YguuDH/f4Xe3zTh7P9iPGo2rjHVv9iopqzfiboVhqu?= =?utf-8?q?sQDW7vDLd49SwgTWYDeNsBgudPkAjUcq6RfEb1zooXbBdS6IIe6Y5JQDkMi0I6fyy?= =?utf-8?q?hYq6ho08xM3IjdJ3AIZ2+LaRcSg/mxfQntR6ZUYQkik7v+pP5rDSsIJFIkwU9s9hA?= =?utf-8?q?bsBwPiTEcRW3vb4xhzQ6AonCKoAINaf0fA3V4arDBFpv3+RHvo6R3fzkcTaXspndG?= =?utf-8?q?wFl6PfcqgV+Ru/UhZCv6GyJ1RF63HH93FsBcHSliVysqEJvDJ4aUrVEq9iqYvDWMF?= =?utf-8?q?qLsRDqv0+7ANDlLqt+GrmYnIIp1BMOm+tL1iQhpjxC0zX0BOfa/OveT+yeVCkoD83?= =?utf-8?q?AjZipMOsT/1TXK93GVsfnBINtgYYYc3JNdHSLJJWFxuLRoKumKnhcUb2SQSQOuuhW?= =?utf-8?q?gZmGnmZ9t9A+aQ8HcYDD/Wk5emUAsBhowx2luqIoCcmmDSIuojawgC1bYr8pk2TI+?= =?utf-8?q?GLtfp2ngrkf0PP0RnE5FFgwNoUqPHMLjRYa54S3udRHM5yTZuhwgJ37OBfLnOrhDf?= =?utf-8?q?FlDK4FIcunQ1?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8723842-9120-46da-fb2b-08db8e6f66b6 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:12.0229 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 26g4anAd+SAAekuvTVHAtv4vm6BwI9JrDj2W2abY28EzKuQARV81fVAcfI01Kr+rVSk5NeqWGRsZ0Pj7vSarQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_000246_488509_3B2FD05A X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Heiko Stuebner --- drivers/mmc/host/dw_mmc-rockchip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c index 2a99f15f527f..b07190ba4b7a 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -371,15 +371,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev) return 0; } -static int dw_mci_rockchip_remove(struct platform_device *pdev) +static void dw_mci_rockchip_remove(struct platform_device *pdev) { pm_runtime_get_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); dw_mci_pltfm_remove(pdev); - - return 0; } static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = { @@ -392,7 +390,7 @@ static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = { static struct platform_driver dw_mci_rockchip_pltfm_driver = { .probe = dw_mci_rockchip_probe, - .remove = dw_mci_rockchip_remove, + .remove_new = dw_mci_rockchip_remove, .driver = { .name = "dwmmc_rockchip", .probe_type = PROBE_PREFER_ASYNCHRONOUS,