From patchwork Thu Jul 27 07:00:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 13328976 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48EE4EB64DD for ; Thu, 27 Jul 2023 07:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oNV8cJHr7X0u7GgCNMoQG8LQhfi6M1AMACsNb2FlpNg=; b=2MseMgsG7U29Ms fkuuA8zg0cd52c77ue+JrROymnXgmI+F0z4D5Jg3PYvKyqA5AN+ZiQoRk8FPskRB1wsOhUJ2S608t T4CZ4awgKoCUR6IGNMt/C+ftt3I9EOl561vkIqRNBEK9IFTQKHPyXUH0tWKOQLFtKwflJyqRjNqaB rLfL/T8U7gHdN5ZRDqbofINywyZ35OUH781Co76Gs6swiztlPvM4l7CkbSy8nkjTq+P5PXEuL6shu kZBJgRLj1fytK80ACQaZlThfnzvOU0pu5asEIOTWZVnLdJvSG91z1SN0AGLKdb/FvZ98UFFAMc2ln JtwOXh9K+tHQvh3aPoPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOv27-00CPRW-2S; Thu, 27 Jul 2023 07:03:35 +0000 Received: from mail-sgaapc01on20704.outbound.protection.outlook.com ([2a01:111:f400:feab::704] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOv1M-00CP6A-2z; Thu, 27 Jul 2023 07:02:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+W4wOaOFY4QV8ha/H5a2OUlTE7kyIh7BvPo8NyR53FBuAJh7Y3L8oSrfmOTIs7XdmUjjEXgIvaoG6jbi3t7xRvnjN57Pm15AbA2F/IRIpW0w3MuAOJxN9IndEVntbtK0Cr93Dl0YO2iVt3XwKAjLTHRCfpZlreQ+BAH4Y58lljNfYjRkDm4yOTgtW34DhCR8mx4xoyiXNrp1qHSKESazJIO8EpG6D6I5lA8/PvQYexpdKBxLhdp6s3XZLwm7xFYKGUnLhtVVtt+BU+GGgC6kHGlLlEr8g9p3kRzshW8Zn6DrYI1Za8Udj16A+hNZRyBfzXSkosQmVMmCfJThMbYTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nsecs0FraqEkVI69yYtZuIhcDu7CE/3dvX42vrGL9bQ=; b=KAREA+U05B+5tyqhT/DKSe++TGW841uVniTQML3FeMLVRlSM887Oqi6SNp8I43qu9yPmUM8o0Ajhq6cI+vE8ltrxOHe/b/OsbvCcgahYASF+xOoc3Pv0IV+baXqIY4XZObsWMyEARxbQqWz4hAAU06dw8G5wE0jrTow1fSlm/bcQRLAQSVDDAErqIh29F8ScVNFxzxn5sP5wQjrH3G12s05uOB22Tg2bPemndlvDRw4d3BZKigw6NKO+VmluGw1UOd+V+XZGeSJxx0o+APrkXP1vEt+i3JxzUPTfVFyw8aZ/DtKHa1jWR3SCjehUK1otAW/pz9E5h0WwNVgoMWSn0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nsecs0FraqEkVI69yYtZuIhcDu7CE/3dvX42vrGL9bQ=; b=SJpDNSscgGn6PWwzjTwpLGqUeko3tEesz9Tf2LoaUv8mg8Giz2D/E3EYvEFFu+u/aaMWSTPrdUa1E0e8SnjNuTUV0MUQNmrM4jIckug6BsxQxW/37WJGwauQyxTK7h0jJgpHqhL6Qzun2AIfRllvqeeltTrJ9iRqaAwBpAFBkAu49QLHE5mpX6jZuTYHG588u6RcNzgvyceHt7Dq3oWDDyVF7YTqfqIF6bocV/2+uN9YcrfZy3pG2MzJ3Fwgh41eO7gP+bQN7Wr1glAsG9hZdmABHFUGTSWuhJOaAnEIsNrlqScqMbk51WmVp5D2CBhogfDRB2Hg9BZAdw8cqkYKZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:39 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:39 +0000 From: Yangtao Li To: Ulf Hansson , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 42/62] mmc: owl: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:31 +0800 Message-Id: <20230727070051.17778-42-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 28c76e50-e26f-4ca5-580a-08db8e6f67c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YfB1AJc0MPP5MHwuycoyEHR+iDQEkWI+v5vUws3LjMQJeFc1FJmVCem2IprfvB4ApFl1O4vOtq1aDJ1HNjZL0sAbyimpNgWMB67MxfEKq/B9yewMzAoDm+Wu5xg5oNjYgpYOWAN2w4daJkjjxVNqOegknDn6BNidLrJoQTl49QEFQLwE9VJyAM5fcnJ5j+FTIGeLsAlIYjnKtx+md432flEySwVd2UZuRmTookQTMdxleLjjONohAHmYDvkOdKWGWe2W/XY9aE8nXLStGYTC2KTnmml0AeOt0afz2pVwW4DQzkTg6M5J6/6pJG9/Jh+CDfaq+erZKMhvMCneDmpyz7rX3BUse4lQEqZTMLqaREGVhWuS2fzci8f/gfjNJdVt+aL4GaNk/vczEChfbUQgHgs86SjNrDGmAWfH56RpHE/AUUl1Sf00L2vrNn2pD0uQOVv5iaBDPtu3CY7Q0Jq/m+YsDTRdJ4duYNGIwTDo5K6KjF8sFxsqELlrwiizm+/gg7l8jkZykuYq+qimBVgUWuHdJxg5JmiRXWvdwCHPpiSt//6jHWFJMbVO6PQCR1QylO5Zg/o1x+FIdJq2iCqKHihl11au4pHgERJFBxHAEzOerMEu+fG+UZGnvJAVVyOG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ZbEDTkyqX6eqAwmChevxXRwx6OwH?= =?utf-8?q?/xDtfltAjYMhal8YYFqBH0rtQbN7a1bDcr9KByinDep4Z+giUyY1PaBqhr8sTsY9I?= =?utf-8?q?VgckDVQAKy9eQ5jDpOLEKneQmc1+G/2xo3MJvP50VLjAMMDF7QPkfufUh6L9tS9at?= =?utf-8?q?HunCix8ymXt+kXUUDXqNc5y9icjbFlxGzi1pYX9l65Qb78gwYfx8Li/lTF7CzU3U6?= =?utf-8?q?m/PNb3/apFS8Y/T41KdbmyFjO4IcU53NPheXhCyrufnpcYZHvDpWxwzhPhMr3wccn?= =?utf-8?q?lzuPDBrIDs+SP42CCWs9ob/zPaTD12QjgLVyRFEC84sbFW4wqq3O2sd+FYsADEMOb?= =?utf-8?q?eMEZpqIDIyiDq5LweOR9WbcLbtX2dvQ2Gt9fZgSBeFQsv6vfBXIiSnkwa0yvQONFk?= =?utf-8?q?+wcPhD8wMVZz2QvfHdYchlJytdv2NNGia3bNLvMlKizPj3TxLHHWqaHiMKs21g+KG?= =?utf-8?q?VGRAm7AVYXRx6g4AduogiVv2KmL3s416bs0pEzmzLq3gjsB7aCLHrUC0pPFHr3DN7?= =?utf-8?q?xd326TFOf+6QsBUDkjOV9HWbnEVrHN6p5JYS/GplfT9ZP9T1MSRl4ILD34ipd+XdZ?= =?utf-8?q?wivCjaKKs/znuxsrSHRl2wMbhtn3EMCsZglWbZYn3BGFbKGy+lcisPrnzTrqxfyl5?= =?utf-8?q?Ty88rZ/ouYIXAfVYiskSOlAllAjO6EEVToN9WAYfewHXpzaq18dVEfm6qPSeKzUZD?= =?utf-8?q?JdFClz6iXEtvYftCXWSDi3ya2DLBDJkF4s5ZYKXOhGRnkUMLAvyCWX0Pnfs77qnD0?= =?utf-8?q?J0Vif9Ko+OG6d/atekj9sNSuhMlKgd6R/HjaoA6QdqoXMecB9smNK2I1zvALZtjn6?= =?utf-8?q?rmSs8U8ZncezidIj7pSQQudhADEWGuBYL+9UREyuaM+JmFehIMF6XWg+ZGgT/zRaK?= =?utf-8?q?kHOOT3bqQef+mbEAtk6YrN0/t1d1XJ0qVUUjbxL+1/FvvJ7R5BaEyNvavaaHiAFqA?= =?utf-8?q?kIGyFwDyBFKa1VkHi+Oue99VxPcS/bJLnnJNeA1tEQLBldWOCGbhfntFiUpsrIf7d?= =?utf-8?q?CGPVgnWTAmRuVMN7nzNyjJ6SiTEQl8J4SCCOvOdNmdq8z84HES1vbNd89SrGMiPk6?= =?utf-8?q?ljwCG2FL7mKARTqAXR+ksGznO+R/MvTHDvSb5zdtfVEHCkSAfLZTNAd1QnnsE740b?= =?utf-8?q?ygfJWLYhUMv5V8ty7lXLRBGXl+OKFEa2XfgoW3L6Sm5s9Ho9l/rptyuXrZbzwujGF?= =?utf-8?q?ca+yV9vJRJ3uGSavscvS6Su2dzROR0UYlpPtTIrO+doqI9s1jnZQYA2EAUbjMoMDF?= =?utf-8?q?SMgkJe7Hpjgd4Kk4gdR8W2JpsoFiGYhQC4x2G4tVx13seMVtAtXtHEzabIdcKqEzL?= =?utf-8?q?ct6HqC2EpDea3Ll2xX+pW4uZWuuN97BN8Cwj3MgEstUxyM3jgBXd3ibB2OY5MKmoV?= =?utf-8?q?PSNin2crPGg7trl5pn6RPfvHbSLgMwTd1iGIkaKaVHSMjExOnd242gE9GSO98K250?= =?utf-8?q?ddA5eKWcEEypkkgx9klLuWeSDdb4NbCC0UgDEKbNsnB1NS5cpVM1sKRVEnFokoH8a?= =?utf-8?q?LXROrgwUnczp?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28c76e50-e26f-4ca5-580a-08db8e6f67c4 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:13.8041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z0Ppk7iH/bTRIwn6RdZ8PFRkpk6rwICObsKp/QHpB/wqXB1KNt3fxTFGN/iJlaMfQmMgYOGruTtDr592va7Zgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_000248_993139_B1996D2B X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/owl-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c index 1bf22b08b373..a13bec42554a 100644 --- a/drivers/mmc/host/owl-mmc.c +++ b/drivers/mmc/host/owl-mmc.c @@ -667,7 +667,7 @@ static int owl_mmc_probe(struct platform_device *pdev) return ret; } -static int owl_mmc_remove(struct platform_device *pdev) +static void owl_mmc_remove(struct platform_device *pdev) { struct mmc_host *mmc = platform_get_drvdata(pdev); struct owl_mmc_host *owl_host = mmc_priv(mmc); @@ -676,8 +676,6 @@ static int owl_mmc_remove(struct platform_device *pdev) disable_irq(owl_host->irq); dma_release_channel(owl_host->dma); mmc_free_host(mmc); - - return 0; } static const struct of_device_id owl_mmc_of_match[] = { @@ -693,7 +691,7 @@ static struct platform_driver owl_mmc_driver = { .of_match_table = owl_mmc_of_match, }, .probe = owl_mmc_probe, - .remove = owl_mmc_remove, + .remove_new = owl_mmc_remove, }; module_platform_driver(owl_mmc_driver);