Message ID | 20230727070051.17778-58-frank.li@vivo.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAC41C001E0 for <linux-arm-kernel@archiver.kernel.org>; Thu, 27 Jul 2023 07:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LTKhsM/+yQdnIQn/Aa2VkSzK0TjgmtMWgyTD49fxcfk=; b=gcgRbsdydTU4kY bfizX3CMtQeBVKBCslGNNs9UehJzamkFIAsa/2UwWw8QiYXY7EcX1x0tF9JLLFNIfJNrNYr2KGrVR xvNCYNX7afsHwp0r7YAV++cPUTDRz4Q5z0+hxQpyo0Awu3X1GjRsEzsUev5mVbc6VI8Gj9W5els/J sGGFc2mquHlqTxJAtJNTZ4GP8FvMqrWF0ITWzUHjP0Kc0UrB3I5pB8p7WwFESdlIu6r3wEoJ5IjBs QJBokp096EZ/9EQrIOR/xT7PbSEkF+J4hOclkaZk6M38qT401GViY1S88x9Ah+mWSTDGMpMqZ6N5g jMZgpj8GjpLNHUY74nbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOv29-00CPSb-1p; Thu, 27 Jul 2023 07:03:37 +0000 Received: from mail-sgaapc01on2070e.outbound.protection.outlook.com ([2a01:111:f400:feab::70e] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOv1T-00CPCt-3C for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 07:02:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QrMGg0VoNOb5BL9E4PkFmGzJ6fs3b8malkIC9PyGqMJlsHrOKAfYcDBYr0XwLf2t8wUA0reCMqOy/WbMFHYAi1ptnNzYWsoQwS02380IX75xdy2GUdIregF3JiAWX9sXmWibFQFjMgDslxJbwQ3UPbDU7Kh7arzhapc71FxtioCYkqW0/kO03KFNgqGLKKjj9P/LGUKTF1nFMR8E72uBdfZQChIDouBGz6k8+WpQq61mjtM3ZZKhpg4xbH1tWyyre9E0Jre8jsXVxVtcrGtHILtt/rJGMV6EyI8RxlZ2hqObr1j/Ir/78qfwppAcGcdCt37wsdl+pYPeD+W+V8lgSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=MeeaEKrXaEshNhaf4YMer+1fIeDuPs1WJrBEl9w1Z4MIm9oL6GyiJPZPB9zfvm0pEzJtWCTviMeBjkjjolVIZ5meASObCqsVe2fa1LCalGump+qqrEyHJGWTCty5aAvigQf8uc6fAuxshMpHFEYNjegZcq5Aif5tcYTCRgORFftYqVG9Xwz7bcObDa+a3tyrDzmL+Bz17KpNLpPSl7kl6iE7rMCtjPi25GUkPGaxt/6ihy4XATGR/N+m0Fg5owfeUnTIFySpjkyTi5MvZmYxcTq+04eVxNoq9vhrQ/+QXCIiz86+pPC6H1l+02dJCXE3hVr89ggCX6crGRw/fvCHvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=X4uEj3J0X9lAfGTbA5/KCkv9O6ofhqPNtdRH6syxfSj2Rfh07FiAg1Ubxj0GKIJ3WXEj1DO29pWpdMqcVFFbNJbDWlk2woN/J27+sZhjqoO6iShRyrEJ6fF/xSesCLML20KSilQnYPTDQy+58K6bUP3VqmCow2FBlIyV+LoDefrFVRI42UGVe9GN3tFKXjppt4PAGGoAED8ntAvfm+wkI01svaLra37vwZZ1PGPbltluO+6D+1ML3TfhPkXJ4enmMU6Dx9bPihhBbvZMWlms/6GmeM/5ofvO9gv3lNNgD1Pl3BvKBZj9ktpk03KEyX4F40X/wR1I43VQS7Z+5MP8vg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PSAPR06MB4152.apcprd06.prod.outlook.com (2603:1096:301:34::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:46 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:46 +0000 From: Yangtao Li <frank.li@vivo.com> To: Ulf Hansson <ulf.hansson@linaro.org>, Kunihiko Hayashi <hayashi.kunihiko@socionext.com>, Masami Hiramatsu <mhiramat@kernel.org> Cc: Yangtao Li <frank.li@vivo.com>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 58/62] mmc: uniphier-sd: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:47 +0800 Message-Id: <20230727070051.17778-58-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PSAPR06MB4152:EE_ X-MS-Office365-Filtering-Correlation-Id: f64abb1d-ee8b-46c9-c092-08db8e6f78b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hzCw2saiXh5oij8OiezOTxeXiP66wLtzh2CijXgl3EuxhEXJAw6cUAgzahhs1pT3dlzPrgt0fvq+ExwVaNPPAeVIJAXvXrlqIF9gqXGATks1qAFuJ5G9NJeON6W3f0A4BrR/OdOBP6DWMF3L8zNmzU2kxy5KgfxI8MBsqjL5Pdw0Zry74P+BwRut70MgYDgBWvD1wuIcBT/84OzxCIA7N30ghOKlFmHX9FD2IkCku3taWqQ1hTPdTr4UsRNtdxSudO+6giexUZwguuSxVDGzIA+aVKXuG3DvUhfD4DD6SFMMLFjjEmXdlAdl55PNAPnGSbGJXmYIxp9YttMc9THY2j3PsiYYit6dq+7yMRlauw9PZ5VFebs//s77RhZqJxxj5GsxQ141vH855hq/vhvhXRTpkB1YEceVdjJiquvTleD2pi22mQK39v3btyIMMVK7QJt3tKGLS8WqGerhpHJWw1x8AMjTbE+6ZREmXR62BSvBtBAu3Nk2E9c/4Qs69cF0Sci+aVWvPY5YMyI+88QdkRWUbz3a7fOf4PsazMAaC4QzUiLL5Ob34DgPTaHEj1dXJsFSRFbM3xzOf4XHFmstxV/eZTrmBKxsW6KaxhZx0vdMiZ2bKwftU/efZEjC6vyS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(136003)(39850400004)(346002)(376002)(451199021)(6486002)(478600001)(52116002)(83380400001)(26005)(1076003)(6506007)(6512007)(38350700002)(38100700002)(66556008)(66946007)(4326008)(54906003)(66476007)(110136005)(186003)(2616005)(5660300002)(316002)(8936002)(8676002)(2906002)(41300700001)(86362001)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?5gu0n/9CYi6dFrWw9e8kFXgQWCuk?= =?utf-8?q?85DubcPVnkoECNN6nJ2Pmz3R9+Bg6Za8G8zap6fPRDK/cZznqP9UGB6KR7Dby0oDg?= =?utf-8?q?xsEGHNdYsPpWkKkdgwY2K9ueF3CoHuY2vxw4PNJ7Ib9KB/JGwDSvYhR0nlR5f3mJL?= =?utf-8?q?JbKOG7+qApA+CxHlJqFZ0p2BR2oKqPJjGPed7b9iFCMXRCsRMjA1cgPKKTbk11KdU?= =?utf-8?q?j/6tznTUKC378tMovhLYrpXxZAuIY/tMHYShJcqozTrSP2jM/DRRDUyaRQ10S5cjP?= =?utf-8?q?/XHu4WwMuz7sK8NxxAYp/DQn8dPnlBuyM14+RfYHsli014FXW1r4ZttdkgMFiruZw?= =?utf-8?q?j0PxBn7mbwFEzfrY7SBZMVUsXWOqrtB9VaKqFtr8v64/UR62WRmKcBuN5Hb0CxJru?= =?utf-8?q?pEovdtn7QWCnQnN5CSYTzVywAveekn6F5DEOrqCj+l/22OReVfD9c6L+bsXbcJ5uO?= =?utf-8?q?sHuXHskprg1Eq2ZTlJzbNdQzF+kyMcZcjh78fYtWcAk3u5UPn4r33jJydcrkl3frG?= =?utf-8?q?eu/p8LvILdZF6SGFncnWOBsYylO23rcfVPeQc+0zONP17pGj+6FrLj9M3v6j7KBh2?= =?utf-8?q?50J1NnktJ9iIgjZo+cuIGKelxU9zGwLCZ0mi1CijqAQDQpNi6Ae4C8sTtoGDeFnX9?= =?utf-8?q?2AvlhkCG9xC6y3wQizUxjBP+l9LTrmN+DNxb/D3OuJka+JRzzIuKKrC+8+N0N7STc?= =?utf-8?q?zSzP7D0Aev3gTSALcgVrrOuhqpetum69/mT8DQcjolc218tb1lAyhIwV02ZD9Prs3?= =?utf-8?q?XS4f3V5ZHEOWOkfdHWvsanZiNuN+TCmOMxShkqhZGRGEQpromYKCRHcZGV7+EuO3b?= =?utf-8?q?9pYBedZ0cyNLoQ8sxi3FYyCY2NFmPwsl2/Vyec/5qXtqWV+p4Iv/O0pjdz+wXVcjR?= =?utf-8?q?5TvgMEH47mtBDVGFIaNej9Q+vi3cRQuWufaTRQ1yfOff+vn+f3uJE3OayPiFOLqB7?= =?utf-8?q?n7hC4Z5ROx9Q1YE+o/Bh27p1Rxd+Wk/IDLsI5Av3oWQKXr2cdJy6CzpE0umYddDtk?= =?utf-8?q?PYbe4jQhSd/8pw+Mi6loNWApzclle//vR8TyIMDA8JUQMQkBYGX6TgMLsVXhlRraa?= =?utf-8?q?Owqs75e9aUqV0eTnb9C6hW0l7FKp6R9J+vsiwiE79RYYkX0KkWunKp/aJCkRy2Za0?= =?utf-8?q?KEsdGz1/BCsdKaz77NzkmMienKDT6nSKENAyOvPGBz6RpI3BV6+R6EoL8i5FOnuPz?= =?utf-8?q?Dk/RiiUM8Swq8YXH/K2vJn8g79KQQqW7RqQ97n7UUXO+l0/YYf2y24Z4RMw29Y03R?= =?utf-8?q?7R1pacy6O3m0x0mC9J4H6EhggVRG72s+g6XxX5DouoKQTJiMmxI07AcHC80G0zJMW?= =?utf-8?q?bGRHTUXZccK83zkknEYrtWw8HzHFWRzS8z7ExVt8utaY992L/2VxaX7t0uhZS0CKL?= =?utf-8?q?/ee2YuLs6H/J4GUOcgSZ8HQ82wqzQHJC/h39yvNMdebHhzjgwpHVdHcEkW9BG/gAl?= =?utf-8?q?iIQmIv2JlC+HyUkS1PIN2YggP0737f8phKq0TFCBcIoHyRq5T2ei7nES1d2cY+n6d?= =?utf-8?q?KUwIvljWi+Uk?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f64abb1d-ee8b-46c9-c092-08db8e6f78b6 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:42.2000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /248dpgNnj3tYJb7auMysIoahVR1WPleQWcFUJpMOe4B2EdSbPJEhzYPlznDTuSD2QjVjefggUnPOV6nPWhSFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4152 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_000256_035133_6A41698D X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
[v3,01/62] mmc: sunxi: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 61acd69fac0e..33a4d1c6ef04 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -727,15 +727,13 @@ static int uniphier_sd_probe(struct platform_device *pdev) return ret; } -static int uniphier_sd_remove(struct platform_device *pdev) +static void uniphier_sd_remove(struct platform_device *pdev) { struct tmio_mmc_host *host = platform_get_drvdata(pdev); tmio_mmc_host_remove(host); uniphier_sd_clk_disable(host); tmio_mmc_host_free(host); - - return 0; } static const struct of_device_id uniphier_sd_match[] = { @@ -757,7 +755,7 @@ MODULE_DEVICE_TABLE(of, uniphier_sd_match); static struct platform_driver uniphier_sd_driver = { .probe = uniphier_sd_probe, - .remove = uniphier_sd_remove, + .remove_new = uniphier_sd_remove, .driver = { .name = "uniphier-sd", .probe_type = PROBE_PREFER_ASYNCHRONOUS,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/mmc/host/uniphier-sd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)