| Message ID | 20230727080656.3828397-1-lukma@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps property for port5 | expand |
On 27.07.2023 11:06, Lukasz Majewski wrote: > Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) shows > following device warning: > > 'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on "phy-mode" property, please update device tree to specify "rx-internal-delay-ps" and "tx-internal-delay-ps"' > > This is not critical, as KSZ driver by itself assigns default value of > tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode). > > However, to avoid extra warnings in logs - the missing 'tx-internal-delay-ps' > has been specified with the default value of 2000 ps. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Applied to at91-dt, thanks!
Dear Community, > Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) > shows following device warning: > > 'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on > "phy-mode" property, please update device tree to specify > "rx-internal-delay-ps" and "tx-internal-delay-ps"' > > This is not critical, as KSZ driver by itself assigns default value of > tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode). > > However, to avoid extra warnings in logs - the missing > 'tx-internal-delay-ps' has been specified with the default value of > 2000 ps. > Gentle ping on this patch. Claudiu, could you pick it as well? > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts > b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index > 99cd6d15998b..b66570080894 100644 --- > a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++ > b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -152,6 > +152,7 @@ label = "cpu"; > ethernet = <&macb0>; > phy-mode = "rgmii-txid"; > + tx-internal-delay-ps = <2000>; > > fixed-link { > speed = <1000>; Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hi, Lukasz, On 8/24/23 12:17, Lukasz Majewski wrote: > Dear Community, > >> Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) >> shows following device warning: >> >> 'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on >> "phy-mode" property, please update device tree to specify >> "rx-internal-delay-ps" and "tx-internal-delay-ps"' >> >> This is not critical, as KSZ driver by itself assigns default value of >> tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode). >> >> However, to avoid extra warnings in logs - the missing >> 'tx-internal-delay-ps' has been specified with the default value of >> 2000 ps. >> > > Gentle ping on this patch. > > Claudiu, could you pick it as well? It's already in arm-soc: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/arch/arm/boot/dts/microchip?h=for-next
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index 99cd6d15998b..b66570080894 100644 --- a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++ b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -152,6 +152,7 @@ label = "cpu"; ethernet = <&macb0>; phy-mode = "rgmii-txid"; + tx-internal-delay-ps = <2000>; fixed-link { speed = <1000>;
Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) shows following device warning: 'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on "phy-mode" property, please update device tree to specify "rx-internal-delay-ps" and "tx-internal-delay-ps"' This is not critical, as KSZ driver by itself assigns default value of tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode). However, to avoid extra warnings in logs - the missing 'tx-internal-delay-ps' has been specified with the default value of 2000 ps. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 1 + 1 file changed, 1 insertion(+)