| Message ID | 20230801111151.6546-1-mihai.sain@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity | expand |
Hey, On Tue, Aug 01, 2023 at 02:11:50PM +0300, Mihai Sain wrote: > From: Andrei Simion <andrei.simion@microchip.com> > > Document device tree binding of SAMA5D29 Curiosity, from Microchip. > > Reviewed-by: Mihai Sain <mihai.sain@microchip.com> > Signed-off-by: Andrei Simion <andrei.simion@microchip.com> Your SoB is missing from here. > --- > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > index dfb8fd089197..89d75fbb1de4 100644 > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > @@ -79,6 +79,13 @@ properties: > - const: atmel,sama5d2 > - const: atmel,sama5 > > + - description: Microchip SAMA5D29 Curiosity > + items: > + - const: microchip,sama5d29-curiosity > + - const: atmel,sama5d29 > + - const: atmel,sama5d2 > + - const: atmel,sama5 What is the benefit of adding the two familial compatibles? Is there software that actually uses these? Thanks, Conor. > + > - items: > - const: atmel,sama5d27 > - const: atmel,sama5d2 > -- > 2.41.0 >
Hi Conor, Please find bellow my answers. Hey, On Tue, Aug 01, 2023 at 02:11:50PM +0300, Mihai Sain wrote: > From: Andrei Simion <andrei.simion@microchip.com> > > Document device tree binding of SAMA5D29 Curiosity, from Microchip. > > Reviewed-by: Mihai Sain <mihai.sain@microchip.com> > Signed-off-by: Andrei Simion <andrei.simion@microchip.com> Your SoB is missing from here. Sure, I will add my SoB. > --- > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > index dfb8fd089197..89d75fbb1de4 100644 > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > @@ -79,6 +79,13 @@ properties: > - const: atmel,sama5d2 > - const: atmel,sama5 > > + - description: Microchip SAMA5D29 Curiosity > + items: > + - const: microchip,sama5d29-curiosity > + - const: atmel,sama5d29 > + - const: atmel,sama5d2 > + - const: atmel,sama5 What is the benefit of adding the two familial compatibles? Is there software that actually uses these? Thanks, Conor. Currently there is no software. In this file we've just documented the previous boards from sam9, sama5, sama7 MPUs. Thanks, Mihai > + > - items: > - const: atmel,sama5d27 > - const: atmel,sama5d2 > -- > 2.41.0 >
On Wed, Aug 02, 2023 at 12:42:52PM +0000, Mihai.Sain@microchip.com wrote: > On Tue, Aug 01, 2023 at 02:11:50PM +0300, Mihai Sain wrote: > > --- > > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > index dfb8fd089197..89d75fbb1de4 100644 > > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > @@ -79,6 +79,13 @@ properties: > > - const: atmel,sama5d2 > > - const: atmel,sama5 > > > > + - description: Microchip SAMA5D29 Curiosity > > + items: > > + - const: microchip,sama5d29-curiosity > > + - const: atmel,sama5d29 > > + - const: atmel,sama5d2 > > + - const: atmel,sama5 > > What is the benefit of adding the two familial compatibles? Is there software that actually uses these? > > Thanks, > Conor. > > Currently there is no software. > In this file we've just documented the previous boards from sam9, sama5, sama7 MPUs. Please fix your quoting. If no software cares about this, what is the benefit of adding familial compatibles?
On 01/08/2023 at 17:35, Conor Dooley wrote: >> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml >> index dfb8fd089197..89d75fbb1de4 100644 >> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml >> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml >> @@ -79,6 +79,13 @@ properties: >> - const: atmel,sama5d2 >> - const: atmel,sama5 >> >> + - description: Microchip SAMA5D29 Curiosity >> + items: >> + - const: microchip,sama5d29-curiosity >> + - const: atmel,sama5d29 >> + - const: atmel,sama5d2 >> + - const: atmel,sama5 > What is the benefit of adding the two familial compatibles? Is there > software that actually uses these? "atmel,sama5d2" is used by arch/arm/mach-at91/sama5.c file "atmel,sama5" is used by drivers/soc/atmel/soc.c file, so yes they are needed to instantiate a sama5d29 SoC. Best regards, Nicolas
On Mon, Sep 11, 2023 at 05:03:07PM +0200, Nicolas Ferre wrote: > On 01/08/2023 at 17:35, Conor Dooley wrote: > > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > > index dfb8fd089197..89d75fbb1de4 100644 > > > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > > @@ -79,6 +79,13 @@ properties: > > > - const: atmel,sama5d2 > > > - const: atmel,sama5 > > > + - description: Microchip SAMA5D29 Curiosity > > > + items: > > > + - const: microchip,sama5d29-curiosity > > > + - const: atmel,sama5d29 > > > + - const: atmel,sama5d2 > > > + - const: atmel,sama5 > > What is the benefit of adding the two familial compatibles? Is there > > software that actually uses these? > > "atmel,sama5d2" is used by arch/arm/mach-at91/sama5.c file > "atmel,sama5" is used by drivers/soc/atmel/soc.c file, so yes they are > needed to instantiate a sama5d29 SoC. Okay. Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml index dfb8fd089197..89d75fbb1de4 100644 --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml @@ -79,6 +79,13 @@ properties: - const: atmel,sama5d2 - const: atmel,sama5 + - description: Microchip SAMA5D29 Curiosity + items: + - const: microchip,sama5d29-curiosity + - const: atmel,sama5d29 + - const: atmel,sama5d2 + - const: atmel,sama5 + - items: - const: atmel,sama5d27 - const: atmel,sama5d2