| Message ID | 20230802093156.975743-1-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [net-next] net: microchip: vcap api: Use ERR_CAST() in vcap_decode_rule() | expand |
On Wed, Aug 02, 2023 at 05:31:56PM +0800, Li Zetao wrote: > There is a warning reported by coccinelle: > > ./drivers/net/ethernet/microchip/vcap/vcap_api.c:2399:9-16: WARNING: > ERR_CAST can be used with ri > > Use ERR_CAST instead of ERR_PTR + PTR_ERR to simplify the > conversion process. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Wed, 2 Aug 2023 17:31:56 +0800 you wrote: > There is a warning reported by coccinelle: > > ./drivers/net/ethernet/microchip/vcap/vcap_api.c:2399:9-16: WARNING: > ERR_CAST can be used with ri > > Use ERR_CAST instead of ERR_PTR + PTR_ERR to simplify the > conversion process. > > [...] Here is the summary with links: - [net-next] net: microchip: vcap api: Use ERR_CAST() in vcap_decode_rule() https://git.kernel.org/netdev/net-next/c/58e701264f15 You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c b/drivers/net/ethernet/microchip/vcap/vcap_api.c index a418ad8e8770..a7b43f99bc80 100644 --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c @@ -2396,7 +2396,7 @@ struct vcap_rule *vcap_decode_rule(struct vcap_rule_internal *elem) ri = vcap_dup_rule(elem, elem->state == VCAP_RS_DISABLED); if (IS_ERR(ri)) - return ERR_PTR(PTR_ERR(ri)); + return ERR_CAST(ri); if (ri->state == VCAP_RS_DISABLED) goto out;
There is a warning reported by coccinelle: ./drivers/net/ethernet/microchip/vcap/vcap_api.c:2399:9-16: WARNING: ERR_CAST can be used with ri Use ERR_CAST instead of ERR_PTR + PTR_ERR to simplify the conversion process. Signed-off-by: Li Zetao <lizetao1@huawei.com> --- drivers/net/ethernet/microchip/vcap/vcap_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)