diff mbox series

[-next] pinctrl: stmfx: Do not check for 0 return after calling platform_get_irq()

Message ID 20230803094304.733371-1-ruanjinjie@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] pinctrl: stmfx: Do not check for 0 return after calling platform_get_irq() | expand

Commit Message

Jinjie Ruan Aug. 3, 2023, 9:43 a.m. UTC 
Since commit ce753ad1549c ("platform: finally disallow IRQ0 in
platform_get_irq() and its ilk"), there is no possible for
platform_get_irq() to return 0. Use the return value
from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/pinctrl/pinctrl-stmfx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Linus Walleij Aug. 10, 2023, 8:11 a.m. UTC | #1 
On Thu, Aug 3, 2023 at 11:44 AM Ruan Jinjie <ruanjinjie@huawei.com> wrote:

> Since commit ce753ad1549c ("platform: finally disallow IRQ0 in
> platform_get_irq() and its ilk"), there is no possible for
> platform_get_irq() to return 0. Use the return value
> from platform_get_irq().
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Patch applied.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index ab23d7ac3107..0974bbf57b54 100644
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -659,8 +659,8 @@  static int stmfx_pinctrl_probe(struct platform_device *pdev)
 	}
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq <= 0)
-		return -ENXIO;
+	if (irq < 0)
+		return irq;
 
 	mutex_init(&pctl->lock);