diff mbox series

[v2,2/5] dt-bindings: net: Add iep property in ICSSG dt binding

Message ID 20230807110048.2611456-3-danishanwar@ti.com (mailing list archive)
State New, archived
Headers show
Series Introduce IEP driver and packet timestamping support | expand

Commit Message

MD Danish Anwar Aug. 7, 2023, 11 a.m. UTC
Add iep node in ICSSG driver dt binding document.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Roger Quadros Aug. 8, 2023, 10:42 a.m. UTC | #1
On 07/08/2023 14:00, MD Danish Anwar wrote:
> Add iep node in ICSSG driver dt binding document.

s/iep/IEP here and in subject
s/dt/DT here and in subject

> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> index 8ec30b3eb760..36870238f92f 100644
> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> @@ -52,6 +52,12 @@ properties:
>      description:
>        phandle to MII_RT module's syscon regmap
>  
> +  ti,iep:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    maxItems: 2
> +    description:
> +      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
> +
>    interrupts:
>      maxItems: 2
>      description:
> @@ -155,6 +161,7 @@ examples:
>                      "tx1-0", "tx1-1", "tx1-2", "tx1-3",
>                      "rx0", "rx1";
>          ti,mii-g-rt = <&icssg2_mii_g_rt>;
> +        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
>          interrupt-parent = <&icssg2_intc>;
>          interrupts = <24 0 2>, <25 1 3>;
>          interrupt-names = "tx_ts0", "tx_ts1";
Anwar, Md Danish Aug. 8, 2023, 12:53 p.m. UTC | #2
On 08/08/23 4:12 pm, Roger Quadros wrote:
> 
> 
> On 07/08/2023 14:00, MD Danish Anwar wrote:
>> Add iep node in ICSSG driver dt binding document.
> 
> s/iep/IEP here and in subject
> s/dt/DT here and in subject
> 

Sure Roger, will do this.

>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> index 8ec30b3eb760..36870238f92f 100644
>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> @@ -52,6 +52,12 @@ properties:
>>      description:
>>        phandle to MII_RT module's syscon regmap
>>  
>> +  ti,iep:
>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>> +    maxItems: 2
>> +    description:
>> +      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
>> +
>>    interrupts:
>>      maxItems: 2
>>      description:
>> @@ -155,6 +161,7 @@ examples:
>>                      "tx1-0", "tx1-1", "tx1-2", "tx1-3",
>>                      "rx0", "rx1";
>>          ti,mii-g-rt = <&icssg2_mii_g_rt>;
>> +        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
>>          interrupt-parent = <&icssg2_intc>;
>>          interrupts = <24 0 2>, <25 1 3>;
>>          interrupt-names = "tx_ts0", "tx_ts1";
>
Rob Herring (Arm) Aug. 21, 2023, 4:01 p.m. UTC | #3
On Mon, Aug 07, 2023 at 04:30:45PM +0530, MD Danish Anwar wrote:
> Add iep node in ICSSG driver dt binding document.

Why?

Bindings are for h/w, not drivers. You are adding a property, not a 
node. Would be nice to know what 'iep' is without having to look at the 
diff (e.g. when running 'git log').

> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> index 8ec30b3eb760..36870238f92f 100644
> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> @@ -52,6 +52,12 @@ properties:
>      description:
>        phandle to MII_RT module's syscon regmap
>  
> +  ti,iep:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array

phandle-array really means matrix, so you need to fully describe the 
items constraints.

> +    maxItems: 2

2 phandles or 1 phandle and 1 arg? Looks like the former from the 
example, so:

maxItems: 2
items:
  maxItems: 1

> +    description:
> +      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
> +
>    interrupts:
>      maxItems: 2
>      description:
> @@ -155,6 +161,7 @@ examples:
>                      "tx1-0", "tx1-1", "tx1-2", "tx1-3",
>                      "rx0", "rx1";
>          ti,mii-g-rt = <&icssg2_mii_g_rt>;
> +        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
>          interrupt-parent = <&icssg2_intc>;
>          interrupts = <24 0 2>, <25 1 3>;
>          interrupt-names = "tx_ts0", "tx_ts1";
> -- 
> 2.34.1
>
Anwar, Md Danish Aug. 22, 2023, 9:59 a.m. UTC | #4
Hi Rob,

On 21/08/23 9:31 pm, Rob Herring wrote:
> On Mon, Aug 07, 2023 at 04:30:45PM +0530, MD Danish Anwar wrote:
>> Add iep node in ICSSG driver dt binding document.
> 
> Why?
> 
> Bindings are for h/w, not drivers. You are adding a property, not a 

I will change the above to "Add IEP property in ICSSG hardware DT binding
document."

> node. Would be nice to know what 'iep' is without having to look at the 
> diff (e.g. when running 'git log').
> 

Sure, I will provide description of IEP in the commit message.

>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> index 8ec30b3eb760..36870238f92f 100644
>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> @@ -52,6 +52,12 @@ properties:
>>      description:
>>        phandle to MII_RT module's syscon regmap
>>  
>> +  ti,iep:
>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> 
> phandle-array really means matrix, so you need to fully describe the 
> items constraints.
> 
>> +    maxItems: 2
> 
> 2 phandles or 1 phandle and 1 arg? Looks like the former from the 

It's 2 phandles.

> example, so:
> 
> maxItems: 2
> items:
>   maxItems: 1
> 

Sure, I will change the item constraints to above.

>> +    description:
>> +      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
>> +
>>    interrupts:
>>      maxItems: 2
>>      description:
>> @@ -155,6 +161,7 @@ examples:
>>                      "tx1-0", "tx1-1", "tx1-2", "tx1-3",
>>                      "rx0", "rx1";
>>          ti,mii-g-rt = <&icssg2_mii_g_rt>;
>> +        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
>>          interrupt-parent = <&icssg2_intc>;
>>          interrupts = <24 0 2>, <25 1 3>;
>>          interrupt-names = "tx_ts0", "tx_ts1";
>> -- 
>> 2.34.1
>>
Anwar, Md Danish Aug. 22, 2023, 10:55 a.m. UTC | #5
Hi Rob,

On 22/08/23 3:29 pm, Md Danish Anwar wrote:
> Hi Rob,
> 
> On 21/08/23 9:31 pm, Rob Herring wrote:
>> On Mon, Aug 07, 2023 at 04:30:45PM +0530, MD Danish Anwar wrote:
>>> Add iep node in ICSSG driver dt binding document.
>>
>> Why?
>>
>> Bindings are for h/w, not drivers. You are adding a property, not a 
> 
> I will change the above to "Add IEP property in ICSSG hardware DT binding
> document."
> 
>> node. Would be nice to know what 'iep' is without having to look at the 
>> diff (e.g. when running 'git log').
>>
> 
> Sure, I will provide description of IEP in the commit message.
> 

I will change the commit message to below.

    dt-bindings: net: Add IEP property in ICSSG

    Add IEP property in ICSSG hardware DT binding document.
    ICSSG uses IEP (Industrial Ethernet Peripheral) to support timestamping
    of ethernet packets, PTP and PPS.

Please let me know if this looks OK to you.

>>>
>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>> ---
>>>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> index 8ec30b3eb760..36870238f92f 100644
>>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> @@ -52,6 +52,12 @@ properties:
>>>      description:
>>>        phandle to MII_RT module's syscon regmap
>>>  
>>> +  ti,iep:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>>
>> phandle-array really means matrix, so you need to fully describe the 
>> items constraints.
>>
>>> +    maxItems: 2
>>
>> 2 phandles or 1 phandle and 1 arg? Looks like the former from the 
> 
> It's 2 phandles.
> 
>> example, so:
>>
>> maxItems: 2
>> items:
>>   maxItems: 1
>>
> 
> Sure, I will change the item constraints to above.
> 
>>> +    description:
>>> +      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
>>> +
>>>    interrupts:
>>>      maxItems: 2
>>>      description:
>>> @@ -155,6 +161,7 @@ examples:
>>>                      "tx1-0", "tx1-1", "tx1-2", "tx1-3",
>>>                      "rx0", "rx1";
>>>          ti,mii-g-rt = <&icssg2_mii_g_rt>;
>>> +        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
>>>          interrupt-parent = <&icssg2_intc>;
>>>          interrupts = <24 0 2>, <25 1 3>;
>>>          interrupt-names = "tx_ts0", "tx_ts1";
>>> -- 
>>> 2.34.1
>>>
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
index 8ec30b3eb760..36870238f92f 100644
--- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
+++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
@@ -52,6 +52,12 @@  properties:
     description:
       phandle to MII_RT module's syscon regmap
 
+  ti,iep:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    maxItems: 2
+    description:
+      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
+
   interrupts:
     maxItems: 2
     description:
@@ -155,6 +161,7 @@  examples:
                     "tx1-0", "tx1-1", "tx1-2", "tx1-3",
                     "rx0", "rx1";
         ti,mii-g-rt = <&icssg2_mii_g_rt>;
+        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
         interrupt-parent = <&icssg2_intc>;
         interrupts = <24 0 2>, <25 1 3>;
         interrupt-names = "tx_ts0", "tx_ts1";