diff mbox series

[v2,2/3] dt-bindings: rng: meson: add meson-rng-s4 compatible

Message ID 20230807130611.63914-3-avromanov@sberdevices.ru (mailing list archive)
State New, archived
Headers show
Series Meson S4 HW RNG Support | expand

Commit Message

Alexey Romanov Aug. 7, 2023, 1:06 p.m. UTC
Now the driver has a separate algo for S4 SoC.

Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
---
 Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley Aug. 8, 2023, 12:09 p.m. UTC | #1
On Mon, Aug 07, 2023 at 04:06:10PM +0300, Alexey Romanov wrote:
> Now the driver has a separate algo for S4 SoC.
> 
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
> index 457a6e43d810..afa52af442a7 100644
> --- a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
> +++ b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
> @@ -14,6 +14,7 @@ properties:
>    compatible:
>      enum:
>        - amlogic,meson-rng
> +      - amlogic,meson-s4-rng
>  
>    reg:
>      maxItems: 1
> -- 
> 2.38.1
>
Conor Dooley Aug. 8, 2023, 12:11 p.m. UTC | #2
On Tue, Aug 08, 2023 at 01:09:45PM +0100, Conor Dooley wrote:
> On Mon, Aug 07, 2023 at 04:06:10PM +0300, Alexey Romanov wrote:
> > Now the driver has a separate algo for S4 SoC.
> > 
> > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Actually, one comment, please, for bindings, write commit messages that
relate to the hardware rather than drivers. The bindings describe the
hardware, after all.
Alexey Romanov Aug. 16, 2023, 4:09 p.m. UTC | #3
Hi, Conor!

Thank you for the review.

On Tue, Aug 08, 2023 at 01:11:24PM +0100, Conor Dooley wrote:
> On Tue, Aug 08, 2023 at 01:09:45PM +0100, Conor Dooley wrote:
> > On Mon, Aug 07, 2023 at 04:06:10PM +0300, Alexey Romanov wrote:
> > > Now the driver has a separate algo for S4 SoC.
> > > 
> > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Actually, one comment, please, for bindings, write commit messages that
> relate to the hardware rather than drivers. The bindings describe the
> hardware, after all.

Yeah, will fix this in V3.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
index 457a6e43d810..afa52af442a7 100644
--- a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
+++ b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
@@ -14,6 +14,7 @@  properties:
   compatible:
     enum:
       - amlogic,meson-rng
+      - amlogic,meson-s4-rng
 
   reg:
     maxItems: 1