From patchwork Tue Aug 8 18:07:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 13346640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCFA4C001DB for ; Tue, 8 Aug 2023 18:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mFOJkGcZSXNokml+1A5xo09ce7SEkTzlYqypkUl3Pb8=; b=SANVNVfqvHYNx2jBeCNcJK9iU5 EGggBZjPwDogoiH3zOLdwbBvLad8aX0oUk2XK97qNRuIeA2lRu/8+7m7WXMr8TchLeZ/ut75X+kXB qYmsWB+E/2QTxogEB4AXtG59TsGzJCiFJpDZcT0SwqH3mPUoJGJxVtVnRiZz6DgFrp5ODqrfU5T7m HjWDcXD4DgyDrC6XGTDsiqPVE4lenoLypAllNBWzOUGhTjHHiqa3ftxBVphRkdQ2caBZn91GijiLa EjnicvQb87ZI5d55uT7mBc4r37YXvQlM7Txk5u4AdBfjtQi5jIVGjyPtaFyJo9pGBaD0t6uqELH/g Axl/W9sQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTR7Z-003BPl-2S; Tue, 08 Aug 2023 18:07:53 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTR7U-003BMu-0y for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 18:07:50 +0000 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-564ef63a010so91753a12.0 for ; Tue, 08 Aug 2023 11:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1691518063; x=1692122863; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=eRqMVS7gDB0iwoUqytfXx4P+PciySF5rHRWxAGvUgn8=; b=cbhkvK7BELbqGhP7znnFD55m0xtah5XHvV/BeMdAath4Kfd7ouLqT0zoJkvLZhvI7J O/OXXWxDuhX0GQXneP3XQ7pnNLxRyMZn2r7RDwaEdR7ftiziv7pN6byiA7q+E0HOYzR1 5gMq/QS7VBUEb2xZIobQjyfkJ90TbKhEy7vx8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691518063; x=1692122863; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eRqMVS7gDB0iwoUqytfXx4P+PciySF5rHRWxAGvUgn8=; b=kR/OXNxDBJetlHtXNwNx87qNYVtSyz4mB+0opIe8qxdcx32WnTkglek4q+B54CKAeg SIxfH4ZTlpSLQoii3KfngyiVyZQhRCrTQQNrznuty+ZrKh7nSgaVaunsrsyfVjX0XsRs AdTTa5q03ANFK2LZEaXlzPxlgiuV9Y5PLK5SSi+o0bYQBypieHLXpvhDdBiysgUWLixP 9QE1bq8JBvP8sbDS0rqNZ5WNQl+Yh0LEhtauzoDvuGv/TKESuwbkrcIArM685ajFfU9y Vc4nWWHv8hhYHeNB+KAHTYTQDpDYjwuXbXZBJh+/194lRqk4O4gl7HHA8nNNlWTHa5cB w8OA== X-Gm-Message-State: AOJu0Yz1OZWlXQ6TpvtrpYFObjVOu35n43YR+M43empmgKDnwSe0E4oU +aYhPTTfdfGDmreTxgsAW1W0lQ== X-Google-Smtp-Source: AGHT+IG0HmGIL7nO84nsLyrRwT8W8ltx+IezVllaebNL5g7CayrjkjWph4OiWB61+HFtyQnIVp2Pog== X-Received: by 2002:a05:6a20:8f0c:b0:138:68b9:138e with SMTP id b12-20020a056a208f0c00b0013868b9138emr14627624pzk.8.1691518063452; Tue, 08 Aug 2023 11:07:43 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y28-20020a637d1c000000b00564beacbd20sm6683067pgc.74.2023.08.08.11.07.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 11:07:42 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Linus Walleij , Ray Jui , Scott Branden , Broadcom internal kernel review list , Andy Shevchenko , linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE) Subject: [PATCH 1/2 v2] pinctrl: iproc-gpio: Silence probe deferral messages Date: Tue, 8 Aug 2023 11:07:32 -0700 Message-Id: <20230808180733.2081353-2-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808180733.2081353-1-florian.fainelli@broadcom.com> References: <20230808180733.2081353-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_110748_339736_121F3772 X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli --- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c index cc3eb7409ab3..0e3f787b93ef 100644 --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c @@ -891,10 +891,8 @@ static int iproc_gpio_probe(struct platform_device *pdev) } ret = gpiochip_add_data(gc, chip); - if (ret < 0) { - dev_err(dev, "unable to add GPIO chip\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "unable to add GPIO chip\n"); if (!no_pinconf) { ret = iproc_gpio_register_pinconf(chip);