| Message ID | 20230808180733.2081353-3-florian.fainelli@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: bcm: Use dev_err_probe() | expand |
On Tue, Aug 8, 2023 at 8:07 PM Florian Fainelli <florian.fainelli@broadcom.com> wrote: > We can have gpiochip_add_data() return -EPROBE_DEFER which will make > us produce the "unable to add GPIO chip" message which is confusing. > Use dev_err_probe() to silence probe deferral messages. > > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c index 5045a7e57f1d..7fecd0a10cd1 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c @@ -686,10 +686,8 @@ static int nsp_gpio_probe(struct platform_device *pdev) } ret = devm_gpiochip_add_data(dev, gc, chip); - if (ret < 0) { - dev_err(dev, "unable to add GPIO chip\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "unable to add GPIO chip\n"); ret = nsp_gpio_register_pinconf(chip); if (ret) {
We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> --- drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)