| Message ID | 20230811130700.72787-2-eugen.hristev@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: phy: mediatek,tphy: allow simple nodename pattern | expand |
Hi Eugen, On Fri, 2023-08-11 at 16:07 +0300, Eugen Hristev wrote: > Fix: > Warning (unit_address_vs_reg): /t-phy@1a243000: node has a unit name, but no reg or ranges property > Warning (unit_address_vs_reg): /soc/t-phy@11c00000: node has a unit name, but no reg or ranges property > > The ranges is empty thus removing the `@1a243000`, `@11c00000` from > the node name. Does this patch need a Fixes: tag? It would be also quite nice to say in your commit messsage where the error comes from (make dtbs_check) :-) > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +- > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > index 36ef2dbe8add..3ee9266fa8e9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > @@ -905,7 +905,7 @@ sata: sata@1a200000 { > status = "disabled"; > }; > > - sata_phy: t-phy@1a243000 { > + sata_phy: t-phy { > compatible = "mediatek,mt7622-tphy", > "mediatek,generic-tphy-v1"; > #address-cells = <2>; > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > index 68539ea788df..24eda00e320d 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > @@ -434,7 +434,7 @@ pcie_intc: interrupt-controller { > }; > }; > > - pcie_phy: t-phy@11c00000 { > + pcie_phy: t-phy { > compatible = "mediatek,mt7986-tphy", > "mediatek,generic-tphy-v2"; > #address-cells = <2>; > -- > 2.34.1
diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index 36ef2dbe8add..3ee9266fa8e9 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -905,7 +905,7 @@ sata: sata@1a200000 { status = "disabled"; }; - sata_phy: t-phy@1a243000 { + sata_phy: t-phy { compatible = "mediatek,mt7622-tphy", "mediatek,generic-tphy-v1"; #address-cells = <2>; diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi index 68539ea788df..24eda00e320d 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi @@ -434,7 +434,7 @@ pcie_intc: interrupt-controller { }; }; - pcie_phy: t-phy@11c00000 { + pcie_phy: t-phy { compatible = "mediatek,mt7986-tphy", "mediatek,generic-tphy-v2"; #address-cells = <2>;
Fix: Warning (unit_address_vs_reg): /t-phy@1a243000: node has a unit name, but no reg or ranges property Warning (unit_address_vs_reg): /soc/t-phy@11c00000: node has a unit name, but no reg or ranges property The ranges is empty thus removing the `@1a243000`, `@11c00000` from the node name. Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +- arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)