| Message ID | 20230814071053.5459-1-eugen.hristev@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties | expand |
Il 14/08/23 09:10, Eugen Hristev ha scritto: > dtbs_check throws a warning at the dsi node: > Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Other DTS have a panel child node with a reg, so the parent dtsi > must have the address-cells and size-cells, however this specific DT > has the panel removed, but not the cells, hence the warning above. > > If panel is deleted then the cells must also be deleted since they are > tied together, as the child node in this DT does not have a reg. > > Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board") > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Mon, 14 Aug 2023 10:10:53 +0300, Eugen Hristev wrote: > dtbs_check throws a warning at the dsi node: > Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Other DTS have a panel child node with a reg, so the parent dtsi > must have the address-cells and size-cells, however this specific DT > has the panel removed, but not the cells, hence the warning above. > > [...] Applied, thanks! [1/1] arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties commit: 4b66a34afe29d991155081b2f1e10482bd00cbaa Best regards,
On 29/11/2023 14:27, AngeloGioacchino Del Regno wrote: > > On Mon, 14 Aug 2023 10:10:53 +0300, Eugen Hristev wrote: >> dtbs_check throws a warning at the dsi node: >> Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property >> >> Other DTS have a panel child node with a reg, so the parent dtsi >> must have the address-cells and size-cells, however this specific DT >> has the panel removed, but not the cells, hence the warning above. >> >> [...] > > Applied, thanks! > > [1/1] arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties > commit: 4b66a34afe29d991155081b2f1e10482bd00cbaa > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > You know, your SoB implies review. Unless you want to say you usually apply code without reviewing it... Best regards, Krzysztof
Il 30/11/23 10:01, Krzysztof Kozlowski ha scritto: > On 29/11/2023 14:27, AngeloGioacchino Del Regno wrote: >> >> On Mon, 14 Aug 2023 10:10:53 +0300, Eugen Hristev wrote: >>> dtbs_check throws a warning at the dsi node: >>> Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property >>> >>> Other DTS have a panel child node with a reg, so the parent dtsi >>> must have the address-cells and size-cells, however this specific DT >>> has the panel removed, but not the cells, hence the warning above. >>> >>> [...] >> >> Applied, thanks! >> >> [1/1] arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties >> commit: 4b66a34afe29d991155081b2f1e10482bd00cbaa >> > >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> > > You know, your SoB implies review. Unless you want to say you > usually apply code without reviewing it... > Yeah, of course it does imply review ... but if there's no actual problem with me also sending a R-b tag, it's more practical for me, because: 1. I have mail filters to show me what I reviewed, and 2. Matthias also can see what I reviewed.... ...but I get it that in the specific case of *this* patch, I've sent a R-b just before applying, so I agree in that this was actually really really useless to do. so.. whoops :-) Thanks, btw! Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi index bf97b60ae4d1..649477af2f41 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi @@ -91,6 +91,8 @@ cros_ec_pwm: pwm { &dsi0 { status = "okay"; + /delete-property/#size-cells; + /delete-property/#address-cells; /delete-node/panel@0; ports { port {
dtbs_check throws a warning at the dsi node: Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Other DTS have a panel child node with a reg, so the parent dtsi must have the address-cells and size-cells, however this specific DT has the panel removed, but not the cells, hence the warning above. If panel is deleted then the cells must also be deleted since they are tied together, as the child node in this DT does not have a reg. Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board") Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ 1 file changed, 2 insertions(+)