| Message ID | 20230816-void-drivers-dma-owl-dma-v1-1-a0a5e085e937@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dmaengine: owl-dma: fix clang -Wvoid-pointer-to-enum-cast warning | expand |
On Wed, Aug 16, 2023 at 08:12:50PM +0000, Justin Stitt wrote: > When building with clang 18 I see the following warning: > | drivers/dma/owl-dma.c:1119:14: warning: cast to smaller integer type > | 'enum owl_dma_id' from 'const void *' [-Wvoid-pointer-to-enum-cast] > | 1119 | od->devid = (enum owl_dma_id)of_device_get_match_data(&pdev->dev); > > This is due to the fact that `of_device_get_match_data()` returns a > void* while `enum owl_dma_id` has the size of an int. > > Cast result of `of_device_get_match_data()` to a uintptr_t to silence > the above warning for clang builds using W=1 > > Link: https://github.com/ClangBuiltLinux/linux/issues/1910 > Reported-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Justin Stitt <justinstitt@google.com> Acked-by: Manivannan Sadhasivam <mani@kernel.org> - Mani > --- > drivers/dma/owl-dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c > index b6e0ac8314e5..f340a04579f4 100644 > --- a/drivers/dma/owl-dma.c > +++ b/drivers/dma/owl-dma.c > @@ -1116,7 +1116,7 @@ static int owl_dma_probe(struct platform_device *pdev) > dev_info(&pdev->dev, "dma-channels %d, dma-requests %d\n", > nr_channels, nr_requests); > > - od->devid = (enum owl_dma_id)of_device_get_match_data(&pdev->dev); > + od->devid = (uintptr_t)of_device_get_match_data(&pdev->dev); > > od->nr_pchans = nr_channels; > od->nr_vchans = nr_requests; > > --- > base-commit: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421 > change-id: 20230816-void-drivers-dma-owl-dma-41b95a098275 > > Best regards, > -- > Justin Stitt <justinstitt@google.com> >
On Wed, 16 Aug 2023 20:12:50 +0000, Justin Stitt wrote: > When building with clang 18 I see the following warning: > | drivers/dma/owl-dma.c:1119:14: warning: cast to smaller integer type > | 'enum owl_dma_id' from 'const void *' [-Wvoid-pointer-to-enum-cast] > | 1119 | od->devid = (enum owl_dma_id)of_device_get_match_data(&pdev->dev); > > This is due to the fact that `of_device_get_match_data()` returns a > void* while `enum owl_dma_id` has the size of an int. > > [...] Applied, thanks! [1/1] dmaengine: owl-dma: fix clang -Wvoid-pointer-to-enum-cast warning commit: 1fbda5f4c7c1c8bd51cd3bc3d2ff19176c696b74 Best regards,
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index b6e0ac8314e5..f340a04579f4 100644 --- a/drivers/dma/owl-dma.c +++ b/drivers/dma/owl-dma.c @@ -1116,7 +1116,7 @@ static int owl_dma_probe(struct platform_device *pdev) dev_info(&pdev->dev, "dma-channels %d, dma-requests %d\n", nr_channels, nr_requests); - od->devid = (enum owl_dma_id)of_device_get_match_data(&pdev->dev); + od->devid = (uintptr_t)of_device_get_match_data(&pdev->dev); od->nr_pchans = nr_channels; od->nr_vchans = nr_requests;
When building with clang 18 I see the following warning: | drivers/dma/owl-dma.c:1119:14: warning: cast to smaller integer type | 'enum owl_dma_id' from 'const void *' [-Wvoid-pointer-to-enum-cast] | 1119 | od->devid = (enum owl_dma_id)of_device_get_match_data(&pdev->dev); This is due to the fact that `of_device_get_match_data()` returns a void* while `enum owl_dma_id` has the size of an int. Cast result of `of_device_get_match_data()` to a uintptr_t to silence the above warning for clang builds using W=1 Link: https://github.com/ClangBuiltLinux/linux/issues/1910 Reported-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Justin Stitt <justinstitt@google.com> --- drivers/dma/owl-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421 change-id: 20230816-void-drivers-dma-owl-dma-41b95a098275 Best regards, -- Justin Stitt <justinstitt@google.com>