| Message ID | 20230816211849.v6.8.I7a8beb615e2520ad395d96df94b9ab9708ee0d9c@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Refactor the SMMU's CD table ownership | expand |
On Wed, Aug 16, 2023 at 09:18:48PM +0800, Michael Shavit wrote: > Update the comment to reflect the fact that the STE is not always > installed. arm_smmu_domain_finalise_s1 intentionnaly calls > arm_smmu_write_ctx_desc while the STE is not installed. > > Signed-off-by: Michael Shavit <mshavit@google.com> > --- Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
On Wed, Aug 16, 2023 at 09:18:48PM +0800, Michael Shavit wrote: > Update the comment to reflect the fact that the STE is not always > installed. arm_smmu_domain_finalise_s1 intentionnaly calls > arm_smmu_write_ctx_desc while the STE is not installed. > > Signed-off-by: Michael Shavit <mshavit@google.com> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index de87150cd0242..3c8bfeca89d5c 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -1091,7 +1091,7 @@ int arm_smmu_write_ctx_desc(struct arm_smmu_master *master, int ssid, cdptr[3] = cpu_to_le64(cd->mair); /* - * STE is live, and the SMMU might read dwords of this CD in any + * STE may be live, and the SMMU might read dwords of this CD in any * order. Ensure that it observes valid values before reading * V=1. */
Update the comment to reflect the fact that the STE is not always installed. arm_smmu_domain_finalise_s1 intentionnaly calls arm_smmu_write_ctx_desc while the STE is not installed. Signed-off-by: Michael Shavit <mshavit@google.com> --- Changes in v6: - New commit drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)