From patchwork Wed Aug 16 13:18:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Shavit X-Patchwork-Id: 13355175 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D716CC04FDF for ; Wed, 16 Aug 2023 13:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=NIm1oCay2rbygMzTR6nhjNhSQqF5Ph0oNFbydoRkPn0=; b=4AmfzAW9mNbT9UqjaUkK6hJUNY hNpWMk0ZEHHJjzo2a4mfioSJkZxTfgfDsymcKuqoibdcIYxxbvwZmfb3pWUdaI2WauY3X5moSOlL+ lSKg96eQzulnTSJ04zZCgqBR95q4jvHCxpE6B9qRE2+QGIZVrikm4/zEzOS3e5Mt+I16S2gheuYxd I7lRMYxOyzd3zN2tiQALQvAWInnYPETz9k4d9xoQAGfiSN7XQNCRiSEQxFgJ650+GNy1n2D4X1Xml HJucTiifxCnW4UfoX9cnrKqsXnbEeAPWBUg9yH1TS5pYUzveF8HVZf869w33yT/wCavMPI/Iw3VNE vNGiAp6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWGRc-004FgE-2q; Wed, 16 Aug 2023 13:20:16 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWGRV-004Fbh-3B for linux-arm-kernel@lists.infradead.org; Wed, 16 Aug 2023 13:20:11 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-589cd098d24so63863577b3.0 for ; Wed, 16 Aug 2023 06:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692192008; x=1692796808; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=JVOpA/yt+XB5fUDF/Igz/1o39LmIyoO6uf2H6LfppQ0=; b=YHx69WaUgdUHez2bpSsN8VAxs+M9Lh0EQC30duWKtyrWoU5UQTBl3GKL0LegsdUQVV kx+B6cCwadRkWKJfekVHY8VUMOO8F1S3vlM9rjxOBbKChwmPib7a3m2k4KzhrAJxFYgw SB+aN7HVCG4MkJ8rHCdQ8ueQEX1bw9HsxGgrwc8fSyopYuNcpKF4I2RiKLh05MUuIfhJ fj4IjCHt43Kdzkb1Kgdjzqu4Ah1mVPOuvAMLjXb19UTBxtnDlgXy+fTZ5T5/1PXc1lUp PR8annuG6JxdZAe1nvGiISguAQby7BJc8Ifl/RWJkwV53HZ4hMbYWb0Yg5IMbtnHEV7t x7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692192008; x=1692796808; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JVOpA/yt+XB5fUDF/Igz/1o39LmIyoO6uf2H6LfppQ0=; b=fZ5uOLEAzTDkqWSXUfkrZXA7YFoJGqyn+bzbH5UmfuEvqzxfMMBDH+Z6pgH5ZSDb0M jF+RMb+3A3PvEjlHDyxF7/Qj8kQyDfdjjAvsmu7uLBGPAWH/iPqA8RLRO/ZE+nxI1CBh gsGto3kyPmJV9t4A/4N1mXV0PoWayU8juVZuZMK/UrHMEEGC1DylouBMn5NDK7gajYPh 3AP2aR6AYI+6McU0ofWHkPBJkwcQGhfGUrKE25R7ZaeyBdOztnXUimbPad00iaiUwPLU 1fA8p/wg0mN0kYMvMIehAsr+WHwdHsw4aP+YiWFU0Xj4AbfRVaHicE6OxDFDpMmTpNZc KWJA== X-Gm-Message-State: AOJu0YwagZ3vVG1y/BpCvB+CELf+BgW2d1Vsj7w5Cae9XA+gDbcTzDEQ hNCPVDS7fAo74QjjDnwjZUyO0l/AVp6L X-Google-Smtp-Source: AGHT+IFpyLI55CA6xQKncSrPwnccVH+ac9drAor/x+DI/dKv5IqDhSwq+q3zlIdn3S0InwRjuxU5uhS9UAek X-Received: from mshavit.ntc.corp.google.com ([2401:fa00:95:20c:ae98:2006:2abd:3434]) (user=mshavit job=sendgmr) by 2002:a81:4524:0:b0:57a:793:7fb0 with SMTP id s36-20020a814524000000b0057a07937fb0mr24462ywa.3.1692192008657; Wed, 16 Aug 2023 06:20:08 -0700 (PDT) Date: Wed, 16 Aug 2023 21:18:48 +0800 In-Reply-To: <20230816131925.2521220-1-mshavit@google.com> Mime-Version: 1.0 References: <20230816131925.2521220-1-mshavit@google.com> X-Mailer: git-send-email 2.41.0.694.ge786442a9b-goog Message-ID: <20230816211849.v6.8.I7a8beb615e2520ad395d96df94b9ab9708ee0d9c@changeid> Subject: [PATCH v6 08/10] iommu/arm-smmu-v3: Update comment about STE liveness From: Michael Shavit To: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: robin.murphy@arm.com, will@kernel.org, jean-philippe@linaro.org, jgg@nvidia.com, nicolinc@nvidia.com, Michael Shavit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230816_062010_032898_CDFF873F X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Update the comment to reflect the fact that the STE is not always installed. arm_smmu_domain_finalise_s1 intentionnaly calls arm_smmu_write_ctx_desc while the STE is not installed. Signed-off-by: Michael Shavit Reviewed-by: Jason Gunthorpe Reviewed-by: Nicolin Chen --- Changes in v6: - New commit drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index de87150cd0242..3c8bfeca89d5c 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -1091,7 +1091,7 @@ int arm_smmu_write_ctx_desc(struct arm_smmu_master *master, int ssid, cdptr[3] = cpu_to_le64(cd->mair); /* - * STE is live, and the SMMU might read dwords of this CD in any + * STE may be live, and the SMMU might read dwords of this CD in any * order. Ensure that it observes valid values before reading * V=1. */