| Message ID | 20230822084520.564937-3-wenst@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | regulator: mt6366: Split out of MT6358 and cleanup | expand |
On 22/08/2023 10:45, Chen-Yu Tsai wrote: > The MT6366 PMIC, compared to the MT6358, does away with the VCAM* > regulators. Two regulators VM18 and VMDDR reuse their register space. > There's also a VSRAM type regulator VSRAM_CORE thats' split between > the VCAM* register space and other parts. > > Add register address macros for these MT6366 specific regulators. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > Adding few defines without any code using it barely fits one logical change. It's just not a change, even if AMD tells you otherwise with their autogenerated headers. I think this should be squashed with its user. Best regards, Krzysztof
Il 22/08/23 10:45, Chen-Yu Tsai ha scritto: > The MT6366 PMIC, compared to the MT6358, does away with the VCAM* > regulators. Two regulators VM18 and VMDDR reuse their register space. > There's also a VSRAM type regulator VSRAM_CORE thats' split between > the VCAM* register space and other parts. > > Add register address macros for these MT6366 specific regulators. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> For ease of applying to MFD, I think it's ok to have the header changes split from the actual user; so: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cheers! > --- > include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h > index 5ea2590be710..d83e87298ac4 100644 > --- a/include/linux/mfd/mt6358/registers.h > +++ b/include/linux/mfd/mt6358/registers.h > @@ -294,4 +294,21 @@ > #define MT6358_AUD_TOP_INT_CON0 0x2228 > #define MT6358_AUD_TOP_INT_STATUS0 0x2234 > > +/* > + * MT6366 has no VCAM*, but has other regulators in its place. The names > + * keep the MT6358 prefix for ease of use in the regulator driver. > + */ > +#define MT6358_LDO_VSRAM_CON5 0x1bf8 > +#define MT6358_LDO_VM18_CON0 MT6358_LDO_VCAMA1_CON0 > +#define MT6358_LDO_VM18_CON1 MT6358_LDO_VCAMA1_CON1 > +#define MT6358_LDO_VM18_CON2 MT6358_LDO_VCAMA1_CON2 > +#define MT6358_LDO_VMDDR_CON0 MT6358_LDO_VCAMA2_CON0 > +#define MT6358_LDO_VMDDR_CON1 MT6358_LDO_VCAMA2_CON1 > +#define MT6358_LDO_VMDDR_CON2 MT6358_LDO_VCAMA2_CON2 > +#define MT6358_LDO_VSRAM_CORE_CON0 MT6358_LDO_VCAMD_CON0 > +#define MT6358_LDO_VSRAM_CORE_DBG0 0x1cb6 > +#define MT6358_LDO_VSRAM_CORE_DBG1 0x1cb8 > +#define MT6358_VM18_ANA_CON0 MT6358_VCAMA1_ANA_CON0 > +#define MT6358_VMDDR_ANA_CON0 MT6358_VCAMD_ANA_CON0 > + > #endif /* __MFD_MT6358_REGISTERS_H__ */
On Fri, Sep 15, 2023 at 4:55 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 22/08/23 10:45, Chen-Yu Tsai ha scritto: > > The MT6366 PMIC, compared to the MT6358, does away with the VCAM* > > regulators. Two regulators VM18 and VMDDR reuse their register space. > > There's also a VSRAM type regulator VSRAM_CORE thats' split between > > the VCAM* register space and other parts. > > > > Add register address macros for these MT6366 specific regulators. > > > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > For ease of applying to MFD, I think it's ok to have the header changes split > from the actual user; so: Actually that doesn't help, because this is a compile time dependency. Merging this through the MFD tree and the rest through the regulator tree would mean either creating an immutable branch, or Lee giving an ack for this patch to go through the regulator tree. We would be doing the latter if we squashed the patches together anyway. I think squashing them does make sense. ChenYu > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Cheers! > > > --- > > include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h > > index 5ea2590be710..d83e87298ac4 100644 > > --- a/include/linux/mfd/mt6358/registers.h > > +++ b/include/linux/mfd/mt6358/registers.h > > @@ -294,4 +294,21 @@ > > #define MT6358_AUD_TOP_INT_CON0 0x2228 > > #define MT6358_AUD_TOP_INT_STATUS0 0x2234 > > > > +/* > > + * MT6366 has no VCAM*, but has other regulators in its place. The names > > + * keep the MT6358 prefix for ease of use in the regulator driver. > > + */ > > +#define MT6358_LDO_VSRAM_CON5 0x1bf8 > > +#define MT6358_LDO_VM18_CON0 MT6358_LDO_VCAMA1_CON0 > > +#define MT6358_LDO_VM18_CON1 MT6358_LDO_VCAMA1_CON1 > > +#define MT6358_LDO_VM18_CON2 MT6358_LDO_VCAMA1_CON2 > > +#define MT6358_LDO_VMDDR_CON0 MT6358_LDO_VCAMA2_CON0 > > +#define MT6358_LDO_VMDDR_CON1 MT6358_LDO_VCAMA2_CON1 > > +#define MT6358_LDO_VMDDR_CON2 MT6358_LDO_VCAMA2_CON2 > > +#define MT6358_LDO_VSRAM_CORE_CON0 MT6358_LDO_VCAMD_CON0 > > +#define MT6358_LDO_VSRAM_CORE_DBG0 0x1cb6 > > +#define MT6358_LDO_VSRAM_CORE_DBG1 0x1cb8 > > +#define MT6358_VM18_ANA_CON0 MT6358_VCAMA1_ANA_CON0 > > +#define MT6358_VMDDR_ANA_CON0 MT6358_VCAMD_ANA_CON0 > > + > > #endif /* __MFD_MT6358_REGISTERS_H__ */ >
On Tue, 22 Aug 2023, Chen-Yu Tsai wrote: > The MT6366 PMIC, compared to the MT6358, does away with the VCAM* > regulators. Two regulators VM18 and VMDDR reuse their register space. > There's also a VSRAM type regulator VSRAM_CORE thats' split between > the VCAM* register space and other parts. > > Add register address macros for these MT6366 specific regulators. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Acked-by: Lee Jones <lee@kernel.org> > diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h > index 5ea2590be710..d83e87298ac4 100644 > --- a/include/linux/mfd/mt6358/registers.h > +++ b/include/linux/mfd/mt6358/registers.h > @@ -294,4 +294,21 @@ > #define MT6358_AUD_TOP_INT_CON0 0x2228 > #define MT6358_AUD_TOP_INT_STATUS0 0x2234 > > +/* > + * MT6366 has no VCAM*, but has other regulators in its place. The names > + * keep the MT6358 prefix for ease of use in the regulator driver. > + */ > +#define MT6358_LDO_VSRAM_CON5 0x1bf8 > +#define MT6358_LDO_VM18_CON0 MT6358_LDO_VCAMA1_CON0 > +#define MT6358_LDO_VM18_CON1 MT6358_LDO_VCAMA1_CON1 > +#define MT6358_LDO_VM18_CON2 MT6358_LDO_VCAMA1_CON2 > +#define MT6358_LDO_VMDDR_CON0 MT6358_LDO_VCAMA2_CON0 > +#define MT6358_LDO_VMDDR_CON1 MT6358_LDO_VCAMA2_CON1 > +#define MT6358_LDO_VMDDR_CON2 MT6358_LDO_VCAMA2_CON2 > +#define MT6358_LDO_VSRAM_CORE_CON0 MT6358_LDO_VCAMD_CON0 > +#define MT6358_LDO_VSRAM_CORE_DBG0 0x1cb6 > +#define MT6358_LDO_VSRAM_CORE_DBG1 0x1cb8 > +#define MT6358_VM18_ANA_CON0 MT6358_VCAMA1_ANA_CON0 > +#define MT6358_VMDDR_ANA_CON0 MT6358_VCAMD_ANA_CON0 > + > #endif /* __MFD_MT6358_REGISTERS_H__ */ > -- > 2.42.0.rc1.204.g551eb34607-goog >
diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h index 5ea2590be710..d83e87298ac4 100644 --- a/include/linux/mfd/mt6358/registers.h +++ b/include/linux/mfd/mt6358/registers.h @@ -294,4 +294,21 @@ #define MT6358_AUD_TOP_INT_CON0 0x2228 #define MT6358_AUD_TOP_INT_STATUS0 0x2234 +/* + * MT6366 has no VCAM*, but has other regulators in its place. The names + * keep the MT6358 prefix for ease of use in the regulator driver. + */ +#define MT6358_LDO_VSRAM_CON5 0x1bf8 +#define MT6358_LDO_VM18_CON0 MT6358_LDO_VCAMA1_CON0 +#define MT6358_LDO_VM18_CON1 MT6358_LDO_VCAMA1_CON1 +#define MT6358_LDO_VM18_CON2 MT6358_LDO_VCAMA1_CON2 +#define MT6358_LDO_VMDDR_CON0 MT6358_LDO_VCAMA2_CON0 +#define MT6358_LDO_VMDDR_CON1 MT6358_LDO_VCAMA2_CON1 +#define MT6358_LDO_VMDDR_CON2 MT6358_LDO_VCAMA2_CON2 +#define MT6358_LDO_VSRAM_CORE_CON0 MT6358_LDO_VCAMD_CON0 +#define MT6358_LDO_VSRAM_CORE_DBG0 0x1cb6 +#define MT6358_LDO_VSRAM_CORE_DBG1 0x1cb8 +#define MT6358_VM18_ANA_CON0 MT6358_VCAMA1_ANA_CON0 +#define MT6358_VMDDR_ANA_CON0 MT6358_VCAMD_ANA_CON0 + #endif /* __MFD_MT6358_REGISTERS_H__ */
The MT6366 PMIC, compared to the MT6358, does away with the VCAM* regulators. Two regulators VM18 and VMDDR reuse their register space. There's also a VSRAM type regulator VSRAM_CORE thats' split between the VCAM* register space and other parts. Add register address macros for these MT6366 specific regulators. Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)