From patchwork Wed Aug 23 13:13:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Elisei X-Patchwork-Id: 13362341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9379EE49A0 for ; Wed, 23 Aug 2023 13:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JVzPtZ4+5sWzftgvt/W9D0eM5ES2spjJVCTbUv82YYM=; b=pQqvoxgZxLeHRZ jSeSNgDD8OHmgAawv7pLRnutx2hUH/H/wqL8RNZUSHIoZ91EZcRiKHREbTMcEaWloGgNGJudLln41 rKUQ+KnWyvKEVFp/+xewnxGF1bIy7YLFaLMckRZyeSSXE3QCKpwQ2spm5k2+YM+pEnglDzO7oK5rO rvgbWVNijvb5BD+c63P916UvrNUlkwCYR08T8tvkENM/O9i3CEqyjXFD4ALiiQzyzV8OW81FyOZpw z6aqmt6XLJuSM4LWYermfLfwsd8KqSmFhzXQqw5xPexkoKT8PGDbaVa8/YEc8UU36rhnsf+qVWop/ YIQ5zaYDmK+kft/m3SSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYnhz-000cuA-2e; Wed, 23 Aug 2023 13:15:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYnhk-000cj4-30 for linux-arm-kernel@lists.infradead.org; Wed, 23 Aug 2023 13:15:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91C481650; Wed, 23 Aug 2023 06:16:04 -0700 (PDT) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4AFC03F740; Wed, 23 Aug 2023 06:15:18 -0700 (PDT) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC 12/37] mm: gup: Don't allow longterm pinning of MIGRATE_METADATA pages Date: Wed, 23 Aug 2023 14:13:25 +0100 Message-Id: <20230823131350.114942-13-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823131350.114942-1-alexandru.elisei@arm.com> References: <20230823131350.114942-1-alexandru.elisei@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230823_061525_019365_E23AF454 X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Treat MIGRATE_METADATA pages just like movable or CMA pages and don't allow them to be pinned longterm. No special handling needed for migrate_longterm_unpinnable_pages() because the gfp mask for allocating the destination pages is GFP_USER. GFP_USER doesn't include __GFP_MOVABLE, which makes it impossible to accidently allocate metadata pages for migrating the pinned pages. Signed-off-by: Alexandru Elisei --- include/linux/mm.h | 10 +++++++--- mm/Kconfig | 2 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 2dd73e4f3d8e..ce87d55ecf87 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1925,16 +1925,20 @@ static inline bool is_zero_folio(const struct folio *folio) return is_zero_page(&folio->page); } -/* MIGRATE_CMA and ZONE_MOVABLE do not allow pin folios */ +/* MIGRATE_CMA, MIGRATE_METADATA and ZONE_MOVABLE do not allow pin folios */ #ifdef CONFIG_MIGRATION static inline bool folio_is_longterm_pinnable(struct folio *folio) { -#ifdef CONFIG_CMA +#if defined(CONFIG_CMA) || defined(CONFIG_MEMORY_METADATA) int mt = folio_migratetype(folio); - if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE) + if (mt == MIGRATE_ISOLATE) + return false; + + if (is_migrate_cma(mt) || is_migrate_metadata(mt)) return false; #endif + /* The zero page can be "pinned" but gets special handling. */ if (is_zero_folio(folio)) return true; diff --git a/mm/Kconfig b/mm/Kconfig index 838193522e20..847e1669dba0 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -1238,6 +1238,8 @@ config LOCK_MM_AND_FIND_VMA config MEMORY_METADATA bool + select MEMORY_ISOLATION + select MIGRATION source "mm/damon/Kconfig"