From patchwork Thu Aug 24 15:30:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13364380 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83631C3DA6F for ; Thu, 24 Aug 2023 15:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RFqpj3p1e8C2LP/pF4dluN9fqTSozLpg0AQiDA83O9g=; b=Gd+R46Q8whKMEG Vq0EBrUrRgTBddYIv0+nwDdCwklqOCUwglcwtenMEyssKi3oItKjMCUa26Li/0uoYSVhbJ9u+4kHJ C7kfwNWxyIS2FLSItvM2ucSXvElGgQQf9LvkNM0bvahPvSjOp/gH+yPfVG5NlN0PDkh5OlGLmO5vw Gxvo9+DzyCJdj+eM0b5RnI1Uv3ReFT9naSY/lUdgAqjkJFt4l1nSNO8Khux5NcVmzvQg+pAPBTsyA AOKaEgaorZQ8Alf/P3jrjwENqZU6wxvYZ4Tgek5RKuVAoJngNmJcV0eMKjctZkpzns4js3zb/eqwm vXqfuKFBjrxZWPpNdK+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZCKl-003NLl-2C; Thu, 24 Aug 2023 15:33:19 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZCKY-003NGn-0X for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2023 15:33:07 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-68bec3a81c4so3158b3a.1 for ; Thu, 24 Aug 2023 08:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692891183; x=1693495983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S8LQV3FZTWxLTg8jNgV7yvfSpimnidUcb0tZukELwI8=; b=lNensNrtbZ1/JO69cv/X7s17yyTO9pvyYki4jYqN0gNJwZSYaEv3k4Lrs/SWiERqSR MVf/1Ic8euWeBn106GsnAPicEAQZXm8K0jrbF94OgDjO8enkM6T2K63rkyzfF4S+v9HW fV2hiAqantxQwPP3J2uQWDI4t+aiqsMaMaFuo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692891183; x=1693495983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S8LQV3FZTWxLTg8jNgV7yvfSpimnidUcb0tZukELwI8=; b=FcWGy/hYBNm6f6YJnZYeVn1i4z6rmvG2zSHmJs4wzQQxtDkU4oiF7Zaw0C8KzR026V Gf7LQzw5WRamZlG72ItOwVnS3/Cs9vm1NCHt2rYx8VhhWjv2SoKqVbA35eh1bC8Mg/9N Rn6U95fjuDAGxWUFdyBbS0jSw70yzYTJTFZsMWksH0u+oHNnsOwqTRfEiXPkOIFLZdFA TOGGw2VMtdbV9wTcEJn216sXyJeI2dsUUn9zI7rBFIveQxB+N5EZSnvtghf4mrTtagxq 05iymFnUOEb+VB10cdjLe57yeFPxUaFP0AME7Z34M4BF8SVfAkvt7xrjaKnbSHi55Obu UwZQ== X-Gm-Message-State: AOJu0YxfC0OVk/TuIdN8AHhU+WBMX9/IsOXoj6km4anAyF/iJGjhaXSr 0hRX2oE7uUn/3KsbHi6IMpDlLiuf3Oe2+WcjY+qzTAtc X-Google-Smtp-Source: AGHT+IHtE7/RbB67nJdYB/Ae0mTQ0RJ8uJ9wBeYpGrn270z6LtX1u8780/eo8q0EyT04aZwzQcfYQg== X-Received: by 2002:a05:6a20:9187:b0:125:4d74:cd6a with SMTP id v7-20020a056a20918700b001254d74cd6amr22207369pzd.3.1692891182940; Thu, 24 Aug 2023 08:33:02 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:afa3:fcf5:1b7f:f7e2]) by smtp.gmail.com with ESMTPSA id m30-20020a63711e000000b0056365ee8603sm11631337pgc.67.2023.08.24.08.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 08:33:02 -0700 (PDT) From: Douglas Anderson To: Mark Rutland , Catalin Marinas , Will Deacon , Sumit Garg , Daniel Thompson , Marc Zyngier Cc: "Rafael J . Wysocki" , Ard Biesheuvel , Thomas Gleixner , kgdb-bugreport@lists.sourceforge.net, Lecopzer Chen , linux-perf-users@vger.kernel.org, Masayoshi Mizuma , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, ito-yuichi@fujitsu.com, Stephen Boyd , Peter Zijlstra , Douglas Anderson , Frederic Weisbecker , Guo Ren , Ingo Molnar , linux-kernel@vger.kernel.org Subject: [PATCH v11 2/6] arm64: idle: Tag the arm64 idle functions as __cpuidle Date: Thu, 24 Aug 2023 08:30:28 -0700 Message-ID: <20230824083012.v11.2.I4baba13e220bdd24d11400c67f137c35f07f82c7@changeid> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230824153233.1006420-1-dianders@chromium.org> References: <20230824153233.1006420-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_083306_254585_361F16BC X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As per the (somewhat recent) comment before the definition of `__cpuidle`, the tag is like `noinstr` but also marks a function so it can be identified by cpu_in_idle(). Let's add these markings to arm64 cpuidle functions With this change we get useful backtraces like: NMI backtrace for cpu N skipped: idling at cpu_do_idle+0x94/0x98 instead of useless backtraces when dumping all processors using nmi_cpu_backtrace(). NOTE: this patch won't make cpu_in_idle() work perfectly for arm64, but it doesn't hurt and does catch some cases. Specifically an example that wasn't caught in my testing looked like this: gic_cpu_sys_reg_init+0x1f8/0x314 gic_cpu_pm_notifier+0x40/0x78 raw_notifier_call_chain+0x5c/0x134 cpu_pm_notify+0x38/0x64 cpu_pm_exit+0x20/0x2c psci_enter_idle_state+0x48/0x70 cpuidle_enter_state+0xb8/0x260 cpuidle_enter+0x44/0x5c do_idle+0x188/0x30c Acked-by: Mark Rutland Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson Acked-by: Sumit Garg --- Changes in v11: - Updated commit message as per Stephen. Changes in v9: - Added to commit message that this doesn't catch all cases. Changes in v8: - "Tag the arm64 idle functions as __cpuidle" new for v8 arch/arm64/kernel/idle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/idle.c b/arch/arm64/kernel/idle.c index c1125753fe9b..05cfb347ec26 100644 --- a/arch/arm64/kernel/idle.c +++ b/arch/arm64/kernel/idle.c @@ -20,7 +20,7 @@ * ensure that interrupts are not masked at the PMR (because the core will * not wake up if we block the wake up signal in the interrupt controller). */ -void noinstr cpu_do_idle(void) +void __cpuidle cpu_do_idle(void) { struct arm_cpuidle_irq_context context; @@ -35,7 +35,7 @@ void noinstr cpu_do_idle(void) /* * This is our default idle handler. */ -void noinstr arch_cpu_idle(void) +void __cpuidle arch_cpu_idle(void) { /* * This should do all the clock switching and wait for interrupt