From patchwork Thu Aug 24 16:26:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13364444 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33554C6FA8F for ; Thu, 24 Aug 2023 16:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=hrNzZ4KsgcyBqqyEi5i1U9XdmwTaroADXgLWFTmWWjU=; b=YGrXrFUAuB+0T5 8dAD5hFoqC8jJ2JR2BBmAfQRBogbxFfAt/tF1yTehi7XagkZkaUR505KLLGXxebe84Amn6AVXKj7W Ibid+8U3TdxXUp0/I+d3xulynLJd2cJCUcDI/ftczeJs6mwFyfOVjZmOXB42XtCRl7ltfBPHkREjI mQjquJO1FBGPVZ/ooS0ZD+WGEvWXl+G7Q03+Xg+12QftxGhQePbLCY9+jsc3Hj3CKvht5WKKqhXoR zK2GRU0d8sFsNYI/wdaADKvvRLnydfbDkFePyxC2jEtzrLBKhy55uyHbHy6UWWbM+jSnWqjMhfdyt ZXCj/AslBIPovEI+0bew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZDB0-003S8L-28; Thu, 24 Aug 2023 16:27:18 +0000 Received: from mgamail.intel.com ([134.134.136.31]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZDAy-003S7t-0G for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2023 16:27:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692894436; x=1724430436; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=3+6axy8YcbF+Ei/Mg+uSsW6D9Griah2YTRGSppLrtTc=; b=HNlPC4RUu/araqzW04J9rsbZXPI9+JWN2irB54aRm6kQ3cCPo/NyLPbu Xqpt+U6MmX2V5catGx1hoe68L3yfUDOFewpIG6FwCU6KLG613Jup+cJnQ UBA8J4CuU/WzShy0KZfRcWg+wxiqPUkWZpToVrg7hq9V6Odn7GWaOLV3f ZgDTqq6F0r4ZVu5/LhCv8yWm3TmV78BiT8lI96vUwqr1sU8rkND8s+VsL uwicOQZhmEUNhLmR0HHJqEJBFmbqXzoh5K2QBn1NZNDjPcqOxL6Sm32zM iQ90+JxLr/2Q6+x1MPz8j52EchzfGYmJ4pVKHGIUX1mrEaFkCk7HTcJCi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="438440668" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="438440668" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 09:27:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="860780586" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="860780586" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 24 Aug 2023 09:27:07 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 8B73BF4; Thu, 24 Aug 2023 19:27:06 +0300 (EEST) From: Andy Shevchenko To: "Rafael J. Wysocki" , Rob Herring , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Russell King , Rob Herring , Frank Rowand , Peng Fan , Andy Shevchenko Subject: [PATCH v1 1/1] amba: bus: balance firmware node reference counting Date: Thu, 24 Aug 2023 19:26:54 +0300 Message-Id: <20230824162654.2890992-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_092716_182699_E6DF2482 X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently the ACPI code doesn't bump the reference count of the firmware node, while OF counter part does. Not that it's a problem right now, since ACPI doesn't really use the reference counting for firmware nodes, it still makes sense to make code robust against any changes done there. For this, - switch ACPI case to use device_set_node() to be unified with OF - move reference counting to amba_device_add() - switch to use firmware nodes instead of OF ones In the result we will have reference counting done in the same module for all callers independently on the nature of firmware node behind. Signed-off-by: Andy Shevchenko --- drivers/acpi/arm64/amba.c | 2 +- drivers/amba/bus.c | 5 ++++- drivers/of/platform.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/arm64/amba.c b/drivers/acpi/arm64/amba.c index 60be8ee1dbdc..171b5c2c7edd 100644 --- a/drivers/acpi/arm64/amba.c +++ b/drivers/acpi/arm64/amba.c @@ -101,7 +101,7 @@ static int amba_handler_attach(struct acpi_device *adev, if (parent) dev->dev.parent = acpi_get_first_physical_node(parent); - ACPI_COMPANION_SET(&dev->dev, adev); + device_set_node(&dev->dev, acpi_fwnode_handle(adev)); ret = amba_device_add(dev, &iomem_resource); if (ret) { diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 09e72967b8ab..05d0209a6347 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -528,7 +529,7 @@ static void amba_device_release(struct device *dev) { struct amba_device *d = to_amba_device(dev); - of_node_put(d->dev.of_node); + fwnode_handle_put(dev_fwnode(&d->dev); if (d->res.parent) release_resource(&d->res); mutex_destroy(&d->periphid_lock); @@ -548,6 +549,8 @@ int amba_device_add(struct amba_device *dev, struct resource *parent) { int ret; + fwnode_handle_get(dev_fwnode(&dev->dev)); + ret = request_resource(parent, &dev->res); if (ret) return ret; diff --git a/drivers/of/platform.c b/drivers/of/platform.c index f235ab55b91e..126d265aa7d8 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -273,7 +273,7 @@ static struct amba_device *of_amba_device_create(struct device_node *node, dev->dev.dma_mask = &dev->dev.coherent_dma_mask; /* setup generic device info */ - device_set_node(&dev->dev, of_fwnode_handle(of_node_get(node))); + device_set_node(&dev->dev, of_fwnode_handle(node)); dev->dev.parent = parent ? : &platform_bus; dev->dev.platform_data = platform_data; if (bus_id)