| Message ID | 20230829091853.626011-2-m.majewski2@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Improve Exynos thermal driver | expand |
On 29/08/2023 11:18, Mateusz Majewski wrote: > It seems that thermal in Exynos 4210 is broken without this, as it will > never decrease cooling after increasing it. > > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- > arch/arm/boot/dts/samsung/exynos4210.dtsi | 10 ++++++++-- Please split unrelated patches for different subsystems into separate patchsets. > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi > index 0e27c3375e2e..aae185b7f91c 100644 > --- a/arch/arm/boot/dts/samsung/exynos4210.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi > @@ -391,8 +391,14 @@ &cpu_alert2 { > }; > > &cpu_thermal { > - polling-delay-passive = <0>; > - polling-delay = <0>; > + /* Exynos 4210 supports thermal interrupts, but only for the rising threshold. Linux coding style comments are: /* * Foo bar Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi index 0e27c3375e2e..aae185b7f91c 100644 --- a/arch/arm/boot/dts/samsung/exynos4210.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi @@ -391,8 +391,14 @@ &cpu_alert2 { }; &cpu_thermal { - polling-delay-passive = <0>; - polling-delay = <0>; + /* Exynos 4210 supports thermal interrupts, but only for the rising threshold. + * This means that polling is not needed for preventing overheating, but only + * for decreasing cooling when possible. Hence we poll with a high delay. + * Ideally, we would disable polling for the first trip point, but this isn't + * really possible without outrageous hacks. + */ + polling-delay-passive = <5000>; + polling-delay = <5000>; }; &gic {
It seems that thermal in Exynos 4210 is broken without this, as it will never decrease cooling after increasing it. Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> --- arch/arm/boot/dts/samsung/exynos4210.dtsi | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)