| Message ID | 20230831182020.154863-1-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] arm64: dts: imx8mp: Describe VDD_ARM run and standby voltage for DH i.MX8M Plus DHCOM SoM | expand |
Hi Marek, On 23-08-31, Marek Vasut wrote: > Describe VDD_ARM (BUCK2) run and standby voltage in DT. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Frieder Schrempf <frieder.schrempf@kontron.de> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: Marek Vasut <marex@denx.de> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi > index cb1953d14aa90..1644b56c3953d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi > @@ -293,6 +293,8 @@ buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ > }; > > buck2: BUCK2 { /* VDD_ARM */ > + nxp,dvs-run-voltage = <950000>; Why do we need to set the "nxp,dvs-run-voltage"? If I read the driver correctly, then nxp,dvs-run-voltage and regulator-min/max-microvolt are touching the same register. Regards, Marco > + nxp,dvs-standby-voltage = <850000>; > regulator-min-microvolt = <850000>; > regulator-max-microvolt = <1000000>; > regulator-ramp-delay = <3125>; > -- > 2.40.1 > > >
On 9/7/23 17:45, Marco Felsch wrote: > Hi Marek, Hi, > On 23-08-31, Marek Vasut wrote: >> Describe VDD_ARM (BUCK2) run and standby voltage in DT. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: Conor Dooley <conor+dt@kernel.org> >> Cc: Fabio Estevam <festevam@gmail.com> >> Cc: Frieder Schrempf <frieder.schrempf@kontron.de> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> >> Cc: Magnus Damm <magnus.damm@gmail.com> >> Cc: Marek Vasut <marex@denx.de> >> Cc: NXP Linux Team <linux-imx@nxp.com> >> Cc: Peng Fan <peng.fan@nxp.com> >> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Sascha Hauer <s.hauer@pengutronix.de> >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: devicetree@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> --- >> arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi >> index cb1953d14aa90..1644b56c3953d 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi >> @@ -293,6 +293,8 @@ buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ >> }; >> >> buck2: BUCK2 { /* VDD_ARM */ >> + nxp,dvs-run-voltage = <950000>; > > Why do we need to set the "nxp,dvs-run-voltage"? If I read the driver > correctly, then nxp,dvs-run-voltage and regulator-min/max-microvolt are > touching the same register. My understanding is that the nxp,dvs-run-voltage selects the default regulator voltage which is configured early on once the regulator is detected in DT (see of_parse_cb callback in the PCA9450 regulator driver) and may be higher than regulator-min-microvolt, while later on DVFS can adjust the regulator in range of regulator-min-microvolt to regulator-max-microvolt . >> + nxp,dvs-standby-voltage = <850000>; >> regulator-min-microvolt = <850000>; >> regulator-max-microvolt = <1000000>; [...]
On 23-09-07, Marek Vasut wrote: > On 9/7/23 17:45, Marco Felsch wrote: > > Hi Marek, > > Hi, > > > On 23-08-31, Marek Vasut wrote: > > > Describe VDD_ARM (BUCK2) run and standby voltage in DT. > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > --- > > > Cc: Conor Dooley <conor+dt@kernel.org> > > > Cc: Fabio Estevam <festevam@gmail.com> > > > Cc: Frieder Schrempf <frieder.schrempf@kontron.de> > > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > > > Cc: Magnus Damm <magnus.damm@gmail.com> > > > Cc: Marek Vasut <marex@denx.de> > > > Cc: NXP Linux Team <linux-imx@nxp.com> > > > Cc: Peng Fan <peng.fan@nxp.com> > > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-arm-kernel@lists.infradead.org > > > --- > > > arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi > > > index cb1953d14aa90..1644b56c3953d 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi > > > @@ -293,6 +293,8 @@ buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ > > > }; > > > buck2: BUCK2 { /* VDD_ARM */ > > > + nxp,dvs-run-voltage = <950000>; > > > > Why do we need to set the "nxp,dvs-run-voltage"? If I read the driver > > correctly, then nxp,dvs-run-voltage and regulator-min/max-microvolt are > > touching the same register. > > My understanding is that the nxp,dvs-run-voltage selects the default > regulator voltage which is configured early on once the regulator is > detected in DT (see of_parse_cb callback in the PCA9450 regulator driver) > and may be higher than regulator-min-microvolt, while later on DVFS can > adjust the regulator in range of regulator-min-microvolt to > regulator-max-microvolt . Right, albeit I think that the bootloader already did the initialization once. Anyway the change lgtm: Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > > > + nxp,dvs-standby-voltage = <850000>; > > > regulator-min-microvolt = <850000>; > > > regulator-max-microvolt = <1000000>; > > [...] >
On Thu, Aug 31, 2023 at 08:20:17PM +0200, Marek Vasut wrote: > Describe VDD_ARM (BUCK2) run and standby voltage in DT. > > Signed-off-by: Marek Vasut <marex@denx.de> Applied all, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi index cb1953d14aa90..1644b56c3953d 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi @@ -293,6 +293,8 @@ buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ }; buck2: BUCK2 { /* VDD_ARM */ + nxp,dvs-run-voltage = <950000>; + nxp,dvs-standby-voltage = <850000>; regulator-min-microvolt = <850000>; regulator-max-microvolt = <1000000>; regulator-ramp-delay = <3125>;
Describe VDD_ARM (BUCK2) run and standby voltage in DT. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Conor Dooley <conor+dt@kernel.org> Cc: Fabio Estevam <festevam@gmail.com> Cc: Frieder Schrempf <frieder.schrempf@kontron.de> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Marek Vasut <marex@denx.de> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: Peng Fan <peng.fan@nxp.com> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Rob Herring <robh+dt@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++ 1 file changed, 2 insertions(+)