From patchwork Thu Aug 31 17:44:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Shavit X-Patchwork-Id: 13371765 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E37B3C83F37 for ; Thu, 31 Aug 2023 17:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+kMpK3/LbKEd7bKXYJ154H2ZU3KBGLH5Uzq9V4CClkE=; b=JBOIjI+MD5v5Q2Whflt2gqm0dq LLaoxi8D1nxUQoLFjIQsUb3CEl16ktm16RpF0gj9dVBwMS/LsXMsD4OyPKr3jz7Cqe2C5hHGyS+5a P3Uj/24+O6TB2B6KGKiaMmQBI2ZMhP+yvFL23iWUMBLtwz5wrJO8jFA4OZ/wFkYlwFbUm6LPqrG7v bsFYb4yxIOenM/jz6ZXoJ9S9pwK6Dfolyf0Ref+wbsbhzCnbspK+g3IZWRhT7a8NrJIf5/kTNfxBB z3vh0UF2ww+92z7PUqvnJ+gTl2AM/8aeSDl1/8+75XMcwc4aYqSdgWG82BCpZKgaVr/4FZ0diyaas 31tOibuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbll8-00Ff6F-2f; Thu, 31 Aug 2023 17:47:10 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qblkN-00Felv-2q for linux-arm-kernel@lists.infradead.org; Thu, 31 Aug 2023 17:46:25 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5924b2aac52so14094137b3.2 for ; Thu, 31 Aug 2023 10:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693503982; x=1694108782; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=97NbLwOzwX2yfBkjP3g3hHfcNULS8xoy6ngi79VwyiQ=; b=ESNmPRJBFsWa13cJJvy5Uih79ikqUF0m17a5+GV1+XoMVFTZCo3rt2ZXzSRYf4AsLx FjekbH36+ee0CyWX7/QTDyTAGsVPZq0Aq03B/cwAJ2Bc+gpORLeUtM1i4DUPwIyjJ3hT 81zneJwE9aPvOjKnJ0J9GGp/JJGMWBAU3N42PGpW58wC6qjZV9M31pxNA+3LkNwg9SEz V1DM/KXNXdODnAD+s0pbcxaWVJtQLlHtsWLu7lPJYtkU+TdAWm91RKfYvcZ9bCHfxcdx ZFuA1s9bfZIZUm78dHtuIDmkjLApibsMQG6FCGuzkSHETYZcd1Y+9a0dyI3kcLtRrONN E5Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693503982; x=1694108782; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=97NbLwOzwX2yfBkjP3g3hHfcNULS8xoy6ngi79VwyiQ=; b=cc3X5kN+dp7Vb4dOG4jrpQ25DzjF9MCdFvKPSjV/2UZUQ2ONh2/bs1fMZTIw9Ew50l C0WjVwO/2B49BAsbCE/RNFXu8hk38fSSRsXj+OjgIeO7PGBhAyLdLCUpdju+mL25MzFy B3nIrwq6/RUDgWMg4nGUlg7V/XlYPcx1BQGp0KEWcN7pze2oula+93e/p4dc+iKsH1M/ KYENdP4dU2DXw16IroBHztmA1fZNlVXzfzrCfOs2UrDKOhuw51ggt+3JyZLytLSHv4Ag Hz72ZU3URAL9L9aQ9q/6R80KIUIokbNMfQLNKxV+CxY0ueJVdfg8G06iwpwV4T63+Uej 9Daw== X-Gm-Message-State: AOJu0YySkKjeQC0OtUVnVDw7nNhk/WFptVEOCxchtQp6P5VUlRnyct2v T2xEvDa8HRMLP7M0cI7/blsZvFlWB3K2 X-Google-Smtp-Source: AGHT+IFnAn3Jgebhh43eiBoBmSBDyph6RaR6op6wjUZNKsymtjXCclD9kKZcfRwzPgCeOQNDjo1qmsyY58LY X-Received: from mshavit.ntc.corp.google.com ([2401:fa00:95:20c:1a0a:7338:4a5a:5f83]) (user=mshavit job=sendgmr) by 2002:a81:e40b:0:b0:592:8069:540a with SMTP id r11-20020a81e40b000000b005928069540amr2213ywl.8.1693503982384; Thu, 31 Aug 2023 10:46:22 -0700 (PDT) Date: Fri, 1 Sep 2023 01:44:37 +0800 In-Reply-To: <20230831174536.103472-1-mshavit@google.com> Mime-Version: 1.0 References: <20230831174536.103472-1-mshavit@google.com> X-Mailer: git-send-email 2.42.0.283.g2d96d420d3-goog Message-ID: <20230901014413.v7.8.I7a8beb615e2520ad395d96df94b9ab9708ee0d9c@changeid> Subject: [PATCH v7 8/9] iommu/arm-smmu-v3: Update comment about STE liveness From: Michael Shavit To: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: will@kernel.org, robin.murphy@arm.com, jean-philippe@linaro.org, jgg@nvidia.com, nicolinc@nvidia.com, Michael Shavit , Jason Gunthorpe , Joerg Roedel , Kevin Tian , "Kirill A. Shutemov" , Lu Baolu , Mark Brown , Yicong Yang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230831_104623_937116_761D4C8F X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Update the comment to reflect the fact that the STE is not always installed. arm_smmu_domain_finalise_s1 intentionnaly calls arm_smmu_write_ctx_desc while the STE is not installed. Reviewed-by: Nicolin Chen Reviewed-by: Jason Gunthorpe Signed-off-by: Michael Shavit --- (no changes since v6) Changes in v6: - New commit drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index 8d177ed550054..adede66621163 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -1091,7 +1091,7 @@ int arm_smmu_write_ctx_desc(struct arm_smmu_master *master, int ssid, cdptr[3] = cpu_to_le64(cd->mair); /* - * STE is live, and the SMMU might read dwords of this CD in any + * STE may be live, and the SMMU might read dwords of this CD in any * order. Ensure that it observes valid values before reading * V=1. */