| Message ID | 20230906115444.189664-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] arm64: dts: imx8mp: Move funnel outside from soc | expand |
Hi Fabio, Am Mittwoch, 6. September 2023, 13:54:43 CEST schrieb Fabio Estevam: > From: Fabio Estevam <festevam@denx.de> > > The 'funnel' node does not contain a register range, so it should > be placed outside of the soc node to fix schema warnings from > simple-bus.yaml. > > Signed-off-by: Fabio Estevam <festevam@denx.de> I noticed the warning in dtbs_check as well. LGTM Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 107 +++++++++++----------- > 1 file changed, 54 insertions(+), 53 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index > 6f2f50e1639c..ee92043a4052 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -202,6 +202,60 @@ clk_ext4: clock-ext4 { > clock-output-names = "clk_ext4"; > }; > > + funnel { > + /* > + * non-configurable funnel don't show up on the AMBA > + * bus. As such no need to add "arm,primecell". > + */ > + compatible = "arm,coresight-static-funnel"; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + ca_funnel_in_port0: endpoint { > + remote-endpoint = <&etm0_out_port>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + ca_funnel_in_port1: endpoint { > + remote-endpoint = <&etm1_out_port>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + > + ca_funnel_in_port2: endpoint { > + remote-endpoint = <&etm2_out_port>; > + }; > + }; > + > + port@3 { > + reg = <3>; > + > + ca_funnel_in_port3: endpoint { > + remote-endpoint = <&etm3_out_port>; > + }; > + }; > + }; > + > + out-ports { > + port { > + > + ca_funnel_out_port0: endpoint { > + remote-endpoint = <&hugo_funnel_in_port0>; > + }; > + }; > + }; > + }; > + > reserved-memory { > #address-cells = <2>; > #size-cells = <2>; > @@ -368,59 +422,6 @@ etm3_out_port: endpoint { > }; > }; > > - funnel { > - /* > - * non-configurable funnel don't show up on the AMBA > - * bus. As such no need to add "arm,primecell". > - */ > - compatible = "arm,coresight-static-funnel"; > - > - in-ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - > - ca_funnel_in_port0: endpoint { > - remote-endpoint = <&etm0_out_port>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - > - ca_funnel_in_port1: endpoint { > - remote-endpoint = <&etm1_out_port>; > - }; > - }; > - > - port@2 { > - reg = <2>; > - > - ca_funnel_in_port2: endpoint { > - remote-endpoint = <&etm2_out_port>; > - }; > - }; > - > - port@3 { > - reg = <3>; > - > - ca_funnel_in_port3: endpoint { > - remote-endpoint = <&etm3_out_port>; > - }; > - }; > - }; > - > - out-ports { > - port { > - ca_funnel_out_port0: endpoint { > - remote-endpoint = <&hugo_funnel_in_port0>; > - }; > - }; > - }; > - }; > - > funnel@28c03000 { > compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > reg = <0x28c03000 0x1000>;
On Wed, Sep 06, 2023 at 08:54:43AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The 'funnel' node does not contain a register range, so it should > be placed outside of the soc node to fix schema warnings from > simple-bus.yaml. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied both, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index 6f2f50e1639c..ee92043a4052 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -202,6 +202,60 @@ clk_ext4: clock-ext4 { clock-output-names = "clk_ext4"; }; + funnel { + /* + * non-configurable funnel don't show up on the AMBA + * bus. As such no need to add "arm,primecell". + */ + compatible = "arm,coresight-static-funnel"; + + in-ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + ca_funnel_in_port0: endpoint { + remote-endpoint = <&etm0_out_port>; + }; + }; + + port@1 { + reg = <1>; + + ca_funnel_in_port1: endpoint { + remote-endpoint = <&etm1_out_port>; + }; + }; + + port@2 { + reg = <2>; + + ca_funnel_in_port2: endpoint { + remote-endpoint = <&etm2_out_port>; + }; + }; + + port@3 { + reg = <3>; + + ca_funnel_in_port3: endpoint { + remote-endpoint = <&etm3_out_port>; + }; + }; + }; + + out-ports { + port { + + ca_funnel_out_port0: endpoint { + remote-endpoint = <&hugo_funnel_in_port0>; + }; + }; + }; + }; + reserved-memory { #address-cells = <2>; #size-cells = <2>; @@ -368,59 +422,6 @@ etm3_out_port: endpoint { }; }; - funnel { - /* - * non-configurable funnel don't show up on the AMBA - * bus. As such no need to add "arm,primecell". - */ - compatible = "arm,coresight-static-funnel"; - - in-ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - reg = <0>; - - ca_funnel_in_port0: endpoint { - remote-endpoint = <&etm0_out_port>; - }; - }; - - port@1 { - reg = <1>; - - ca_funnel_in_port1: endpoint { - remote-endpoint = <&etm1_out_port>; - }; - }; - - port@2 { - reg = <2>; - - ca_funnel_in_port2: endpoint { - remote-endpoint = <&etm2_out_port>; - }; - }; - - port@3 { - reg = <3>; - - ca_funnel_in_port3: endpoint { - remote-endpoint = <&etm3_out_port>; - }; - }; - }; - - out-ports { - port { - ca_funnel_out_port0: endpoint { - remote-endpoint = <&hugo_funnel_in_port0>; - }; - }; - }; - }; - funnel@28c03000 { compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; reg = <0x28c03000 0x1000>;