| Message ID | 20230909013547.958134-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells | expand |
Hi Fabio, thanks for the fix. On 23-09-08, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The mac-address is passed as a subnode of the eeprom and its 'reg' > property describe a range of addresses in the eeprom. > > Therefore, #size-cells should be set to 1 instead of 0. > > This fixes the following schema warnings: > > imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: #size-cells:0:0: 1 was expected > from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# > imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@0:reg: [[0], [12]] is too long > from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# > imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@c:reg: [[12], [12]] is too long > from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# > imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mac-address@0', 'mac-address@c' were unexpected) > from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
On Fri, Sep 08, 2023 at 10:35:47PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The mac-address is passed as a subnode of the eeprom and its 'reg' > property describe a range of addresses in the eeprom. > > Therefore, #size-cells should be set to 1 instead of 0. > > This fixes the following schema warnings: > > imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: #size-cells:0:0: 1 was expected > from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# > imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@0:reg: [[0], [12]] is too long > from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# > imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@c:reg: [[12], [12]] is too long > from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# > imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mac-address@0', 'mac-address@c' were unexpected) > from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts index 0b0c95432bdc..0afd90224a59 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts @@ -220,7 +220,7 @@ eeprom@52 { reg = <0x52>; pagesize = <16>; #address-cells = <1>; - #size-cells = <0>; + #size-cells = <1>; /* MACs stored in ASCII */ ethmac1: mac-address@0 {