| Message ID | 20230911074233.31556-21-shawn.sung@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add display driver for MT8188 VDOSYS1 | expand |
Il 11/09/23 09:42, Hsiao Chien Sung ha scritto: > DPI input is in 1T2P mode on MT8195, > align the setting of MT8188 with it, > otherwise the screen will glitch. > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> First of all, this commit needs a Fixes tag... but then, instead of getting a 1:1 duplicate of mt8195_dpintf_conf you can, at this point, entirely remove mt8188_dpintf_conf and assign the 8195 one to the 8188 compatible: please do so. Thanks, Angelo > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 2f931e4e2b60..c6ee21e275ba 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -963,7 +963,7 @@ static const struct mtk_dpi_conf mt8188_dpintf_conf = { > .output_fmts = mt8195_output_fmts, > .num_output_fmts = ARRAY_SIZE(mt8195_output_fmts), > .pixels_per_iter = 4, > - .input_2pixel = false, > + .input_2pixel = true, > .dimension_mask = DPINTF_HPW_MASK, > .hvsize_mask = DPINTF_HSIZE_MASK, > .channel_swap_shift = DPINTF_CH_SWAP, > -- > 2.18.0 >
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 2f931e4e2b60..c6ee21e275ba 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -963,7 +963,7 @@ static const struct mtk_dpi_conf mt8188_dpintf_conf = { .output_fmts = mt8195_output_fmts, .num_output_fmts = ARRAY_SIZE(mt8195_output_fmts), .pixels_per_iter = 4, - .input_2pixel = false, + .input_2pixel = true, .dimension_mask = DPINTF_HPW_MASK, .hvsize_mask = DPINTF_HSIZE_MASK, .channel_swap_shift = DPINTF_CH_SWAP,
DPI input is in 1T2P mode on MT8195, align the setting of MT8188 with it, otherwise the screen will glitch. Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0