| Message ID | 20230915071106.3347-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tty: serial: ma35d1_serial: Add missing check for ioremap | expand |
On 2023/9/15 下午 03:11, Chen Ni wrote: > CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content. > > > Add check for ioremap() and return the error if it fails in order to > guarantee the success of ioremap(). > > Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support") > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/tty/serial/ma35d1_serial.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c > index 465b1def9e11..4a9d1252de35 100644 > --- a/drivers/tty/serial/ma35d1_serial.c > +++ b/drivers/tty/serial/ma35d1_serial.c > @@ -695,6 +695,9 @@ static int ma35d1serial_probe(struct platform_device *pdev) > > up->port.iobase = res_mem->start; > up->port.membase = ioremap(up->port.iobase, MA35_UART_REG_SIZE); > + if (!up->port.membase) > + return -ENOMEM; > + > up->port.ops = &ma35d1serial_ops; > > spin_lock_init(&up->port.lock); > -- > 2.25.1 > Thank you for this update. Acked-by: Jacky Huang <ychuang3@nuvoton.com> Best Regards, Jacky
diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c index 465b1def9e11..4a9d1252de35 100644 --- a/drivers/tty/serial/ma35d1_serial.c +++ b/drivers/tty/serial/ma35d1_serial.c @@ -695,6 +695,9 @@ static int ma35d1serial_probe(struct platform_device *pdev) up->port.iobase = res_mem->start; up->port.membase = ioremap(up->port.iobase, MA35_UART_REG_SIZE); + if (!up->port.membase) + return -ENOMEM; + up->port.ops = &ma35d1serial_ops; spin_lock_init(&up->port.lock);
Add check for ioremap() and return the error if it fails in order to guarantee the success of ioremap(). Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/tty/serial/ma35d1_serial.c | 3 +++ 1 file changed, 3 insertions(+)