From patchwork Fri Sep 15 13:17:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Shavit X-Patchwork-Id: 13387068 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69682EE645C for ; Fri, 15 Sep 2023 13:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=9T5KotssrHVcVOxv/8Tcsz7YcRsSCIfA9Jp6i4yW178=; b=WpibOTj0XtIc3AWG2LwXmmZNd2 9FRQDOyRAHwRjnvk8Pn1eBHlyz2Nz5lwTPKFQYpkHsIH9eSIeW5MJbJkde/j9ps7o4mz8WctUfewZ EUswhI+CG919/xeNy1dOyI00cjsH4mK6iGF7Ya7OT8AbNxmX/Xj4eySGFjk5cXcfNCt1VSR7lBWH0 3Y7nd1PTOmTgdIlRFxYXiNKsIEIg/MrxKNlbzo8T6jvZ6AB5JhsTgPdafMyk0veWpVsQDD69BcV2W 9dyTZf/b3AOMIlZd3PtZm0Qn0XFMIagF0ZNpjpoeu/nJRVs1iSDJx+otyqQY+hyq7tRm6P7G+NaFK 5OTwVv8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qh8lS-00Anno-06; Fri, 15 Sep 2023 13:21:42 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qh8lL-00Anje-1R for linux-arm-kernel@lists.infradead.org; Fri, 15 Sep 2023 13:21:36 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-59b5d4a8242so27044297b3.0 for ; Fri, 15 Sep 2023 06:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694784094; x=1695388894; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=HnObA/kZmhyC99jO+R9W14le1Eiuc2fMp54pXjmpHL4=; b=k++xWerhkfzf4uk6gdV2u6K55wIhWWaypM28eK9sHE/idR8S2Vll/afrRExlvdDzQr 0aQu4xUw5OU+KqHuU2dE59x7jAplcvxorGhpK8Ps1lzMfuwob0a32pSEPDh0tOX7k1A4 fuA2kw1Gg8VDUe0Mu1wuSWH9aOOfk2Ttn9fRkM3U90VcEg0sTg/uELpKjqvrHpDSXzn8 sGPmp3cDYaVhYyvNc5mOaLoCC/rSBYnxt+slFXoOiog1DgvbdcQKaY+J9BDUo2qbXkKZ nq2hqLHjR6BCicCWVuibS4S31Gk8pJBlNervNUYaPqS8eQTg97r4k3pNjGtNGqquzjhn VWbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694784094; x=1695388894; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HnObA/kZmhyC99jO+R9W14le1Eiuc2fMp54pXjmpHL4=; b=RH3OYfne6XSwmHM67w0cLmWkS/h83kA1dUg2Zkf1XU+ftgjPTLo6na+7nWIo9+E4BW 3HSgAk5a9X6+ZgAVu7TsgvksEkE1wpoIq3A3BOCSptegfUjE0sUL4rhnpLPKK45ONH5f KrFo4RgMRH4ahD0cBHt/8Igh08aEXStSW6d6s7LFW8OR2s6EptwPa/W/aagAYwtqLaRl IuhlW5fOQolkpCKQjDYp/ElKlENYnMRZjvAHIx9wFVEBzZpMckhnfAAAJq73njUrrKri /2CzlR86bNbeDp76Izc7ROs3aZTnDb+ojoHt4JtAAoNmSZeQZ/pGPxxaJ/8yGNv5We6B qVbQ== X-Gm-Message-State: AOJu0Yxgw89VvHrkkTFBFqxuD2OdetZcGqkBIkxU05OLpRCNzFRpnfz7 iFzAaeEid5rxcVJEmIkNoJ5MDYdFNEcT X-Google-Smtp-Source: AGHT+IHyk/sqE5aZccgTBXt08m7PCIRAy+acYkivPYOmlI58JYhGiCdcp65xDmKbHdJDgO6y9+7t5EQ2s/Xo X-Received: from mshavit.ntc.corp.google.com ([2401:fa00:95:20c:47bc:d53f:1c50:a3f2]) (user=mshavit job=sendgmr) by 2002:a25:ab0d:0:b0:d7e:8dee:7813 with SMTP id u13-20020a25ab0d000000b00d7e8dee7813mr34021ybi.8.1694784094306; Fri, 15 Sep 2023 06:21:34 -0700 (PDT) Date: Fri, 15 Sep 2023 21:17:39 +0800 In-Reply-To: <20230915132051.2646055-1-mshavit@google.com> Mime-Version: 1.0 References: <20230915132051.2646055-1-mshavit@google.com> X-Mailer: git-send-email 2.42.0.459.ge4e396fd5e-goog Message-ID: <20230915211705.v8.8.I7a8beb615e2520ad395d96df94b9ab9708ee0d9c@changeid> Subject: [PATCH v8 8/9] iommu/arm-smmu-v3: Update comment about STE liveness From: Michael Shavit To: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: nicolinc@nvidia.com, jgg@nvidia.com, jean-philippe@linaro.org, robin.murphy@arm.com, will@kernel.org, Michael Shavit , Alistair Popple , Dawei Li , Jacob Pan , Jason Gunthorpe , Joerg Roedel , Kevin Tian , "Kirill A. Shutemov" , Lu Baolu , Tomas Krcka X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_062135_487361_513BEC3C X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Update the comment to reflect the fact that the STE is not always installed. arm_smmu_domain_finalise_s1 intentionnaly calls arm_smmu_write_ctx_desc while the STE is not installed. Reviewed-by: Nicolin Chen Reviewed-by: Jason Gunthorpe Signed-off-by: Michael Shavit --- (no changes since v6) Changes in v6: - New commit drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index f9bfa2c8ab1e3..86e4e2df9e2fa 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -1091,7 +1091,7 @@ int arm_smmu_write_ctx_desc(struct arm_smmu_master *master, int ssid, cdptr[3] = cpu_to_le64(cd->mair); /* - * STE is live, and the SMMU might read dwords of this CD in any + * STE may be live, and the SMMU might read dwords of this CD in any * order. Ensure that it observes valid values before reading * V=1. */