Message ID | 20230919133207.1400430-32-u.kleine-koenig@pengutronix.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38201CD5BBF for <linux-arm-kernel@archiver.kernel.org>; Tue, 19 Sep 2023 13:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dSlyepZSZHGLYMBlEOL9aLNyjv7PjBvXUrjcyxRtwhU=; b=A2b/4unzfPhvyj pLLoLtI8RRsGlYnrgCXcBIM5j399RzYk+Dh19mX1J827OM5RSQfaVYE7NDzPgJGVY+UrcNVn8zEBk UMtCp7Ge7v7XKT+xqt+HOaJLMuEvCORcPnROPF6h3/b3BE+GrfrZkXeSDPDThegYLOLxQiX8LKbQI bHnwG9cbWUM3QFKufhO3pTL/FajkNtcYhjlgwO8B93iZfs5qpXrMiEMt2HX+f8BKcHYN/CyO23vkR tz8wjK91JnKHlOWkdflJiopGHYS1kuBx36RR+wCCg992EbF+93fMVtPNVlkrSvHIzbhrMUn+92oU9 fKXc8De7KyzFjmIbm2Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiaqF-000WUL-24; Tue, 19 Sep 2023 13:32:39 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiaq0-000WIw-0B for linux-arm-kernel@lists.infradead.org; Tue, 19 Sep 2023 13:32:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1qiapu-0004vU-EJ; Tue, 19 Sep 2023 15:32:18 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1qiapt-007T4f-OT; Tue, 19 Sep 2023 15:32:17 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1qiapt-0030fU-Aj; Tue, 19 Sep 2023 15:32:17 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Vinod Koul <vkoul@kernel.org> Cc: =?utf-8?q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Manivannan Sadhasivam <mani@kernel.org>, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 31/59] dma: owl-dma: Convert to platform remove callback returning void Date: Tue, 19 Sep 2023 15:31:39 +0200 Message-Id: <20230919133207.1400430-32-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230919133207.1400430-1-u.kleine-koenig@pengutronix.de> References: <20230919133207.1400430-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1684; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=oOZXmk+cA7NyUUQsE5sqJFm+83NftNjhIquYm4zw3ns=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlTOhZdE/hwvv2pv2n7SS8ez9kyTdYDhgzn9bvJ55yV4s /qFQ7I6GY1ZGBi5GGTFFFnsG9dkWlXJRXau/XcZZhArE8gUBi5OAZhIdzL7f7eGGtEaj3xxXTMe V8E95/ZrZJZaH7zK4V9/2Klx5fq2PRG2p776FU6anqg3v1O2Q1aM7ZG3aLRAb6d9l8yzpyZ7Jxr NX1r6x8P+iMcl4wkyTuLcmXoPl60TOif0/YOzbcnkx/s/zfZxuZA9dX+aycH5z59O/3Qh+pmGTl dsRa512bxrDG1qQkwsvGGWz8sqfs+oyH5oEvNvlVsYL0fKy5UKzvrBLBInbm48XhBwxlRJgj8vk 0GdIVO/V+ruqvBuw+c3XpXl3Fohv/Mdl3xuT/b3nBmbI20Tk/s8Jm+vVnQ1ZMx/2RR2eHN10O8J XY79GSZ5nL/MtAubuy/ph5nu+LD5yIXUN3oNqmXTnwIA X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230919_063224_096073_BCB1E94E X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
None
|
expand
|
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index 384476757c5e..4e76c4ec2d39 100644 --- a/drivers/dma/owl-dma.c +++ b/drivers/dma/owl-dma.c @@ -1231,7 +1231,7 @@ static int owl_dma_probe(struct platform_device *pdev) return ret; } -static int owl_dma_remove(struct platform_device *pdev) +static void owl_dma_remove(struct platform_device *pdev) { struct owl_dma *od = platform_get_drvdata(pdev); @@ -1248,13 +1248,11 @@ static int owl_dma_remove(struct platform_device *pdev) clk_disable_unprepare(od->clk); dma_pool_destroy(od->lli_pool); - - return 0; } static struct platform_driver owl_dma_driver = { .probe = owl_dma_probe, - .remove = owl_dma_remove, + .remove_new = owl_dma_remove, .driver = { .name = "dma-owl", .of_match_table = of_match_ptr(owl_dma_match),
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/dma/owl-dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)