From patchwork Wed Sep 20 19:10:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13393260 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A791C04FEF for ; Wed, 20 Sep 2023 19:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=85s3j1jyknJiMkAbfURHN757lpQshvSMdsX/NOCJ114=; b=othIsATu1Ntcik sjRdVRjNyBFKhIvVAWVVAPA8slkoWOM0PFLR2hyE6oVGIsmGj5kwSgXkTh0DJtTaryl7uLrcAXm/o cki5vgso2CEzDrgklrDCNbkwfwD2ku5oqofjZUTWzgTVAt15r8XVzbXuZEp664CuheJ1lnnXtP7Zx LBWuQdKKRLIfXXMw7U39DAhgDffKMrVdgB1eq5DdHvMQMZurytBBqGCyWtED57Mb8byZ3nKw3GAq0 NquIzm+ZEh0aw8n2G0hk0RwJDEH2XvyBkYlE6iw19D+gEPWWmaxejVQrQKXaPJRoK8bW86jNfPIb9 kavOWBzDN7m6nKdvxOOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qj2cK-003xIs-2y; Wed, 20 Sep 2023 19:12:08 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qj2by-003x0i-0Q for linux-arm-kernel@lists.infradead.org; Wed, 20 Sep 2023 19:11:47 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-503012f4e71so1549873e87.0 for ; Wed, 20 Sep 2023 12:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695237102; x=1695841902; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EgoOFuIOH/yTjnEmwXNjUQs0ssos4vCiXDfBrtR+jUo=; b=VmIm4Z8HQ2vR3T+4mW6oyicu3s5+ReuvxCh4bJ2gqnQJFxwmRja9qPiO0tFDx9EJxI Egi/AfaR2utLLiB/MgXkiLWVod7vWgE1ly0ces3StcGfuGr937y2Fo9lnuYLLyfwgy6O eBNwNkb8XhKtQJv14OnDyKiO1WcstiZ21ZneIIDBEi4q3H+TKN0ohsNIW2Zj8Tpichvt Wzn8jYIVJEEM//KVpACV+nfSGl5MQcFtvtsiZPwU7cgb6e3YorYOGj+7/Vf7pBR41DkP yyNpSbaGP1ZhnY07d7dByMKLgLx1tEqrQyhLEsa/va/VNvdD6b89xUuu2SxWkD/0XYtr 7e3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695237102; x=1695841902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EgoOFuIOH/yTjnEmwXNjUQs0ssos4vCiXDfBrtR+jUo=; b=nrdpt6OsBbPMe4/Y4NmUyVVjlKaWbclCXlcD56RA/6GRFhS0vnoX37N2nw9y+JJ0nq II88cJr0bMbdjgUPQvAMsERWE2iItcp/1ONS3VeCqJ2tOu2xY+QcGLOrIRK6wCKsAq3W sjsyrci6ic3i8gdFhrf3M81oHSqzKNPbJEW9XVVgZBgJg3liO2UVKFmlblrYjXCXCMwR pgsnjowCy15v3q1IKH5REX8uQcp1CVaHmHO+Xg9iP8PsVjvpL4YmGpoWrFALD5r4WW4+ we3JUFVOAb6PaPBmkTiDjREZF7qYqXryvcHxv0W4SQ2CVlkea/8H9vq46KJnxMEwTHYE //lQ== X-Gm-Message-State: AOJu0Yz4YN3FOYY6fRl15HkT7Px4FXNWLIiWWhH6VD8d7V6xfKEuJIdm Ii01LFB9yTp7jlMZbN4kfi4= X-Google-Smtp-Source: AGHT+IFMiafOQ/yXgxqpUJDVLbYEs4mqVu/8ZemDTcrkOcKti8HCwKXib/arZc0C8dMF9giPBdSSYA== X-Received: by 2002:a05:6512:10d0:b0:500:c00e:8f15 with SMTP id k16-20020a05651210d000b00500c00e8f15mr2512617lfg.16.1695237102034; Wed, 20 Sep 2023 12:11:42 -0700 (PDT) Received: from localhost ([85.26.234.178]) by smtp.gmail.com with ESMTPSA id b28-20020a056512025c00b00503258fa962sm1049905lfo.199.2023.09.20.12.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 12:11:41 -0700 (PDT) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 08/20] EDAC/synopsys: Drop internal CE and UE counters Date: Wed, 20 Sep 2023 22:10:32 +0300 Message-ID: <20230920191059.28395-9-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230920191059.28395-1-fancer.lancer@gmail.com> References: <20230920191059.28395-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230920_121146_302916_F06C3A36 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org First of all these counters aren't exposed anyhow from the driver. Secondly the EDAC core already tracks the total amount of the correctable and uncorrectable errors (see mem_ctl_info.{ce_mc,ue_mc} fields usage). Drop the useless internal counters then for good. Signed-off-by: Serge Semin --- Changelog v4: - Drop redundant empty line. - Drop private counters access from the check_errors() method too. --- drivers/edac/synopsys_edac.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index afe9f475cb4e..c2ac2eb64642 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -305,8 +305,6 @@ struct synps_ecc_status { * @message: Buffer for framing the event specific info. * @stat: ECC status information. * @p_data: Platform data. - * @ce_cnt: Correctable Error count. - * @ue_cnt: Uncorrectable Error count. * @poison_addr: Data poison address. * @row_shift: Bit shifts for row bit. * @col_shift: Bit shifts for column bit. @@ -320,8 +318,6 @@ struct synps_edac_priv { char message[SYNPS_EDAC_MSG_SIZE]; struct synps_ecc_status stat; const struct synps_platform_data *p_data; - u32 ce_cnt; - u32 ue_cnt; #ifdef CONFIG_EDAC_DEBUG ulong poison_addr; u32 row_shift[18]; @@ -593,13 +589,8 @@ static irqreturn_t intr_handler(int irq, void *dev_id) if (status) return IRQ_NONE; - priv->ce_cnt += priv->stat.ce_cnt; - priv->ue_cnt += priv->stat.ue_cnt; handle_error(mci, &priv->stat); - edac_dbg(3, "Total error count CE %d UE %d\n", - priv->ce_cnt, priv->ue_cnt); - if (priv->p_data->quirks & SYNPS_ZYNQMP_IRQ_REGS) writel(regval, priv->baseaddr + DDR_QOS_IRQ_STAT_OFST); @@ -625,12 +616,7 @@ static void check_errors(struct mem_ctl_info *mci) if (status) return; - priv->ce_cnt += priv->stat.ce_cnt; - priv->ue_cnt += priv->stat.ue_cnt; handle_error(mci, &priv->stat); - - edac_dbg(3, "Total error count CE %d UE %d\n", - priv->ce_cnt, priv->ue_cnt); } /**