From patchwork Sun Sep 24 19:25:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 13397065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 894B7CE7A88 for ; Sun, 24 Sep 2023 19:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sHQhhCc8sr6wKtYEjVXrTVsynopSNFCCsQdfSyhUaSQ=; b=bjaCXd3Spbglgv ppicu9SNMe/riylSDL9rRIY2BJrik01cTcQozRRfNQxV29cmt1ZahVreG7+5Kuv6/LFbYfmmv2Ff4 A1ZlCxSexewPTxxs1ZOL5OL3XkhHsqord0qA58dr031STdX3EVQCDrH3yBzXYBeNIznLWCYzb1o9u qq4NnkRLnLVWRQgvJA8enbJAO3t3q9LZZQ7f5Y0PnLLwB/T00sE/LmVcD8KI7Xahf9l/a28fFvTPT aNnJ1xLnupAtE02x92Qh37LBFckwH6AyVRtweD0gRynx8ota0hVZzRbvKm60/lXSwNLhm5Z8jD/HQ B78Z++MLi6bDBifSDtig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkUkJ-00CgXq-2u; Sun, 24 Sep 2023 19:26:23 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkUkB-00CgTa-1o for linux-arm-kernel@lists.infradead.org; Sun, 24 Sep 2023 19:26:17 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9adb9fa7200so1197794366b.0 for ; Sun, 24 Sep 2023 12:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695583574; x=1696188374; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d66F58Zyq56V9Vs4Hyo0TkmljKT89gyNoM7Khlph/EE=; b=SnRC5k2qZdx9yRGg8jZJRqrpwyTtkLw12rlEZb+N8TQQ4eWSoPRn4IW0AQ0OQedOP/ HmPoBrbeWWetwOz9E1KhLofNdyz0CeAECJbespsizmPYZt1AJ1rf+tciuyNOSuj37aEY Cpx3SWIgUqYiNXFGWcKKBD4CE+De+02dECsjzfVIIGCWEz2KJInSOJV2DjDBtM6z+CEG 9CdrWIzAL1kc3LFLXemLRVLPWTxYqKZ5pU2LTHv1BfcHxouuCIsBevXIvGdOXsvZ1AG7 IfXblQPkv4FyO+JmmyBHDqErStioIUi/9S3uw4JAS44qA3h7pGvCzkwa/vKNJ+tpTBNg zzww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695583574; x=1696188374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d66F58Zyq56V9Vs4Hyo0TkmljKT89gyNoM7Khlph/EE=; b=t79Ttf2IDO6kg4WYEE5sAJxH+KGF8sxKFX8alLO7wH2Oi5kez13olwdKJUoZ3+HpHQ gbHJeijyWlSQKDlBHfSXy7St2EI8HWgwPEWRF8EcPS2Ud3CG/VFnQLjt4AdWB4S2Z6lh Fy+5/yDYhGBOngmpW1zerbBo8Rr7P79p5NSF9/cDnrHAAsGmZLWBxx1xpdJm5cRcmzxj EAv0FL8MZxaJafa20CBjpy8RtzbB8sWItDtV5hkV4sRChSilqx2YgsIZIXemwTAwRxNY 8nOcCMODgaXRfdyh//S9YWC7IzoBiwYiv5/9E4VnhiBz4wo0bT/qdwNibZKlDZdlta6y UqGg== X-Gm-Message-State: AOJu0Ywu+FY962SUmuWfyxJf/pf14rYC3dX7hoY9GoXo/jwFp0MurIKD 6qNzNHgDZZDPKuIMiosEq0I= X-Google-Smtp-Source: AGHT+IGtAxBgqINvPVkn897Kub7Z+3KXI91OPf9r4wroQNRiKNPXXt+0g0rub6eEA+V8/peXL8DyGw== X-Received: by 2002:a17:906:74d3:b0:9ae:614e:4560 with SMTP id z19-20020a17090674d300b009ae614e4560mr7802850ejl.29.1695583573619; Sun, 24 Sep 2023 12:26:13 -0700 (PDT) Received: from localhost.localdomain (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id z21-20020a1709063a1500b0099d0c0bb92bsm5317632eje.80.2023.09.24.12.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 12:26:13 -0700 (PDT) From: Jernej Skrabec To: mripard@kernel.org, wens@csie.org Cc: airlied@gmail.com, daniel@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH 1/7] drm/sun4i: dw-hdmi: Deinit PHY in fail path Date: Sun, 24 Sep 2023 21:25:58 +0200 Message-ID: <20230924192604.3262187-2-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230924192604.3262187-1-jernej.skrabec@gmail.com> References: <20230924192604.3262187-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230924_122615_598740_26EA6758 X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 9bf3797796f5 ("drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device") removed code for PHY deinitialization in fail path. Add it back. Fixes: 9bf3797796f5 ("drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device") Signed-off-by: Jernej Skrabec Acked-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index 4727dfaa8fb9..0b647b030b15 100644 --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c @@ -203,6 +203,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, cleanup_encoder: drm_encoder_cleanup(encoder); + sun8i_hdmi_phy_deinit(hdmi->phy); err_disable_clk_tmds: clk_disable_unprepare(hdmi->clk_tmds); err_assert_ctrl_reset: