| Message ID | 20230925081332.15906-6-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: ti: k3-j7: Add the ESM & main domain watchdog nodes | expand |
On 13:43-20230925, Keerthy wrote: > There are totally 2 instances of watchdog module in MCU domain. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > index a7b5c4cb7d3e..0b7cc277a567 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > @@ -714,4 +714,24 @@ > ti,esm-pins = <63>; > bootph-pre-ram; > }; > + > + mcu_watchdog0: watchdog@40600000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x40600000 0x00 0x100>; > + clocks = <&k3_clks 367 1>; > + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 367 0>; > + assigned-clock-parents = <&k3_clks 367 4>; > + status = "disabled"; > + }; > + > + mcu_watchdog1: watchdog@40610000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x40610000 0x00 0x100>; > + clocks = <&k3_clks 368 1>; > + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 368 0>; > + assigned-clock-parents = <&k3_clks 368 4>; > + status = "disabled"; Explain in commit message as to why these are disabled. I believe it is because this RTI instances are tightly coupled to the micro controllers. but that information needs to be documented. > + }; > }; > -- > 2.17.1 >
On 9/25/2023 6:49 PM, Nishanth Menon wrote: > On 13:43-20230925, Keerthy wrote: >> There are totally 2 instances of watchdog module in MCU domain. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> index a7b5c4cb7d3e..0b7cc277a567 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> @@ -714,4 +714,24 @@ >> ti,esm-pins = <63>; >> bootph-pre-ram; >> }; >> + >> + mcu_watchdog0: watchdog@40600000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x40600000 0x00 0x100>; >> + clocks = <&k3_clks 367 1>; >> + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 367 0>; >> + assigned-clock-parents = <&k3_clks 367 4>; >> + status = "disabled"; >> + }; >> + >> + mcu_watchdog1: watchdog@40610000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x40610000 0x00 0x100>; >> + clocks = <&k3_clks 368 1>; >> + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 368 0>; >> + assigned-clock-parents = <&k3_clks 368 4>; >> + status = "disabled"; > > Explain in commit message as to why these are disabled. I believe it is > because this RTI instances are tightly coupled to the micro > controllers. but that information needs to be documented. Sure. I will add that to the commit message. >> + }; >> }; >> -- >> 2.17.1 >> >
On 21:03-20230925, J, KEERTHY wrote: > > > On 9/25/2023 6:49 PM, Nishanth Menon wrote: > > On 13:43-20230925, Keerthy wrote: > > > There are totally 2 instances of watchdog module in MCU domain. > > > > > > Signed-off-by: Keerthy <j-keerthy@ti.com> > > > --- > > > .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++ > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > index a7b5c4cb7d3e..0b7cc277a567 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > @@ -714,4 +714,24 @@ > > > ti,esm-pins = <63>; > > > bootph-pre-ram; > > > }; > > > + > > > + mcu_watchdog0: watchdog@40600000 { > > > + compatible = "ti,j7-rti-wdt"; > > > + reg = <0x00 0x40600000 0x00 0x100>; > > > + clocks = <&k3_clks 367 1>; > > > + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; > > > + assigned-clocks = <&k3_clks 367 0>; > > > + assigned-clock-parents = <&k3_clks 367 4>; > > > + status = "disabled"; > > > + }; > > > + > > > + mcu_watchdog1: watchdog@40610000 { > > > + compatible = "ti,j7-rti-wdt"; > > > + reg = <0x00 0x40610000 0x00 0x100>; > > > + clocks = <&k3_clks 368 1>; > > > + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; > > > + assigned-clocks = <&k3_clks 368 0>; > > > + assigned-clock-parents = <&k3_clks 368 4>; > > > + status = "disabled"; > > > > Explain in commit message as to why these are disabled. I believe it is > > because this RTI instances are tightly coupled to the micro > > controllers. but that information needs to be documented. > > Sure. I will add that to the commit message. And inline to code for context, please.
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi index a7b5c4cb7d3e..0b7cc277a567 100644 --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi @@ -714,4 +714,24 @@ ti,esm-pins = <63>; bootph-pre-ram; }; + + mcu_watchdog0: watchdog@40600000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x40600000 0x00 0x100>; + clocks = <&k3_clks 367 1>; + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 367 0>; + assigned-clock-parents = <&k3_clks 367 4>; + status = "disabled"; + }; + + mcu_watchdog1: watchdog@40610000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x40610000 0x00 0x100>; + clocks = <&k3_clks 368 1>; + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 368 0>; + assigned-clock-parents = <&k3_clks 368 4>; + status = "disabled"; + }; };
There are totally 2 instances of watchdog module in MCU domain. Signed-off-by: Keerthy <j-keerthy@ti.com> --- .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)