From patchwork Mon Sep 25 09:22:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hubert Mazur X-Patchwork-Id: 13397564 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BA7ECE7A89 for ; Mon, 25 Sep 2023 09:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=nQGKWxZFcn193sN9CsQBiY1KyLsxRjWp7Y5mmLq2TzA=; b=v2lnBBLLcCn+Ca +bSQSqwsBSye3HmDgcwuZSEPNiaUOZErRgqM8ToG1I+yiGhvV06/ZDeeWzP0FkmCfLP4BbQ/KmA/8 qPvOT//4NsQfkDrHe3MYAPYJTzK4WR2yCa8hEN/E30xxeVetFWKx046Wc7XVEuJ/MFbvnfJtyQdqs vVqbanmGvDERjNom2UT9wc7s/AkjtZiLgvO6RpHsm7TDWWjFkZE6CUgGXan/zL5ezlgmTs5tla1jU a9JsZHKlRyQ7xwahmAd7mjPvViJpFRed2EYTgyxIe/JJjoUVZa+g+pp1gFvlcNtH/fAGMVg6pE33h 11xsmGlT4LU75pQ2mwiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkhoB-00DqIb-0A; Mon, 25 Sep 2023 09:23:15 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkho8-00DqHO-0W for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 09:23:13 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-503f39d3236so9435268e87.0 for ; Mon, 25 Sep 2023 02:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695633790; x=1696238590; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IDyabU/ctSGF4K3dTAmchO6EjvdapGJuzpqjXfhEki0=; b=gu4lPvXvtJ/j9EvbaUjSD9JEseNH0Eniq9rQf7tRORD+E1y0J/nfnP9tZfxl3PZPGX Xd7oHSe2Lk/PlCRCtrSgDFJPrFCvU01Mr7/BT33hDxMRw8PahekF079UhVZR2qk4B3R9 /3g6ZH2KefUdjY7URVNHIvKu6aNewOucvRaYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695633790; x=1696238590; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IDyabU/ctSGF4K3dTAmchO6EjvdapGJuzpqjXfhEki0=; b=At+G/lDTo509bYPaoZFZ88znsOzJwg+PDoO3hUuoDe5nHwCmf/8nPqRyImr3GMvRc8 EPTsOKvvmAtfbqMvbPZdrAwMOJXzhqYxH+rVaSUDOdP2DNNNVEe+apOarLKwwwvSVVoR y7LzuwCVEJdZ+6utEbA1BoxpVtJWADnvgWZ2gBYPkL0KhZ0YwIuI3Rn7AVyorzvRR89p K/NfgMK3pdOaqd4oOqJHt6KQBUpV4caia1zY8MjPB8tYJsueD8P7ncYrkXVVEF2xL4V6 S1uhN7bpgTGVjA4WRlX2bgy6IpPjMCXQh/yQDxLgZIV4vSABlNMBN1dn+qAqH81vg8sn EtLw== X-Gm-Message-State: AOJu0Ywd008hHdMnZAbFhbYD+4fj7bqZGw9Q80sWN20gM1dxyRhLTJhY miUI1zl+7Y7UXMs/ASVXAGjDoA== X-Google-Smtp-Source: AGHT+IFdJhgh0QBpQXEzpkLS8WILLnuoY/8uaH456FPwyO42nXmJ7Ufixv3ar0REWsyD1mqtS+FBRg== X-Received: by 2002:a05:6512:b0a:b0:4fb:9fa7:dcda with SMTP id w10-20020a0565120b0a00b004fb9fa7dcdamr6155313lfu.26.1695633789773; Mon, 25 Sep 2023 02:23:09 -0700 (PDT) Received: from elfwind.c.googlers.com.com (49.240.189.35.bc.googleusercontent.com. [35.189.240.49]) by smtp.gmail.com with ESMTPSA id r5-20020a05600c320500b003fc0505be19sm6494837wmp.37.2023.09.25.02.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 02:23:09 -0700 (PDT) From: Hubert Mazur To: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno , CK Hu , Bibby Hsieh , YT Shen , Daniel Kurtz , Michal Krawczyk , upstream@semihalf.com, Hubert Mazur Subject: [PATCH] drm/mediatek: Check GEM buffer size Date: Mon, 25 Sep 2023 09:22:49 +0000 Message-ID: <20230925092249.2228743-1-hmazur@chromium.org> X-Mailer: git-send-email 2.42.0.515.g380fc7ccd1-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_022312_223727_135C8A80 X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The buffer size is derived from parameters supplied by the userspace. Having the size equal 0 causes allocation failure leading to kernel panic. Fix this by checking if size equals 0. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Hubert Mazur Reviewed-by: Michal Krawczyk --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c index 9f364df52478..3b985b99d5c6 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c @@ -62,6 +62,11 @@ struct mtk_drm_gem_obj *mtk_drm_gem_create(struct drm_device *dev, struct drm_gem_object *obj; int ret; + if (size == 0) { + DRM_ERROR("Invalid allocation size: %zu", size); + return ERR_PTR(-EINVAL); + } + mtk_gem = mtk_drm_gem_init(dev, size); if (IS_ERR(mtk_gem)) return ERR_CAST(mtk_gem);